From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4D0C4332F for ; Thu, 2 Nov 2023 04:58:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE9448E0009; Thu, 2 Nov 2023 00:58:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C99908D0026; Thu, 2 Nov 2023 00:58:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B61268E0009; Thu, 2 Nov 2023 00:58:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2A8F8D0026 for ; Thu, 2 Nov 2023 00:58:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7236B140E2B for ; Thu, 2 Nov 2023 04:58:28 +0000 (UTC) X-FDA: 81411808296.05.35FF05D Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by imf01.hostedemail.com (Postfix) with ESMTP id 1096440007 for ; Thu, 2 Nov 2023 04:58:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LHfrC4s3; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698901106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wtxaa07jUa6F61fgzQWM1TtKiQftMGYO70e5FyvfLmA=; b=opz2cMjrI0j2dknfib6+4IlOClQdfTY4XIgde0ptFQqaBxsPYW5zKD/Z1/SWaDWyay66Un 2w4Pg3EAknQ7AN+8YXs3XDWOmBjc3ggEM3TIdJPgBsY9zX9NRTfA1HW5kPoXdRfj+0VWXl CC1gbAsuldXrENKvTmLhdtE1/ziwyxI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LHfrC4s3; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698901106; a=rsa-sha256; cv=none; b=ieQqCr+z4E8hWpXZ2MwQ26YXeSQ4kEqgZYRyfOrmNB9NgfkmWLEIGChg3XFpu1R2/6iHGj OTKpibXy5eCHZ+XPJW5gtqLwp3892O7YtePEEjab+m1vgMxeU6eZVuqmFfP4idjxhfoz3s Us3xMpOPp3x6brZpQnor5iJ1ZyKnY7c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698901105; x=1730437105; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=+pyMnDkYcPTN7+ut8ebVV8XgmyrQRcJXkc2Y1qh3vRU=; b=LHfrC4s3nRtqwVuXnoNpOoVVmO3slh0zKLEmo5w80yvfx8cTXkaA6n37 Q81YznKoa/D1+Qnj8w/2Z3ofbZt+cEWEChc8vwQayDERBHCEVjcDEPclh w6a2ws/ortVOh2pMwmZc7PdhKlDLG2OXZ+Annuz6Qpgp0I/sxi+7Lenv4 QS0mNzEOjQSpywGvZQ32W6pvkdwMgd3nLecm3ciSR3GP/yl5g7lLwSeLL 9bLmOQhZSy+LjHJSlE4egjLs7cqNx6W9Y4NZigjzOPN2yQTw2mcalQVR+ Y+hcwoxH/lIXxvS4YYVFejXmGLQCK5F8jWoZstAP+KWWDZ95b0caw4zCm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="367982829" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="367982829" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 21:58:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="790291301" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="790291301" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 21:58:20 -0700 From: "Huang, Ying" To: Li Zhijian Cc: Andrew Morton , Greg Kroah-Hartman , , , , Subject: Re: [PATCH RFC 2/4] mm/vmstat: Move pgdemote_* to per-node stats In-Reply-To: <20231102025648.1285477-3-lizhijian@fujitsu.com> (Li Zhijian's message of "Thu, 2 Nov 2023 10:56:46 +0800") References: <20231102025648.1285477-1-lizhijian@fujitsu.com> <20231102025648.1285477-3-lizhijian@fujitsu.com> Date: Thu, 02 Nov 2023 12:56:18 +0800 Message-ID: <874ji43g99.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1096440007 X-Stat-Signature: 51jsb6pnm5c7xnjmik7u3tqd9jrcgxmi X-Rspam-User: X-HE-Tag: 1698901104-793719 X-HE-Meta: U2FsdGVkX18LXAt/s8cvX9IEefLwt8MykbbLhfu13mlgESJInmly8/AtInaqiacrjxVg5VKbnmkrxXU/QpEvN1e3ZoqeOMD8vTcgHL8NQhKG+0t06e/103sJeEmadFL9sy/8Fcxq88P/OMTfw31Hvj49Hl1QofG8HM2XRHnfXCRxxVdrJ59cJBIeUVr6tF2tyHgLGzbjR6LP8ddCg2Tc2WmQbYw6EymSJdsjEzujXS3c5Kn48fxtOeLmkWJRrsl0u+qccGcFLpK8I7KB0tXw7ES5kKFAjNfGVBFzPUuK6n6Kyaq/9fddQrk19alDlEiN2Wq5ZAfsW2kC3drnE2io8uFw0unEfItKt8ZT6xgVTsMifiLrZHtXdJ27IVfgPhrbUXOXAPO/egnaB+R/0dADPMEm8YjnxjNKyhA2n+wlLAKwheIw1NHm8BWEOqsK1ZaUg0FYULc0YgW3KPIy/mXAmBvOYEXwaPMuIbTiYbqGPeX6B/o/XpWg2bEx/tjRqKZTK2oBTvLWo+IoRHbmclXMvyEkaiovIY7Pk/l0qxsukwu8O+j1c3bfBhP2S/yH+vFprO16EdrtqoemhWr9NpA05q2QdG2ovGEQxuBs+ibBVqKekj3w1j1lg1f1R1jZ4MuxxARFj7cM38Cc2MFYlPWLHqhlflIepWc25DvbSQMUobVwceDER2FKpoIu4pzpzaCRDTxYwgxJX8IrUxhpLEKJcKKCUzqSY70udCwUzpM9iXbmGEsNi8vcxLnKueCIfmzHKNYob/nJI499uiUzOeXwxr8qbQ9ZspwGyjk/zO68YTbsaG737gMJapq3gyy6M8/8o0dS5BkV+FdRb1DYIr30kZm+vubYa/P7r9o/rXC0TQjrDgA2hmJ7lPoZ8MelUEJnGZB+3n4edytvwIfoKNj+jwKjbNHpFN9Fcqr2GlI7bZVmiXEJxdpZQXYA8vq7il6L2uEpPhjiBmPdfUYNQ4E zKsuDbAy x0BXBdeTq++59KRomsnDrC25xhIwHbI10sQ4uWpyEgBpLDC8Vdm3NYVthhDwwzJZ1Di3NOzsmm68Ud+qQ3HG+9RuSONqX3aG2oE79uG5bYdGHMlzkSssVxbJGsgWJ+dfSPJ0k2B+RTcLsHEtu5rJEkRCfDqdmNpTifOXwZvSbitrLRmNWUOHghNAeQEczsl22noKiNOP33bnETD9ystF0X/+WRv6bUN6RVpgZ0z+YIvg63Fx/pOFI2LLbNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Li Zhijian writes: > This is a prepare to improve the demotion profiling in the later > patches. I think that this patch has its value even without the following patches. So, don't need to define it as preparation. > Per-node demotion stats help users to quickly identify which > node is in hige stree, and take some special operations if needed. Better to add more description. For example, memory pressure on one node, etc. > Signed-off-by: Li Zhijian After addressing the comments above, feel free to add Acked-by: "Huang, Ying" -- Best Regards, Huang, Ying > --- > include/linux/mmzone.h | 4 ++++ > include/linux/vm_event_item.h | 3 --- > mm/vmscan.c | 3 ++- > mm/vmstat.c | 6 +++--- > 4 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 4106fbc5b4b3..ad0309eea850 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -206,6 +206,10 @@ enum node_stat_item { > #ifdef CONFIG_NUMA_BALANCING > PGPROMOTE_SUCCESS, /* promote successfully */ > PGPROMOTE_CANDIDATE, /* candidate pages to promote */ > + /* PGDEMOTE_*: pages demoted */ > + PGDEMOTE_KSWAPD, > + PGDEMOTE_DIRECT, > + PGDEMOTE_KHUGEPAGED, > #endif > NR_VM_NODE_STAT_ITEMS > }; > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index 8abfa1240040..d1b847502f09 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -41,9 +41,6 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > PGSTEAL_KSWAPD, > PGSTEAL_DIRECT, > PGSTEAL_KHUGEPAGED, > - PGDEMOTE_KSWAPD, > - PGDEMOTE_DIRECT, > - PGDEMOTE_KHUGEPAGED, > PGSCAN_KSWAPD, > PGSCAN_DIRECT, > PGSCAN_KHUGEPAGED, > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 6f13394b112e..2f1fb4ec3235 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1678,7 +1678,8 @@ static unsigned int demote_folio_list(struct list_head *demote_folios, > (unsigned long)&mtc, MIGRATE_ASYNC, MR_DEMOTION, > &nr_succeeded); > > - __count_vm_events(PGDEMOTE_KSWAPD + reclaimer_offset(), nr_succeeded); > + mod_node_page_state(NODE_DATA(target_nid), > + PGDEMOTE_KSWAPD + reclaimer_offset(), nr_succeeded); > > return nr_succeeded; > } > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 00e81e99c6ee..f141c48c39e4 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1244,6 +1244,9 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_NUMA_BALANCING > "pgpromote_success", > "pgpromote_candidate", > + "pgdemote_kswapd", > + "pgdemote_direct", > + "pgdemote_khugepaged", > #endif > > /* enum writeback_stat_item counters */ > @@ -1275,9 +1278,6 @@ const char * const vmstat_text[] = { > "pgsteal_kswapd", > "pgsteal_direct", > "pgsteal_khugepaged", > - "pgdemote_kswapd", > - "pgdemote_direct", > - "pgdemote_khugepaged", > "pgscan_kswapd", > "pgscan_direct", > "pgscan_khugepaged",