From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A78DC27C53 for ; Thu, 20 Jun 2024 01:41:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C94BD6B031D; Wed, 19 Jun 2024 21:41:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C44DA6B031E; Wed, 19 Jun 2024 21:41:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0C436B031F; Wed, 19 Jun 2024 21:41:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 935B36B031D for ; Wed, 19 Jun 2024 21:41:04 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3BA0E1616C0 for ; Thu, 20 Jun 2024 01:41:04 +0000 (UTC) X-FDA: 82249563648.09.98B8D2E Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by imf06.hostedemail.com (Postfix) with ESMTP id D1CF5180007 for ; Thu, 20 Jun 2024 01:41:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Aq+WhjQf; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718847655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w7cIZkco9u9/7RhK7+yBzITmy9Q2DOll+5jypLnLJLY=; b=V+KLSPDwroiUPOa/Tpdq5OxYu6YWV4cwSXdLWiaUolArd1ZYCdsbtAlSCUXZK/LcKVPs16 JQ9+H38siwWHy1jsYzHOt99V7jw8JH8Xk35Aq02lF66HhksdtN2B7D6BcofdL4BjJobrPj Pky7rKQTu1V4s+oiAH7p/lp//ocpdKA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Aq+WhjQf; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718847656; a=rsa-sha256; cv=none; b=mMbXeBU6l/GIjMt2MNSEm2nBevzAuDXxDuajwFVb1KD64OKciDoUjv8Ry6YCGVM6zJ3PBo l2WlugDIIRfrKI8ejs7JJfmQWMJujpDHfMo8g0sJIMtUDROaO3RhGWXXMc+af2QX4la7kE bC0DKw+C5ivWzahz0Q/O0GZ+lDhKvug= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718847661; x=1750383661; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LP2tOkOMhutAVVXDuLDlX3nRyAhc0XWkEXUb6AMUzzU=; b=Aq+WhjQfUOonz7gtA4tnWAvyz57P+vbxr/N0ce+ooIkAtqhC9Oqn8md4 zGxigbQMl3mUZcXCkHTewMU+Ixd8bv5XmZqRrF5wvTG6A7iwx1sN+QSpc rWfafjQgCuc1JFbQaVxw4jP1IN+lqRyYvAEQSsU+e04RI/TJP2W4Jxfzi 6EFvqJ+0pTQJ5mcL7BLnZ1p1PotPL6wobsxWIGejaHSggb7bpbQT1ZkAh FBcGUEE/IXSq4m+V/Lm5dzyvHGJy4OvMPzMpMahRXiLa6q3qaZCT1twmF A4o3WYsa9d1YQE3uJ0vcrZ17aGa6xD5/kVMxoJsiHg7datVvUmITIujeu g==; X-CSE-ConnectionGUID: Gbg8+83tSgGCJEU1Bw87ag== X-CSE-MsgGUID: 64Tb6c46RFyROW/zwP9stw== X-IronPort-AV: E=McAfee;i="6700,10204,11108"; a="15678918" X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="15678918" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 18:41:00 -0700 X-CSE-ConnectionGUID: yNQNvFjaTCKUpo5ao7HG3w== X-CSE-MsgGUID: x10nX40/TgKT/VnrqFOT7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,251,1712646000"; d="scan'208";a="46996840" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 18:40:57 -0700 From: "Huang, Ying" To: Zi Yan Cc: Andrew Morton , Hugh Dickins , linux-mm@kvack.org, Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , David Hildenbrand , Yin Fengwei , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/migrate: make migrate_pages_batch() stats consistent. In-Reply-To: <20240620012712.19804-1-zi.yan@sent.com> (Zi Yan's message of "Wed, 19 Jun 2024 21:27:12 -0400") References: <20240620012712.19804-1-zi.yan@sent.com> Date: Thu, 20 Jun 2024 09:39:05 +0800 Message-ID: <874j9o4cli.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: ctfs19oacizabru1ofz3qhf8hmj6hw54 X-Rspam-User: X-Rspamd-Queue-Id: D1CF5180007 X-Rspamd-Server: rspam02 X-HE-Tag: 1718847660-954203 X-HE-Meta: U2FsdGVkX18GR1AtHLrdalp4sLAGRLypcGCV/tJLE3TqScxkRZOKoMymxsJNsjlnutB82JlROmcLAJOqGoc0QJT64QdE8+nFnjwO7X6fTvH0lQP/FSwT3SkVNEq5hyl5c+E3HdiFJvgs8bEV3Fx0AmzsnlggU68z2xBgLu5rLci+rMPZ3xLa0YtO/MP5eilLsfBxCizh389eFS/ytxolMRIzdiDx4lzVWGnCP58kY1ccBoFEgQ8vTbktrtGS4tQYlUl39uByTG9LX8oCaDJpvZ7T7kJPJHqm2QFsXwAjXKrR6HWdpGHtZxCrsg6VkqGSiJ/C01SLjSopV/dbgQGICrrNpbfnmTp1e0+yApcvparcmgZvl5KKjcidfiKUMrLxzPkEHv9NUXODEg1fXkM28HWdnVGB/Wt+EIEpkQuOrETD83s3YrL7oo3hmJmcU+q98e4R28MFmKFnT8IAdn+XolVgPP4t26pda9Kl07QCjq+pC0hx7gIVdxeWGfUxECaoILljkbjSu8hNHgJKAGYmR4TYQ04gbC8ue8D8QVfRnUnV8iSxFSlC6EQeqtmzYsGesNVREO1JssqYjIaLW6pBzh83U/6rgP5b4/DgE3Vo/5Zj85aRsohmALYEW4+RGe9+ddWldJKfI7aCS+XLKOdyy4RaxXl4DDoTvu9VoHDFvp02J8AWTMQGjljtbWBoDtYiqAVLrC2TxFh0TjhuJSSl9qU2WfyCYv5viEDPUHRXfOSqL/JYCoNi7Z5KtR0+iA4uwTI7dYzNuyq1tH9QHD+kQqFy6gD+WZWEOuUbvsHCxddP6sH6e8PUA1XKU/new1vJk9Ple/SBu04bHTWZOnBjElS9zZKMeG0Kkx2je7efxNZoZIQEza5bSlroXsRS2EpL9JQCYMEGVAE7iNKzOK/EshTHFpGSGZMI5DjBoxm8sfPDgROq/v/NZHOubTpeLtJPtZV49+YMroT7XHRdCy8 Qg27b+Yr mR1k2RRhNvSHUUzLDPCy5a9DEMmfsz8wVypuxuLwK/4nfwSjxs+++OKLdKstojZPNXQOCJjsT9CwXMPqQNIxM7zezOTF9NOkzj7zO4Rzf9mZfxPzYQB2YvUw6fV+ecjJSahcyorRyZlHZMH8cBm5+GNTsfyUG+FNgevFeqxvMmkWuCPHuUXinMVZ8oqt4XxUYuP1CagZ7Ze9bQMjFsy+rDEwYjx4tRilGrMAo3POVCQqZh7oy9Bt6KSQ/eo8G1bjtRG8LT0oP4Zx9btTQNTZ13cexbGqUCbm3POSqGPNLpx69oS6PdJQJLYt5V7NOKEkD+4E8JOqIfgN+rj7cPVBjKcP1C96qtI19g5Ci2akletQ7vlU1Bi9E91mA6cbNoEPqzR/9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > From: Zi Yan > > As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to > avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when > calling migrate_pages_batch(). > > Because if not, when migrate_pages_batch() is called via > migrate_pages(MIGRATE_ASYNC), nr_thp_failed will not be increased and > when migrate_pages_batch() is called via migrate_pages(MIGRATE_SYNC*), > nr_thp_failed will be increase in migrate_pages_sync() by > stats->nr_thp_failed += astats.nr_thp_split. > > [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/ > > Suggested-by: "Huang, Ying" > Signed-off-by: Zi Yan LGTM, Thanks! Reviewed-by: "Huang, Ying" > --- > mm/migrate.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 66c74b89d3de..781979567f64 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1645,6 +1645,10 @@ static int migrate_pages_batch(struct list_head *from, > * migrate_pages() may report success with (split but > * unmigrated) pages still on its fromlist; whereas it > * always reports success when its fromlist is empty. > + * stats->nr_thp_failed should be increased too, > + * otherwise stats inconsistency will happen when > + * migrate_pages_batch is called via migrate_pages() > + * with MIGRATE_SYNC and MIGRATE_ASYNC. > * > * Only check it without removing it from the list. > * Since the folio can be on deferred_split_scan() > @@ -1661,6 +1665,7 @@ static int migrate_pages_batch(struct list_head *from, > !list_empty(&folio->_deferred_list)) { > if (try_split_folio(folio, split_folios) == 0) { > nr_failed++; > + stats->nr_thp_failed += is_thp; > stats->nr_thp_split += is_thp; > stats->nr_split++; > continue; > > base-commit: 7c4c5a2ebbcea9031dbb130bb529c8eba025b16a