From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52027C2BD09 for ; Tue, 25 Jun 2024 02:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D19DF6B0330; Mon, 24 Jun 2024 22:45:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC9CC6B0332; Mon, 24 Jun 2024 22:45:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B91266B0333; Mon, 24 Jun 2024 22:45:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9B6196B0330 for ; Mon, 24 Jun 2024 22:45:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3947C8147D for ; Tue, 25 Jun 2024 02:45:26 +0000 (UTC) X-FDA: 82267869852.10.2CAAE54 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf06.hostedemail.com (Postfix) with ESMTP id D6F0D180003 for ; Tue, 25 Jun 2024 02:45:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bfrWw0S5; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719283513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ankm3X93RAH5KLWIuCfUEViCWPgOvDMASNffm4HhHYM=; b=lhAVpOOy2NoKM4xZTUwjvgK1CoXAx1QO4x/i/yuCKdgkRg7XiSN+bKxepPvNxnn8GFTEWn gBe3bnlIhl+a0BzWYjK5SrpnHjsNp+aoSbzJSYrGbn2MF8Vhy+1DafJkHaow5+nmDyR7NL jX3M0cH/IHLAegF0Iacm9kMIeRM4/yA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bfrWw0S5; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.9 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719283513; a=rsa-sha256; cv=none; b=uFCri8Xi4V1PkWLvujDlbHQk3YH576I68S9eSngEfV4xWuS7ZRz3LXS2zCDRL7JRDI3fgO c8spYs3EX/o83ZTbA0WkfqnmXfdX3wx3x7wm1WC8P1nMPozESMgnDTocMXddk4SGHyoGIy KaDevWazwF1m1e2uB+vRaBeWvXjtmZI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719283524; x=1750819524; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=SBo3zsvA+hf3anXcpG/BxWV2BmU3g1Cm3e/BqUs8Hdw=; b=bfrWw0S57MXA47Cx+rzAX/QLKpakzgWCtbHsjjJFzPThYH4K+bRGz+NZ 7CbL3NjGrfj7VfswsUBKuPYYyp2n4eL+jiasO63bAsohQGnvNlS+XgRcP orZVBERn9CuzvW58jsjIY4zDFzz7yynaLAJO1+jqbv1D4QvALIPqyZ1So zzClHhavUaEybQgXaqSyiTb1GheS37/+dMKgb+8w3Y8kfPYWnMye6CZhs 43qATo0t6zg3KaeurVmXsk9mFYkj8N4DChtWz3weMvZB893MzOrPtQ0YO MP/XWg9cDYX+56Bo4OPUm1F9jbPFgA8Y66cE5RlejLeer0BjWilVaGij0 A==; X-CSE-ConnectionGUID: xDNWjha5QseeLQGWRVQUdA== X-CSE-MsgGUID: BfEYFEWlTtq/FCY2tdNzdg== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="26967931" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="26967931" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 19:45:22 -0700 X-CSE-ConnectionGUID: 2rZ+Wad2QN+2B/8anrqfQQ== X-CSE-MsgGUID: G5+r7RjlQdqlmmrhtSBNQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43926544" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 19:45:20 -0700 From: "Huang, Ying" To: Chris Li Cc: Andrew Morton , Kairui Song , Ryan Roberts , Kalesh Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song Subject: Re: [PATCH v3 0/2] mm: swap: mTHP swap allocator base on swap cluster order In-Reply-To: <20240619-swap-allocator-v3-0-e973a3102444@kernel.org> (Chris Li's message of "Wed, 19 Jun 2024 02:20:28 -0700") References: <20240619-swap-allocator-v3-0-e973a3102444@kernel.org> Date: Tue, 25 Jun 2024 10:43:28 +0800 Message-ID: <874j9hzqr3.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: dyk1gq9t9rpq1nymy3p9kjfbqp67hmfs X-Rspam-User: X-Rspamd-Queue-Id: D6F0D180003 X-Rspamd-Server: rspam02 X-HE-Tag: 1719283523-216908 X-HE-Meta: U2FsdGVkX18PJXexzgmPpQ8JrxM/kCM1pMNfSc+Pykptj+xdhB13HM53rQOeiRdRi9zOMoeDyDtqmZeJbF9nGmr90qppckynwr8UgQHPHJ1XfojJfsudr33T2ZtGfa+ozV0oSKF8CZHvISEYiJDtwhiHZijyxnestLJ0PpOg2/IV1UKH8K/fPfiDjDTmihQeDGLE67RMrzCNkIRtkyncSeZNSMmnhyt313LNXJ4R7bngK8HBTU0mu7ja27EBCr4p2Z+x+/8bPEQXWXpqMnH9d84lxizlR5YbC+AZ2r34C7HYepTEDMhKeN6jh2TXTeBvRry29qtzPMVQGDIOF/DUAYbVTFFsXgioM0d8l1Q+oDKfnZQ3LOXTQnDgHMV8+qAwYvqrWiOYV7igUMF07hmWxbQxSZY2dJN8zUMeRejS50HMZgd+SlLVkeNIhPQhA/hxp+vWgKX9oqvlBaDmvsbfRb6Ippdk4y28AH4Bp6wyNNj5v6EcShrbtfDMJEUK35P+Uu9S9ahlU0mOsueQeR6IlgNN3UNRrxS9xnOw7UZELxZx042Fa41DpcvQf8xWzaYqNSO6xUMg0mEKHUDr+8o8OfHtktiStz/F+vt1oPZiXq7pHdYs9bov5erB6axdwIqyQ1xtCcN0kHwcXW4SIPR3BQEC8iMV8ea5vbxV/hkwuf91yOC26s+3pPLz1D/iCUtmFgSs07qj1sasTVcDa1UuH91+4M/nJiQNA7r9HCOYREP2iqgiPzfXMqvYqTW+pD+qEbGkuxRsmECctEXy/1orUqUZJ8zVlcba6ryjpOgiXAXk7DqtwehmlMq7QDTq60JfS/hntky4akADS/4CBF+DmJq3Ty08cZUFMBUt/mrekojaMs9KOWsmLcvFaOBC+PaY0VHvDzJ8ZkXANISab9mcT7CWdLxgTabHsjLIg9f6qEPf9uPu4q2u/LMo1YEEa019/LPzap8ItagjCpHLUmi l98VgYn+ 0DAq7taDXpMFqfzWWeBKwgrtJcruy5htVBBzNAdYnWH9/95RXwD43z/zS3XpNbcKOYIcOukSbBiOyFdUiy3AM7m1m6Ly0d2mIwIhvIazUx3aJaWk85m1WePRi0Hi2PojMdSM7FCHOXgS8YuARZQxr0IVejMs8xFztcg535RI2IiD6pJ61+xQCSg5ZJOVO+III9CvbSZHJlJlRoN1pz5DQvEYhuZ4x7LpXkICd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Chris Li writes: > This is the short term solutiolns "swap cluster order" listed > in my "Swap Abstraction" discussion slice 8 in the recent > LSF/MM conference. > > When commit 845982eb264bc "mm: swap: allow storage of all mTHP > orders" is introduced, it only allocates the mTHP swap entries > from new empty cluster list. It has a fragmentation issue > reported by Barry. > > https://lore.kernel.org/all/CAGsJ_4zAcJkuW016Cfi6wicRr8N9X+GJJhgMQdSMp+Ah+NSgNQ@mail.gmail.com/ > > The reason is that all the empty cluster has been exhausted while > there are planty of free swap entries to in the cluster that is > not 100% free. > > Remember the swap allocation order in the cluster. > Keep track of the per order non full cluster list for later allocation. The "non full" is a kind of negative naming, can we use "partial" as that used in "slub"? [snip] -- Best Regards, Huang, Ying