From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26EDCD2447B for ; Fri, 11 Oct 2024 07:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1B886B0099; Fri, 11 Oct 2024 03:01:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACC446B009A; Fri, 11 Oct 2024 03:01:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993996B009B; Fri, 11 Oct 2024 03:01:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7823B6B0099 for ; Fri, 11 Oct 2024 03:01:09 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1474B140F2F for ; Fri, 11 Oct 2024 07:01:05 +0000 (UTC) X-FDA: 82660424616.13.EA9E93F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf17.hostedemail.com (Postfix) with ESMTP id 1742B4000B for ; Fri, 11 Oct 2024 07:01:04 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EHHEfvH6; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728629915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n9ixK3yvWhtDt++xneZp4XM9NnhFz6jbnowZiHTVW88=; b=NWk1nx39L7eYGbjXQdvoRtpP1DGosUc4jDGLvhsNdaPLVrJwBSVaq4/f+x3J+QQNXbRazX iYr/OkP1d5FaG0JjMGf6Ak33yl/pgWI9ilsxKGaMTnrqqxCESzTBy5B4I5rH9wyWOm0COA Pvc6I6asfcdpLLkbssLaYQ4PiLuQug4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728629915; a=rsa-sha256; cv=none; b=1tElmdbyUZETepq8P0hqFff5OIP/zU8rfC34InYUJKtkhnXM/qo1SA8TOCn0M8/tm6611q 3YyVSNiTP3HeV4tzSUfN2RwTmY7bRgIYOjtknmm70w+eCtZHVK7vvsO8ZLaTN3zYgxWxCl TF7mjxg/dN9D6Dm1FDeCPs9207BBb6o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=EHHEfvH6; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf17.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728630067; x=1760166067; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=MwumLah0heogfgY2jBbaLZlTmYy8EmATRxyZJ/sFqnI=; b=EHHEfvH6urQr83xzvlE8jRwp98EL5b2eca2tIn5a2GPR0S8liqxVpmCJ LeswS9we7H0Hh+7NWrasIKwCxdRRcLngFwdmYLHTjeadSp6IiFe4L1QW+ IBnBqhpjjvtS6GKCWy3mPzGmmr3zzEZD7IveBp6RScPotjXEdNl1YmPo+ LIYAjfmgjQqIJYRVM213HNZRT5Wq4/2cVH/CiE3SdCvsC3aOf9sgmQCto fW2ioh32sSM0hEP2HHmfsRsHrr/wfLu6X8dioE2Jn9DL4FpKGBdRgYUuk BvBEeaVIaIsAeT2T4jeT2WwJdK5dSvB2OaWuFJXNsFXwgb9PRD+bWug1n w==; X-CSE-ConnectionGUID: DhQmn8NPTRquy+E8ADOnkQ== X-CSE-MsgGUID: +lu0B8H2RMaQ0qsQGnAZFw== X-IronPort-AV: E=McAfee;i="6700,10204,11221"; a="38592022" X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="38592022" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 00:01:05 -0700 X-CSE-ConnectionGUID: C5Zp0ThHQDG41+LNjk8vKQ== X-CSE-MsgGUID: DlKyb9KRQ3iM1eqRd2Ocrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,195,1725346800"; d="scan'208";a="81624165" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2024 00:01:03 -0700 From: "Huang, Ying" To: Zi Yan Cc: , Alexander Potapenko , Kees Cook , David Hildenbrand , Andrew Morton , "Matthew Wilcox (Oracle)" , Miaohe Lin , Kefeng Wang , John Hubbard , Subject: Re: [RFC PATCH] mm: avoid clearing user movable page twice with init_on_alloc=1 In-Reply-To: <20241007182315.401167-1-ziy@nvidia.com> (Zi Yan's message of "Mon, 7 Oct 2024 14:23:15 -0400") References: <20241007182315.401167-1-ziy@nvidia.com> Date: Fri, 11 Oct 2024 14:57:30 +0800 Message-ID: <874j5j9let.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1742B4000B X-Stat-Signature: zdty7rd4usxak6r9mjhnjjg8by4krx9s X-Rspam-User: X-HE-Tag: 1728630064-962694 X-HE-Meta: U2FsdGVkX1/VyIpQwt79po/yqov1TJ/L2QKqugAwo0u0muZsfQy7cVWPKa8XPhPnj1AC72BS1j3H6VsXQcjJhYIDXfM+C8bIdqVqhFqth3naQ+8YcOOb/l2RZjallAOHDDGYoDeKHwZjwDfwhKVMT4jrVDjXU3UgkYHFsQShEusd6d4pnl3RjZFJELr0Gpy9VR6x+oVny8M8cx8KCgJaoMPGU09OmkI0lbG0nWb7eK0ZowAIDDIqbOjMj6zNe7UNcqG2NKNIOnn2ZzyEIzaDBL8qcjmJoujlJqziVwFdiVspJGtI82XUgQcy8Xgi1FhuUDaRXli8FggVbuYD4MHdfzCs7po+8dVsx9t9MShm53Ti7Ue/qqg2qKASyIakabGHwyENo+Q2ACSgWmSKpR/NxdFK+B+Gz9q+sh0Tr/CYhlM11OGqui3e/iRac2gtpJ9nUrCnvvilGNxqvI/VQG7ZzePc6a5l9kJ14/u0mIJYinx3Q0Dg6+3b67LzXS6TqIvxBv2AZ+o4WiLbeZQ1k4Ut/QulmJBhAF3wjalOzpfwGxRPrWqNSoA7bPhuajI7yyxG9++RlgzaPtdRqqPBKIfuT5Bzvh6/xRXT4MJayuab7/Y3+gKy+pQoIJb7aQ9fco1CUspB2JlSPVnvjJ/tw09iWCZG5lwP5WFyAKPA46ZJLqTgL+YqY+7liWO+6m342P56Gl6fWpXnmR7w2dtOR0lMZw893X3e096uxDyMSSceV2FvgJrfPJxwAHlDITKGPPeoqlubqinUJREE2EIW4Z/yWJxn/LGznaVUI282AaHo00MGB06Ki9OvvdYKbM9nqRvYHJTA8SK5R67NkLsPSJm+kJwglgs5b1zDfWUsQTM2Oi47krXCr7QINHVPqo5sXGO0cqpvqbT8o15cVxJPCMLNQvV0MmKUHieIgRDEpypk3AcI9WHw1ZyE/QnTDM0sJonxMEtmytA0nvDI+PjU58C gDTIXHhu fuWUOmIuI6u31se7RIAnMuyoYzvJHdYEXe1cpR94NgdXUH3fNKjaM5yNHaPS0ioCLyLs5twPoq/VjutZPHCiQBodLQNxEVMP6kZ54ZDXqXjCQ/vyQ40sxOabxK63uKtA29V/8NVpNrsGcdtSL7B3xB66CTP1lWDFM+hpCYEeUNI5O31D4T4zCujj5jAxwsgZNOVpiT85X7GbPtQVX83XdeV23KTMSWGcgkFvmpFe3nzcjESk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: [snip] > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > index 930a591b9b61..4b15224842e1 100644 > --- a/include/linux/highmem.h > +++ b/include/linux/highmem.h > @@ -220,18 +220,8 @@ static inline void clear_user_highpage(struct page *page, unsigned long vaddr) > * Return: A folio containing one allocated and zeroed page or NULL if > * we are out of memory. > */ > -static inline > -struct folio *vma_alloc_zeroed_movable_folio(struct vm_area_struct *vma, > - unsigned long vaddr) > -{ > - struct folio *folio; > - > - folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, vma, vaddr, false); > - if (folio) > - clear_user_highpage(&folio->page, vaddr); > - > - return folio; > -} > +#define vma_alloc_zeroed_movable_folio(vma, vaddr) \ > + vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, 0, vma, vaddr, false) Although just one line, I still prefer to use inline function instead of macro here. Not strong opinion. > #endif [snip] -- Best Regards, Huang, Ying