From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B0CDD13570 for ; Mon, 28 Oct 2024 06:20:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52EE86B0083; Mon, 28 Oct 2024 02:20:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DF766B0085; Mon, 28 Oct 2024 02:20:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A5B86B0088; Mon, 28 Oct 2024 02:20:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CB4B6B0083 for ; Mon, 28 Oct 2024 02:20:56 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54FDDC0741 for ; Mon, 28 Oct 2024 06:20:31 +0000 (UTC) X-FDA: 82722012156.23.6CB08FB Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf01.hostedemail.com (Postfix) with ESMTP id 9DC964001A for ; Mon, 28 Oct 2024 06:20:34 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="KUFk/V2b"; spf=pass (imf01.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730096295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=khNIqlGJkJXvCDCm7sE48QU3hMlKba/z+e4KkjlEigM=; b=aQcO6zmdl8ZunXgv3rT3x6ic98eCysKoJid5tVnp0Iy7MvFInbpVEp5VeZ/hJhW9i1AdSW H+9QBxwJnbXD5oI1Kx9LE1nISxOLP/c0g8yfjpAV1fdxdTXjITxFqwvfsjwy58n41lkhUz daIcGNygO0bP9Kz3Of5hb8Y1YUsYn1E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730096295; a=rsa-sha256; cv=none; b=EEhIZ87Up53BUwJzqNEWeItNJh9b19vfa1HSLRGyPMnUfusodIJrrIKdswNm9E3Kz1aRVu nhLUM/bSJ9l5o/4AawzwLm5vNMstAZR29BmLOnOhmPvuQWEzPVvMla7IAWKKxQ2v0Axp3K pfuUaZrsKzzdVDwFlVmf7vB3dRXZ3MU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="KUFk/V2b"; spf=pass (imf01.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1730096453; x=1761632453; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Sc9/6h7B3AfJY1OjHXJ5k9EhsTap4dA/QKg8kxAV3jc=; b=KUFk/V2bnPnI3hB1fB4PKEYp+oyQ/2vnuPWqzGcUhsUxRZhmkuQXR/wY eKhnDoeASCmYVqe+ojYuBJ9D/MdYiigJiHIwdv+/7/dbliXOAsbQEt/WG eIt2X3ErpJY/h65PKoDblaUvYcuwoBlagz7UgSHS40RT9ZmKDEY/Rc0/v X+FK0yfU4GEyMAHvkw5IWJxYhSi+FY/zl61Rx9/LqoLs8JY7D5rYdbZrH DTcj5bRpxtQfF6fDvXD482Vt5GhQQiNm0V9NcYelCl5pKV7blOovMpKyt WZF0yWmE/HTmCmnMunXLZTp2JpBa0n8/ccNC7xFU4VqtzlEFd83VwCugz g==; X-CSE-ConnectionGUID: PO5s6IAuQGeA2TiYByt2/w== X-CSE-MsgGUID: 9Ya6G4X6SJWSUxbp/xKS1Q== X-IronPort-AV: E=McAfee;i="6700,10204,11238"; a="29786474" X-IronPort-AV: E=Sophos;i="6.11,238,1725346800"; d="scan'208";a="29786474" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2024 23:20:51 -0700 X-CSE-ConnectionGUID: UnwK7f2rQe2b/TBdQ3czpw== X-CSE-MsgGUID: 7jv20IqTRHKToka9LYlCYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,238,1725346800"; d="scan'208";a="81431637" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2024 23:20:49 -0700 From: "Huang, Ying" To: Kefeng Wang Cc: Andrew Morton , David Hildenbrand , Matthew Wilcox , Muchun Song , Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() In-Reply-To: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> (Kefeng Wang's message of "Sat, 26 Oct 2024 13:43:06 +0800") References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> Date: Mon, 28 Oct 2024 14:17:16 +0800 Message-ID: <874j4wycnn.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9DC964001A X-Stat-Signature: gp3137qn3zy5t74pnsmueeawojx41ky9 X-HE-Tag: 1730096434-817052 X-HE-Meta: U2FsdGVkX19/rt0HOj/I8dvvo0xdQJ9C1ua7lLZZwIgPHNQhz9Ow0KCXrFE49eEEKNKbWFJR6rEYCetRfijEzy8fQb0HKUszo9qesp2NCpOVyfCUEDlm7YcD8S3wCTQsg7ea8F6mQxPMVO4IBqqy+NoGRIV7nO+hC8ylMs4mUxe/83Iq4ObkDRGxhMzMa+r9Ted9kpadgRHHByV3Qt/5I82iH4aGhcZmpRKOStf1DQoIbqTS6ZUEAcmuRtziIDwtvFWLPzJlLQekZUFynSYYfnA2w/jAuL44p+a/mwxfFqfA2jBqBX/ND7d+g/+po/JI/zy4NplEwhjvUmybvcc+nRSrTz7uE7KlKXJJrDHNxrfOLhjgqm2cqxpoxqQAcsdwqdlhvK02U3pbM6Nkf0qBshiabiwJPlfn1p6Au5APz8pyxl7nNtBYxXdkgzFZgNCEucLKJIDqOcPDg18ZgJB0h6UdIYc5KnS2NAWZvPuLoXlRXdbMFwlUG2jG39OoyE23AH2j82QMheGajZeK7XojhQ7DyBB51/BK7MbkBD6e/sKWGwbDwZXQVtiXI63MvPc8YlLz48pLqHiA1+jFHhvatf9HbZG4bB8Lh04WCZ+cfbg3JaBUTnfagzfXk9eRx3O4iQOInHVhdP7oLVBDXQ0EulprkPbkhaZHunUag4ltMVYKDywUjIljUTsPVo+Y42tSMKICzJnpxKJseRI5pJdEvZRZqUtNZwnMk4nzMJfsKrGwf0P81LIxXEvMIVhmYUttJO2Jh5FNEDMMvD5/xNwYvJmqT+hn4WaXiTv9uX+6rVKX5NzbngOiE3cTTuJSHMUPfHnzPW/SRzZbvrxad46Ka3QmOuiTJxuRp4G2Z071HYRQazWxtyXu2W+hnvQBfEt0puhMou1feM1L1mlyznjqmo7hOWCqAAgyYgsHoBblsPOT4UujGMeerXufyVZcysYIV5LZpFPJ0URTvDenWhj zYpysGQl RfvxDG07yQ3FzpDcD6DTOKNBsBoWHy9f0L45ESglYgH/zdSw12T+7taZgo44TdSoHmcysItXiPN/o1YIprOC+9rgw3Y7AvxduLKLVGc7aIp9adH8u2I1uvC9NikSIj2Br7xLjRkwCTmPhilttENVATgYC+tbeMghF7CM2ZcsP1xqUINiU1ojuDv+rSnjmeUwlwhwvvnG9RNn5pT2CBvI9OduqjKq7ESsKGVStznLIzWdHn3Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kefeng Wang writes: > When clearing gigantic page, it zeros page from the first page to the > last page, if directly passing addr_hint which maybe not the address > of the first page of folio, then some archs could flush the wrong cache > if it does use the addr_hint as a hint. For non-gigantic page, it > calculates the base address inside, even passed the wrong addr_hint, it > only has performance impact as the process_huge_page() wants to process > target page last to keep its cache lines hot), no functional impact. > > Let's pass the real accessed address to folio_zero_user() and use the > aligned address in clear_gigantic_page() to fix it. > > Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to folio_zero_user()") > Signed-off-by: Kefeng Wang > --- > v2: > - update changelog to clarify the impact, per Andrew > > fs/hugetlbfs/inode.c | 2 +- > mm/memory.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index a4441fb77f7c..a5ea006f403e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > error = PTR_ERR(folio); > goto out; > } > - folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); > + folio_zero_user(folio, addr); 'addr' is set with the following statement above, /* addr is the offset within the file (zero based) */ addr = index * hpage_size; So, we just don't need to ALIGN_DOWN() here. Or do I miss something? > __folio_mark_uptodate(folio); > error = hugetlb_add_to_page_cache(folio, mapping, index); > if (unlikely(error)) { > diff --git a/mm/memory.c b/mm/memory.c > index 75c2dfd04f72..ef47b7ea5ddd 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6821,6 +6821,7 @@ static void clear_gigantic_page(struct folio *folio, unsigned long addr, > int i; > > might_sleep(); > + addr = ALIGN_DOWN(addr, folio_size(folio)); > for (i = 0; i < nr_pages; i++) { > cond_resched(); > clear_user_highpage(folio_page(folio, i), addr + i * PAGE_SIZE); -- Best Regards, Huang, Ying