From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38867E77188 for ; Mon, 30 Dec 2024 06:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FECE6B0085; Mon, 30 Dec 2024 01:48:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AEF76B0088; Mon, 30 Dec 2024 01:48:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677146B0089; Mon, 30 Dec 2024 01:48:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 495B96B0085 for ; Mon, 30 Dec 2024 01:48:22 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B6379818F9 for ; Mon, 30 Dec 2024 06:48:21 +0000 (UTC) X-FDA: 82950694932.30.E5B937F Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf18.hostedemail.com (Postfix) with ESMTP id 6EB661C0005 for ; Mon, 30 Dec 2024 06:47:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Fo6+nyNp; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735541278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/AwuAd7NmxHOcLAwF0cZchKI9Q0tAqOE3/y0/huDXSE=; b=pOFIdEW+9czpWIPJAT3B0VZpRNdRXG9s+qpVNCZ2UdxeBVNAPV3wW2qNpB2dQ5YaqbkrAl 3rsJ+kxxnbRz2zL0LJxkAlitOrnOYdsCTYunnYsBRTbxeflhJFcIUrImzvJ8qzMiygnO8h nzuAdciThEXte87QRtHcTsWm8xAyIVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735541278; a=rsa-sha256; cv=none; b=UhZixplujqg4q4xyHvBBEPN4k//YPMHLMtEN2iza8FBksTmAPiIqOh/XqVCw7GOjUuDYcb LnkU2QkYRjft8rt1z3jH5jV754SrUFgIYjvPUGpglD58SJULpnQiXjnFhfPc4i6cvfMonr YaD9X+SUqBgTx5IsqrRqcS6qt4QnxPk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=Fo6+nyNp; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1735541294; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=/AwuAd7NmxHOcLAwF0cZchKI9Q0tAqOE3/y0/huDXSE=; b=Fo6+nyNp9eQMZtGoYcDtI4ub0y8EG/pKGBPlJlHnv/EKMf05z10wrsDR5v7ZL6jGGRjzYzLbHHX2j3hG5jwng/Z3UlVAcRLhEk8lZAxxf7wLo0f7LQYkqJmGoXGaEaFGAFsHmZC8L9/MzN9OINCFBSXBOXnwvuFT8PeV8gM/AR8= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WMTFksv_1735541291 cluster:ay36) by smtp.aliyun-inc.com; Mon, 30 Dec 2024 14:48:12 +0800 From: "Huang, Ying" To: Gregory Price , Joshua Hahn Cc: hyeonggon.yoo@sk.com, kernel_team@skhynix.com, "rafael@kernel.org" , "lenb@kernel.org" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , =?utf-8?B?6rmA?= =?utf-8?B?7ZmN6recKEtJTSBIT05HR1lVKQ==?= System SW , =?utf-8?B?6rmA65296riwKEtJTSBSQUtJRSk=?= System SW , "dan.j.williams@intel.com" , "Jonathan.Cameron@huawei.com" , "dave.jiang@intel.com" , "horen.chuang@linux.dev" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-team@meta.com" Subject: Re: [External Mail] [RFC PATCH] mm/mempolicy: Weighted interleave auto-tuning In-Reply-To: (Gregory Price's message of "Fri, 27 Dec 2024 10:35:56 -0500") References: <20241225093042.7710-1-joshua.hahnjy@gmail.com> <874j2rp6or.fsf@DESKTOP-5N7EMDA> <87cyhdhon1.fsf@DESKTOP-5N7EMDA> Date: Mon, 30 Dec 2024 14:48:10 +0800 Message-ID: <874j2lll91.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: kuf7qi9f5htti44wehbpwh71rei6qmcs X-Rspamd-Queue-Id: 6EB661C0005 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1735541276-632739 X-HE-Meta: U2FsdGVkX1+FBkm7WWtMd13jJiE15mMkToOXbtu2f9U2ZM+9AFCNVngl2RvpeHpNqlK6ZXfVln4vZrdeIR3NYh3LSr4caSANVZhTf3UJr8Sd2Urs0LwB3bQQTsovvDp0/LpM58iQbe90E3kfw39CeMGMlbiCMXFEF/JT8Y4z0c0spSImGF+e+cWS3nx1pckiRDrrAU3+9AAgkI+k3LoQxf4twu++6DKorykZEtGU8tDD7u+b2UnyVKNnxvPaZhqd6kmLfkhVn1MCyvPAaj71qbzX9IB+Wgug2N4wYVlNcvPBWsJtaSfX0MmQftwSc2nJdkB4Hv1R7uoDD30SRQDJiWKpKXq4xW1hrNbVl9OYEKKtf7RZNyIlLarJogsK7/fUpz0BGYAluYJnvsEYGvIW+D/qVP4E4/45Wf1WIPXU38N3AwJDzdK3BT80rSWq5yqzCPVduWUv6RFWlrHobitJneDUZIHnLRqkAQX+M+ciBRm5njH5edyNMFvq22DigDYa0mA1urf3D2mR0CaaXGQrKEDpZ0OBRyOouE2GS2AsqkMEPr96lH0nb0lJh67LPJ0FZdqldkrU8nnMcO9kJvOKFdYTmEGJbbQ3ZXFLmbYd+xzeeFbXL6yV9yM9c+aaQNCwFTfwLXBp2mlE6b+oBw/zLec2HIoieyV+NVvjITQ49X8u0CHWtzwM4VWZy/oYW7R1CVvb64JJNkdufj2ht7medpIVUMBEmSjMNJQm2+N0xLmeYkgRGZ0uxVKZ7vQ0nuXcV4RGHYD3IONEEZiw1MmzW7xEUlJOXJU2xrFwbwKClEixWjaGs2E4hlleewuO3xXfgb2Rd5TTDQ/tHJV4EPwBQSDZvPLZzQGwUmTKcqWzSEoz6bbftN6pqLiWr7ULO0PC1963QYaGG1jjvoJrfFcfBbBWnWPSym7qOVamPOr0JtP9WRMJZsuj25RwIqqaF6D6wBh8HM8n25XpaI/LDsO KDrysZ8C eYU7TCioEr4BHW1vysiGx8044DwYM4gwxso1wbnZgjDgYHNEjZbtpNkgwHlNUdKXa/+IS+gICpXzMcfsu2XyrofB6pG4b0Q7c4q6YqARJqVwQIilucpn7sRBXp35Nud3/0Swc6aid3wmDf/DT/DKlXd4cUAlfOWpGn3IVEadZQRonaGM0zxDbGpQUxyAg+PP4sO+gPIVKnD3yvwGRoN2kFJteHgRJcIQq+JgG7Nfh4v11fFwOAk01FRhpqeguEJSwaIsSi7FeD4FE3zWWMPulgUAvDq1aBaT6uK6EM7cTfI3QaShFdbaA2l9ePASjo5f3eaU6bPOIvlRhYb7kiVo4+2e8I30O3PNkiIT5pNRCEe5VwuqIPPaK7ZqLB4URTVcmn3NF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000155, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Gregory Price writes: > On Fri, Dec 27, 2024 at 09:59:30AM +0800, Huang, Ying wrote: >> Gregory Price writes: >> > This still allows 0 to be a manual "reset specific node to default" >> > mechanism for a specific node, and gives us a clean override. >> >> The difficulty is that users don't know the default value when they >> reset a node's weight. We don't have an interface to show them. So, I >> suggest to disable the functionality: "reset specific node to default". >> They can still use "echo 1 > use_defaults" to reset all nodes to >> default. >> > > Good point, and agree. So lets just ditch 0. Since that "feature" > wasn't even functional in the current code (it just reset it to 1 at > this point), it's probably safe to just ditch it. Worst case scenario > if someone takes issues, we can just have it revert the weight to 1. Before implementing the new version, it's better to summarize the user space interface design first. So, we can check whether we have some flaws. --- Best Regards, Huang, Ying