From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B54AC25B4E for ; Tue, 24 Jan 2023 14:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F966B0072; Tue, 24 Jan 2023 09:45:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81F6C6B0081; Tue, 24 Jan 2023 09:45:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E7CD6B0082; Tue, 24 Jan 2023 09:45:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5B7E96B0072 for ; Tue, 24 Jan 2023 09:45:58 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1710D160B4A for ; Tue, 24 Jan 2023 14:45:58 +0000 (UTC) X-FDA: 80389967196.28.41172A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 14C37140019 for ; Tue, 24 Jan 2023 14:45:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hb126B+R; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674571556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fYiLuIxDhxiPph2V06Yyb1fMH7liPtcXmyWu5UVVaS4=; b=DI0q8/qK3PLCDzx40SZJjGl5m7qV7GKhgmVGctd0J7zVjIVxNR8OkEMT4gb7PD0PvuHVR1 4kby4+cRjZ/a0RK6o2scsRarH6iO1KXSc7eq2nf4YWxihRwQzuuBIGVKMIHw3VtPMETpnK 4wEwk8wTdP4BcPLslKA4ytSZcvosf5Y= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hb126B+R; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674571556; a=rsa-sha256; cv=none; b=iLSZ54U/8BpfJXfLNJpoBP+qa2OdA0Lkqy8zcga6k9ujwC8YLA5UOHGqYs0pB4gDzrBURM zm2IEYqzyw1ztgQEifuQvaF/eRMwHWrdgcITFtaDjh27L7n4mWMxQtvEj+DlrvgbKGQbqr FDmBjhUTndN9c6+9gm3bA4Je4iW3JQM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674571555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fYiLuIxDhxiPph2V06Yyb1fMH7liPtcXmyWu5UVVaS4=; b=Hb126B+R1MNEPWkAKs22kvVOCWQtX4oCjmej9xvKPZbVUoCW4s2wqpcriJ1l6zWgw2gdqC a3XfLaCTvazz1+AKHryMCPszlTNGp0J3x6Vb7r86XmK1dHo6guV2ST2DElgFJKmgr5ZATK WtTfgdDrb6oyFf66SLmMeqdO6ZlSkM8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-LK_sA-vOO2-ScuK82JjlNQ-1; Tue, 24 Jan 2023 09:45:52 -0500 X-MC-Unique: LK_sA-vOO2-ScuK82JjlNQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 512D21C07587; Tue, 24 Jan 2023 14:45:51 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1C7C53A0; Tue, 24 Jan 2023 14:45:49 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <5bc85aff-e21e-ab83-d47a-e7b7c1081ab0@redhat.com> References: <5bc85aff-e21e-ab83-d47a-e7b7c1081ab0@redhat.com> <1b1eb3d8-c6b4-b264-1baa-1b3eb088173d@redhat.com> <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-3-dhowells@redhat.com> <874093.1674570959@warthog.procyon.org.uk> To: David Hildenbrand Cc: dhowells@redhat.com, Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , John Hubbard , linux-mm@kvack.org Subject: Re: [PATCH v8 02/10] iov_iter: Add a function to extract a page list from an iterator MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <874736.1674571549.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 14:45:49 +0000 Message-ID: <874737.1674571549@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 14C37140019 X-Stat-Signature: rwjhwh3jm4cgppxut4gtmztw1s5ku5wx X-HE-Tag: 1674571555-36952 X-HE-Meta: U2FsdGVkX1+vjbQoiM5c8eSh1h+r+06P+yQdJZMbF/qCx5wSsemSZqqW6hFfo9ifYNFT+4eDDnKUC9oUbBdLEv84vCLCp8YoWq45UNVqft0xDhKN3KJXGnuOzXnJDWwKpl2A/ry9GNeit70tBhZZ0vRGRMh57i9zpDSNqBsIaHI9xerhd9LP8Ibkyn/O5gaGDmqJhvqEgfIYO0w1Ignrlvxib4Qs0Z8kVMMF+k24VKna0v6hF9XnbIn0WR9vrkkIPcc/9SFLDZB8H8O/KpCMI/CKQqUznhmJg3ZpAFBFA8ASN8AarcGPU1u98gyAzh79vO8XGS0AkYFYtgMm/UitvfKL4n9jcBh91NpSOrHOUDOS1c2JRO2BTJW9wGwRruXr+c7QmZ6uqxamp5JZUn38UWqBPKO0SojTzT3wsiFbItMVgftDQmSHzsB5sTPLgBlnnMcZj3T1VVx4UnvKDZcwFcME4ZHdCXToA7sRnxOkWDNNUwQ8Sjkkhd6JHWD3CyDQNioEDm0oEfuqUEDrYY9jCjs7lmhmlfnU35/CH9aSPygacJYMvQ18ZDCDNRZVKOFQseuZAmw+4HqLshgkZSxYvsM4/B7ClFv1HcB6HnTDBHA722cgM5TQyYPxf6W6Sb5PHyfLVYvATaOIQsBpXSQadI1CFFOgk538ypLuGLhPDK0j2FWyu/I9K9ue4S5hOAmOXSXYqTR2TfGWn3sEPRITad0vk1quf37vl4uyKX+Z/v8c1u5rPpHBhtqCKD//SeZv6FgZX8MgLQ2mBrviAczfxbVu5rhPd531OvldxHH7KYqzIb7frtIyxeLHPUrYRg8w7O0K46rGcYYJ/NnH3iDHqQdq07qTodwmIcQ03c2NemLbPzgPBkOvcJNbjh7HQmEZQ2+97hhj100aIxAnAgV2bUPD+9nvKm4lazzD/tg26ayMhh5/fgPTSyD5J6liaffv5Zp0L8/4Lv/W1nHqN94 CHyzgRwT kzZWcM8w2W549KORPP4WEvAerRQtf48pXc2ZzRbHYQe/idi7i9oDLcrwU+sZ2mkaZLJ3CaWCPiegtlozfVXVerOQp2lMKYuMob/nPDducPYH0DvgQy9Y7VBaKxT+wqKuxztIRAmWHqVKWAzFR7r2c7K3CE9BxuIvU8snngIwe01Xmfttg1TZihZSajkcRUes/JY6tKImq9g+F9weoWQQTuEp4Wo3cXwg77chQy0cmlqy9SAw8r3Qo/++jWetYuLl3878Siy9DhCU7SKC7HJ4oYWa+GEAj5XqZjdkMwUPpF/ERmJDh6zSEkJsH5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand wrote: > At least reduces the occurrences of FOLL_PIN :) I don't see where the problem is in letting people supply FOLL_PIN or FOLL_GET. Why even have pin_user_pages() and get_user_pages() since they end up at the same place. They should be inline wrappers, if separate functions at all. David