From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DDCC433E0 for ; Tue, 2 Feb 2021 00:39:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF23364ED0 for ; Tue, 2 Feb 2021 00:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF23364ED0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D4886B0005; Mon, 1 Feb 2021 19:39:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55ECA6B0006; Mon, 1 Feb 2021 19:39:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 474616B006E; Mon, 1 Feb 2021 19:39:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 2E1116B0005 for ; Mon, 1 Feb 2021 19:39:33 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ED8428249980 for ; Tue, 2 Feb 2021 00:39:32 +0000 (UTC) X-FDA: 77771469384.15.play84_1d016c3275c6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id CD3E41814B0C1 for ; Tue, 2 Feb 2021 00:39:32 +0000 (UTC) X-HE-Tag: play84_1d016c3275c6 X-Filterd-Recvd-Size: 2482 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Feb 2021 00:39:30 +0000 (UTC) IronPort-SDR: oMZZ7UQdpQh8PPwY6ldI6DWwHzBrpxoz3o9creLTAc1NWCbi4z6AdA5WQy56YunsYAe08GXXHT SxW97MUJCeZQ== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="168455259" X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="168455259" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2021 16:39:28 -0800 IronPort-SDR: hF1RcR0g2YqnQc/kXdTtwjvLHy0Os+sVlwhWN82ZXYiR6/myuIBvKIqOPJ1qm1udb372V/Nk2e blUtrx4hsXXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,393,1602572400"; d="scan'208";a="370174219" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.28]) by fmsmga008.fm.intel.com with ESMTP; 01 Feb 2021 16:39:26 -0800 From: "Huang, Ying" To: Rikard Falkeborn Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/swap_state: Constify static struct attribute_group References: <20210201233254.91809-1-rikard.falkeborn@gmail.com> Date: Tue, 02 Feb 2021 08:39:25 +0800 In-Reply-To: <20210201233254.91809-1-rikard.falkeborn@gmail.com> (Rikard Falkeborn's message of "Tue, 2 Feb 2021 00:32:54 +0100") Message-ID: <8735yfl2v6.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Rikard Falkeborn writes: > The only usage of swap_attr_group is to pass its address to > sysfs_create_group() which takes a pointer to const attribute_group. > Make it const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn Looks good to me. Acked-by: "Huang, Ying" > --- > mm/swap_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index d0d417efeecc..3cdee7b11da9 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -901,7 +901,7 @@ static struct attribute *swap_attrs[] = { > NULL, > }; > > -static struct attribute_group swap_attr_group = { > +static const struct attribute_group swap_attr_group = { > .attrs = swap_attrs, > };