From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B31C43219 for ; Thu, 27 Jan 2022 09:44:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 083386B0071; Thu, 27 Jan 2022 04:44:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0336B6B0072; Thu, 27 Jan 2022 04:44:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E64226B0073; Thu, 27 Jan 2022 04:44:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id D2CB46B0071 for ; Thu, 27 Jan 2022 04:44:30 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 90C8D944D6 for ; Thu, 27 Jan 2022 09:44:30 +0000 (UTC) X-FDA: 79075581900.20.33CFA12 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf26.hostedemail.com (Postfix) with ESMTP id 964C514000C for ; Thu, 27 Jan 2022 09:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643276669; x=1674812669; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=dk0qamhX2TbtdZHxZwkI3zlHxXhVxx0UNGFBByp7cwQ=; b=R/5GN2lu8P1g5wwMtyHkyvoiQrkafeHqdplTUyc/4KdOYoLqi8VQ73yU nttdn+SSd0HzdgXv6AGrS0908a9ODdtPWdLkG5RrIAkTq25MsUZLShwsE KAXR2gKMpvdCdRugK3Lf0QQOvdIen+Uc8PYM/CEQTxxzutwjN9KQHBKbl C318OwVLujMONLsxWLDICWgcw+NQH6Oi0h78ONxdo/1nZRytymY9FK+Ai 4Zd8yJ+I6z2KoufQTF4MJCfM6lDC/f+YvvhaZbrU5sGstum6Zn31NvwVo KhXsbzXx7oeajSI7zt+LA8OHTrse79O209nMl4f300Uo2/oCSD2Hc/pYx g==; X-IronPort-AV: E=McAfee;i="6200,9189,10239"; a="246580155" X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="246580155" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 01:44:27 -0800 X-IronPort-AV: E=Sophos;i="5.88,320,1635231600"; d="scan'208";a="618268633" Received: from johnlyon-mobl.ger.corp.intel.com (HELO localhost) ([10.252.16.209]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2022 01:44:23 -0800 From: Jani Nikula To: Randy Dunlap , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h) In-Reply-To: <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220127050456.M1eh-ltbc%akpm@linux-foundation.org> <6b4f3d82-01e8-5bf3-927f-33ac62178fd5@infradead.org> Date: Thu, 27 Jan 2022 11:44:18 +0200 Message-ID: <8735l9y0lp.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 964C514000C X-Stat-Signature: gz3dmoaxub8bkm4ts4j5m79xam7qm8ts Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="R/5GN2lu"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf26.hostedemail.com: domain of jani.nikula@intel.com has no SPF policy when checking 134.134.136.24) smtp.mailfrom=jani.nikula@intel.com X-Rspam-User: nil X-HE-Tag: 1643276669-88488 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 26 Jan 2022, Randy Dunlap wrote: > On 1/26/22 21:04, akpm@linux-foundation.org wrote: >> The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to >>=20 >> https://www.ozlabs.org/~akpm/mmotm/ >>=20 >> mmotm-readme.txt says >>=20 >> README for mm-of-the-moment: >>=20 >> https://www.ozlabs.org/~akpm/mmotm/ >>=20 >> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >> more than once a week. >>=20 >> You will need quilt to apply these patches to the latest Linus release (= 5.x >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated = in >> https://ozlabs.org/~akpm/mmotm/series >>=20 >> The file broken-out.tar.gz contains two datestamp files: .DATE and >> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, >> followed by the base kernel version against which this patch series is to >> be applied. > > on x86_64: > (from linux-next.patch) > > > HDRTEST drivers/gpu/drm/i915/i915_gem_evict.h > In file included from :0:0: > ./../drivers/gpu/drm/i915/i915_gem_evict.h:15:15: error: =E2=80=98struct = i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible= outside of this definition or declaration [-Werror] > struct i915_gem_ww_ctx *ww, > ^~~~~~~~~~~~~~~ > ./../drivers/gpu/drm/i915/i915_gem_evict.h:21:14: error: =E2=80=98struct = i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible= outside of this definition or declaration [-Werror] > struct i915_gem_ww_ctx *ww, > ^~~~~~~~~~~~~~~ > ./../drivers/gpu/drm/i915/i915_gem_evict.h:25:16: error: =E2=80=98struct = i915_gem_ww_ctx=E2=80=99 declared inside parameter list will not be visible= outside of this definition or declaration [-Werror] > struct i915_gem_ww_ctx *ww); > ^~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors Thanks for the report. This is only visible with CONFIG_DRM_I915_WERROR=3Dy which depends on COMPILE_TEST=3Dn. We use the "HDRTEST" and -Werror for development and CI to keep the driver clean, but it's not really intended for general consumption. Usually when something like this even hits the tree it's because of a merge mishap somewhere down the line. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center