From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36F2C001E0 for ; Thu, 27 Jul 2023 11:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DB656B007E; Thu, 27 Jul 2023 07:18:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 565886B0080; Thu, 27 Jul 2023 07:18:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DF126B0081; Thu, 27 Jul 2023 07:18:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 302836B007E for ; Thu, 27 Jul 2023 07:18:26 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EFAAFC0FFE for ; Thu, 27 Jul 2023 11:18:25 +0000 (UTC) X-FDA: 81057143370.08.F30BD83 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 96A0EC000D for ; Thu, 27 Jul 2023 11:18:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QjPYxdAS; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690456703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J5aSglhBSh7Q6jT77+XYZea18X5UXNoMlG4BeMpxQmA=; b=WmQZXTNHDdB0+GMMAEES0o9Ue7xIZhZ9gqwLEOoHREz39s+6L0hIvyl+kBKCRzFWNqB4Ov T9fLsX9fuBVAv0YY1Tdjf7irganz4PGLoy4qQX3cdjT9HvY9P3uPjCBkd9RFfiEWiOElUi BVlFV+rGpFaXZRn9czLxrIDeq6Pvpkc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QjPYxdAS; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690456703; a=rsa-sha256; cv=none; b=smFgu+5t2/m38H1Jx7A/aBtfmkQ+wg9uzAnkVIpdjanStmWr9q4G3fIqs9lbSEtKwZi71j 7vs7ArVQXfRxU1D58VWgIY6QVP8IBn9ez7dVE5zY7cYVgkxZyJm6MTE9WGpziONswLGofG DJN+nAs+9ZXvq5oFVGh81MGb/tSW65g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690456702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J5aSglhBSh7Q6jT77+XYZea18X5UXNoMlG4BeMpxQmA=; b=QjPYxdASSY3AnlIYREXG9GIfDihG0T+4I07c8PvcsalfqE+tEyISmyu/gXnlf7MRoHZUfR uvyBJnzl5PLFuFV8A/znBgAsEqHybDOIKKnrNUk5ih7HB7CHzMFvp30MK7zUGIKqQzjHO8 E/REJWf/rOlHi1KZRasjMlizt0ARfSU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-aPZNqsjVOG6hCdwmi2rrDg-1; Thu, 27 Jul 2023 07:18:20 -0400 X-MC-Unique: aPZNqsjVOG6hCdwmi2rrDg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3fbe590234aso4425135e9.1 for ; Thu, 27 Jul 2023 04:18:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690456691; x=1691061491; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J5aSglhBSh7Q6jT77+XYZea18X5UXNoMlG4BeMpxQmA=; b=OB9z8oEhODvwcfH8SxkJPTtVLkHPzQ/40ZhMIcG79j3eAOnyoON7o8mDW7bVzLUuJ7 RLRfUoa7v0Znui/RyftNndw/loCiDRppewq/j7pxr/zw2jctuk3Krnmzyy4OG1M3dRp5 WPQHCYFZ5l5vlU7ujpP8ImFNsGja7HpA8K7slA//uCEjZ7NHAF2dl4gs0ZHSFNoFtW/o OVWSLnsNxvOT6rjpQY+QkXyTlBtAAYFf07uLH13CvOysCkUhsQBgLqJGQt59BYw8XzdI duFZkOoqyPRpDTlYdZg+Mdl+OK/e32SazuZh4qc5L3TFXIGQ4V2XNaXmiHM6tUPBoERx CzYA== X-Gm-Message-State: ABy/qLas2tkcnSiPJaHdsADVNt2wrCPxD9+Wx0GbbOik3y8Dpr8al/yW CkJ9ctOgBcBetNmC+PG+7kB2rSSEVpsKTXq7cHd75qMMoaP/wyx4dRLshm/aWY6Oc6IQgd+aaa1 tixu5AtEiGE0= X-Received: by 2002:a1c:e908:0:b0:3fc:5bcc:a91a with SMTP id q8-20020a1ce908000000b003fc5bcca91amr1662982wmc.6.1690456691333; Thu, 27 Jul 2023 04:18:11 -0700 (PDT) X-Google-Smtp-Source: APBJJlH0ZToprIgSDfwJmmp3kGZee2OelfjDJ8Mj+brRBQssO3Ov83L9J2RbIhEq7LfPgIeu9SrYDQ== X-Received: by 2002:a1c:e908:0:b0:3fc:5bcc:a91a with SMTP id q8-20020a1ce908000000b003fc5bcca91amr1662966wmc.6.1690456690984; Thu, 27 Jul 2023 04:18:10 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id l19-20020a1c7913000000b003fc07e17d4esm4384584wme.2.2023.07.27.04.18.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 04:18:10 -0700 (PDT) Message-ID: <8735f065-cdf7-6383-d9e3-98a022e6f0e2@redhat.com> Date: Thu, 27 Jul 2023 13:18:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: Oscar Salvador , Michal Hocko , Vishal Verma References: <20230727080232.667439-1-aneesh.kumar@linux.ibm.com> <20230727080232.667439-8-aneesh.kumar@linux.ibm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230727080232.667439-8-aneesh.kumar@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 96A0EC000D X-Rspam-User: X-Stat-Signature: 4whirwbt4517ubdg44mer68yrxhmrp8m X-Rspamd-Server: rspam01 X-HE-Tag: 1690456703-963743 X-HE-Meta: U2FsdGVkX1/z6RfOtdnYuKmjqm7gmZS8JYVGeKOqAgM6zBbibMRy7swhGFW0Q3OAqDNFd7gs2UOmd+jeJbereRSfUOzLZd+a2s7Ayy8nySFRlBoJzdOUKUtPv2MSLfb+ASyu0HAToDQwWYPfDebMGCToZ3ZnSZxfaCEoejQ4byLcLWXDtzHsBL87gSGV4kc57G1xjHQrUlpLxsP+V8j5d1dqa8L5JNYiNiRsGi4kI6k7wLzggFoDe9hgsy0ZKCVt9nAUPJ4Kyb3KQ1P4WGUiOXS/pmKnPXUy05h4tCN26jL0BdOdKbM/uFBMf/ghaB7TJz3+nN8ayj4d3GMQ7hIoLe4BP3zEmQNZWcw8Zm52FJHwzxdL+fGEpRErXwEHYMcLhYK0+4O5vhog0JtaSUfxj0gmaWKcTZgNdWbtSQLV9/cLBMgKrgtTvCalv4yZhTQ0yNqa3nh0Zwxz0v8+5R3a5g08tK11WvowjQ4uqmagyWrdlIrBi7lIo5stcG9VcIjSbXeSgYAlzHsagyl5JzilSg+98aNIjmF4kUpxKgDyV6GXlZB2JG8LPwY3J71PeJqgvwIIkZ7oJaEeN37W8wDAzivTym2c8FqxWoM0OhngPxRYV3RKgPihfCneIh+XMSvIZ5f2Lrch+TP6b++6Pfm1l+S94EteBOhjD71Obd97y0Fpukm88Op/NhoB3pyvcUXRtbL+rCCpbqMQmyQHGg7yjEz/V+jbl+Y/lTBXJUrB6M9gUau8ovGUvHGSxU6lEgqibI+9o7s3nbaQNIzZCZBWZvqqS1JUjnTGKUmUw09JBJ6NwQ3STRS9FuuTKSLMGPiYjBR82U6iAbAFT5lqk/lsnfi+VTthF3s0YfAF6ZX5bp4iRrGvZxZpihdAx+66tS6yHk+pw8kZzul5jpFeeKvEVbY+OiFxvaI+HcmiC29SAjmyR8yQkyCNNCCZNMIgCN9ZfhsNWTCqC4iq5aKF9nU pPln3UXW LcwM/cwX9MS5iRbKG/e1fD9IupOSvlZCkoQL5ekTB7ttb8WEBoys5FBGpFCoCRdBpkGnNVXVI6aSGsSLcuGhjmxCMgGxsAwtayD1Zqb3k+N5cgv9hOPllYESzuQ9s0uNC9O3CYqPnINeL7xy4yWshnJ5KcuuoflM85JUHmuCqOy8an3kiorhmsMD1NI3yMjwqJdbopg0ufpAJgdtnmiN8wRpqSqaUvOWtAg1BQeNvsfhn73ofL02sAKM6Ad12zYHn8kuep6x2HSDfj4s8O/ky200rWe/oKT/fUymICNtAOW0uHRt1mVPNbY9cD62O3NPrf7tdRfmKniMl7rYN82at/vwbUtPRpbEGKB6M5FpMu8m9LxDdHRWlZM2yo2LzjCudaiWjTrqyf8h7iyRvPpE3j24paKR9iTRXnT1GKGCcnz5AOcBHRb+BYQmP/VEfLlCdTn6TEq/BCDEqATaq82ovdks45wWw0jvkvvr77TnRX7J3HK5FQutf+PmR3QDeGP5i3z6HcdCs+yCqh5yx/QNY6u9d6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.07.23 10:02, Aneesh Kumar K.V wrote: > Acked-by: David Hildenbrand > Signed-off-by: Aneesh Kumar K.V > --- > mm/memory_hotplug.c | 35 +++++++++++++++++++---------------- > 1 file changed, 19 insertions(+), 16 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index aa8724bd1d53..7c877756b363 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -89,7 +89,12 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp) > else > mode = MEMMAP_ON_MEMORY_DISABLE; > } > + /* > + * Avoid changing memmap mode during hotplug. > + */ Nit: comment fits into a single line. -- Cheers, David / dhildenb