From: David Hildenbrand <david@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org,
mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu
Cc: Oscar Salvador <osalvador@suse.de>,
Michal Hocko <mhocko@suse.com>,
Vishal Verma <vishal.l.verma@intel.com>
Subject: Re: [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter
Date: Thu, 27 Jul 2023 13:18:09 +0200 [thread overview]
Message-ID: <8735f065-cdf7-6383-d9e3-98a022e6f0e2@redhat.com> (raw)
In-Reply-To: <20230727080232.667439-8-aneesh.kumar@linux.ibm.com>
On 27.07.23 10:02, Aneesh Kumar K.V wrote:
> Acked-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> mm/memory_hotplug.c | 35 +++++++++++++++++++----------------
> 1 file changed, 19 insertions(+), 16 deletions(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index aa8724bd1d53..7c877756b363 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -89,7 +89,12 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp)
> else
> mode = MEMMAP_ON_MEMORY_DISABLE;
> }
> + /*
> + * Avoid changing memmap mode during hotplug.
> + */
Nit: comment fits into a single line.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-07-27 11:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:02 [PATCH v6 0/7] Add support for memmap on memory feature on ppc64 Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 4/7] mm/memory_hotplug: Support memmap_on_memory when memmap is not aligned to pageblocks Aneesh Kumar K.V
2023-07-27 9:23 ` Michal Hocko
2023-07-27 9:27 ` Aneesh Kumar K V
2023-07-27 10:55 ` Michal Hocko
2023-07-27 8:02 ` [PATCH v6 5/7] powerpc/book3s64/memhotplug: Enable memmap on memory for radix Aneesh Kumar K.V
2023-07-27 8:02 ` [PATCH v6 6/7] mm/memory_hotplug: Embed vmem_altmap details in memory block Aneesh Kumar K.V
2023-07-27 9:25 ` Michal Hocko
2023-07-27 9:32 ` Aneesh Kumar K V
2023-07-27 10:56 ` Michal Hocko
2023-07-27 11:17 ` David Hildenbrand
[not found] ` <20230727080232.667439-8-aneesh.kumar@linux.ibm.com>
2023-07-27 9:26 ` [PATCH v6 7/7] mm/memory_hotplug: Enable runtime update of memmap_on_memory parameter Michal Hocko
2023-07-27 11:18 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735f065-cdf7-6383-d9e3-98a022e6f0e2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=osalvador@suse.de \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox