From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF62C433FE for ; Wed, 2 Nov 2022 02:11:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7C46B0071; Tue, 1 Nov 2022 22:11:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D58376B0072; Tue, 1 Nov 2022 22:11:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1FDC6B0073; Tue, 1 Nov 2022 22:11:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AC0FC6B0071 for ; Tue, 1 Nov 2022 22:11:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 801BC40CA8 for ; Wed, 2 Nov 2022 02:11:20 +0000 (UTC) X-FDA: 80086875120.07.3A97252 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf03.hostedemail.com (Postfix) with ESMTP id E878E20002 for ; Wed, 2 Nov 2022 02:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667355079; x=1698891079; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=O6XTGElfGoUAX2ClG0cppHS3e2wQBWvL3CUDavNdeKk=; b=cXo/G1aCZBAFvOwRgc8S6LECggPWJG6m/J8zqf3Yg9Nvni9LxLSQNZjp F40AkNrIJ9/aRYSPzuZkrIcLwW8W8txt1rGtL357IGlun6aXo9siPD4e9 HKokZ1JiuuwSyhUBtaEDMQi//3v9Ep5aHkR6Jehzr97T1GCcjrWICyLMG UD5zIBzJGWjJo16bmm25jCF7yBGDsqAF2TcV7Rtxn8JtYwa74iOcA3PzF IVU1cUY7xOxDvdSvkAi6xXH2FnUHdUzzsAaqgFHe5Yzwbnr7YvhbKKI/h DgAD3gpMwDMYTdOh/QphyUkJr9FFzwoGZ6K+CubXIzX0C2IHKDzSMOs/g Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="309289266" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="309289266" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 19:11:18 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10518"; a="776716072" X-IronPort-AV: E=Sophos;i="5.95,232,1661842800"; d="scan'208";a="776716072" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2022 19:11:16 -0700 From: "Huang, Ying" To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador Subject: Re: [RFC 2/2] migrate: convert migrate_pages() to use folios References: <20221101062137.83649-1-ying.huang@intel.com> <20221101062137.83649-3-ying.huang@intel.com> Date: Wed, 02 Nov 2022 10:10:37 +0800 In-Reply-To: (Matthew Wilcox's message of "Tue, 1 Nov 2022 13:02:47 +0000") Message-ID: <8735b2cdia.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667355080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M/9RCG/J42V1/4jKPTejsspz8YCpOwYaDARQnNBN0B4=; b=yBZEyVMPzutoOcmnaHfhfwjUErKnLyzRHmZ/916IavVqURn/bJuLu/T5XuBhkwSU/3zHe9 iVPemSiW5Sqa5PytW4IsMC7B8XgvfNEbWtW1pUVceU4G///zdshyH+zXeG54XSN2rsIUKE 5Y891afN99isfGFhxwBmSUQxxdqyb30= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="cXo/G1aC"; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667355080; a=rsa-sha256; cv=none; b=x21bGeFu7xHZPs36M7lqW6+6xdgaWV47lB6ttQ0npvH/9iqboLffw4sNYmI+QMJ0MSY0Zt uSsGH0BZaQwrNGk/8Hx9cz+BaICo0q1egDLSS4qLIqXOekjr+1yQD1jHegXNo8ogr67T+h OAP286N4jt1WF0HGkakyjTaIRJiidNw= X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E878E20002 Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="cXo/G1aC"; spf=pass (imf03.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: xo3rftqwegc3g8oktjfz6foywxi86ipw X-HE-Tag: 1667355079-751659 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > On Tue, Nov 01, 2022 at 02:21:37PM +0800, Huang Ying wrote: >> - is_thp = PageTransHuge(page) && !PageHuge(page); >> - nr_subpages = compound_nr(page); >> + is_large = folio_test_large(folio) && !PageHuge(&folio->page); > > We have folio_test_hugetlb() to replace PageHuge(). Thanks! Will change this in the next version. >> count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded); >> count_vm_events(PGMIGRATE_FAIL, nr_failed_pages); >> - count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded); >> - count_vm_events(THP_MIGRATION_FAIL, nr_thp_failed); >> - count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split); >> - trace_mm_migrate_pages(nr_succeeded, nr_failed_pages, nr_thp_succeeded, >> - nr_thp_failed, nr_thp_split, mode, reason); >> + count_vm_events(THP_MIGRATION_SUCCESS, nr_large_succeeded); >> + count_vm_events(THP_MIGRATION_FAIL, nr_large_failed); >> + count_vm_events(THP_MIGRATION_SPLIT, nr_split); >> + trace_mm_migrate_pages(nr_succeeded, nr_failed_pages, nr_large_succeeded, >> + nr_large_failed, nr_split, mode, reason); > > I think this is the biggest question with this patch -- how (or whether) > to account folios in size between PMD and PTE size. Since it's > _called_ THP, I've tended to make the statistics conditional on > folio_test_pmd_mappable() rather than simply being folio_test_large(). Yes. This is my biggest concern during development too. In the next version, I will distinguish THP and other large folios (between PMD and PTE size) and do statistics accordingly. Best Regards, Huang, Ying