From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FC5C04A94 for ; Fri, 11 Aug 2023 18:53:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17B326B0074; Fri, 11 Aug 2023 14:53:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12B9C6B0078; Fri, 11 Aug 2023 14:53:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F34E36B007B; Fri, 11 Aug 2023 14:53:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E37A86B0074 for ; Fri, 11 Aug 2023 14:53:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A606C120384 for ; Fri, 11 Aug 2023 18:53:08 +0000 (UTC) X-FDA: 81112721256.13.9E6342D Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf22.hostedemail.com (Postfix) with ESMTP id BE516C001E for ; Fri, 11 Aug 2023 18:53:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Ihet3TrN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691779986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iq7IkMdomNkVX+bFratX6hcLAj5djkYRdrzjeoPtFbI=; b=LTx8fOegLzFWa6RseMXO73E8wMCmgcLayqbdjzEzjrpInOJKcSYqxFqLtv8D4odMTxvxc8 YCTkahDnqhtlYmQk4RBytzjXF1rkoocq0s0DwfN/aGXvvezbxAKbSOxUm9jw+6CXfRqLHS k0gwNuj3KY6Z/I9n1rLIGSi58y+X1CQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=Ihet3TrN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691779986; a=rsa-sha256; cv=none; b=8ZkGlvU4ZKAANXNPovrMUaN2vnkMWcYbFIh0sPpINVOpNrPZrOfpLFDsgRYRL+tz//rmtV M7A9973m5KBDTWnSxAuFt+EL7t4c9njFvJVx1AMekWTN6fx1+wvAb9vIkpNQJyvHN34a/U BnzIy6rQtQ3ls1NTP/m9k2e88hBK4yY= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1bbc64f9a91so20105125ad.0 for ; Fri, 11 Aug 2023 11:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691779985; x=1692384785; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iq7IkMdomNkVX+bFratX6hcLAj5djkYRdrzjeoPtFbI=; b=Ihet3TrNif0RmbgdM8gWevvHC9yikNrioZXXLJV3ixnQelDaxebnNb1rfNrqsW/b7U JrjfRWZFfN6rXAkqxzzwevbQVcuBEiwLYOrtUeQOVtmtESQBgSDJVejCCXm3cpm5XL2O vQ+G7IsbPVBTnp0PuY+ic3b9YgfHTG2Z28fhDGkP3IL+zQREeQgw24XGaI0JAF++0X03 UkCGDKFDD9AJ/42nMYslsi35ReyFQjoErEgzgns6i+1NEZJ7U50/K7g0Ew/GOfeQoE9+ GNmacyZtLT6CQVrfZh6VsKG9NJhWW37+6OfjfcgsDufn1QxTQn8kav0471TlL40YqFO9 bnuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691779985; x=1692384785; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iq7IkMdomNkVX+bFratX6hcLAj5djkYRdrzjeoPtFbI=; b=Rhza8SHoJy6NlbZW67nyHqnPQ/e1Jw8VO5m5QfVVDS/hbWMVB3fMVkL3uDie3azt9v RgmV4XzgmsSWUH1CuM7raZXAAG9VYnHfQXimaVj6IDXSdtxZJbPWzfGqszkDbcX0bdih L9oS0zG9EuU2xq0C813F0twADvnPuuiNFk3iR3yvT7Eq4kn6Tq52Eg6Zx0/Db69U9rEp 2CVyTuH47U5IUzplAwWEl5OFfjZG77hWJq80VkbvewDgcpdbAWfVzAq/3KmoTwBIzz8k gWc/X2G8D8Iy1esWSXnb5fu2rvbqjFmHCuVtiHWQYEzc1F17N6Ciy0L9cD5ptfqYTr4s xCvA== X-Gm-Message-State: AOJu0YxASpT2T5obeCLUQusofei2Ne+JdmZQk4TBWaE4SMUXHTGl+L3C UKbWf6KNnnrDbEWA4jWeaOg= X-Google-Smtp-Source: AGHT+IGD2JfF0poGxlOFzidHA6O7E/DuwnYdU2IoyyGktUcN0W8zA/mR9nCisUrzfWGaCZj3W8iO1Q== X-Received: by 2002:a17:902:6bc9:b0:1b0:6e16:b92c with SMTP id m9-20020a1709026bc900b001b06e16b92cmr2609020plt.54.1691779985300; Fri, 11 Aug 2023 11:53:05 -0700 (PDT) Received: from smtpclient.apple ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b001b03842ab78sm4287554plg.89.2023.08.11.11.53.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Aug 2023 11:53:04 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: [RFC PATCH v2 4/5] mm/autonuma: call .numa_protect() when page is protected for NUMA migrate From: Nadav Amit In-Reply-To: <20230810090048.26184-1-yan.y.zhao@intel.com> Date: Fri, 11 Aug 2023 11:52:53 -0700 Cc: linux-mm , Linux Kernel Mailing List , kvm@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Mike Kravetz , apopple@nvidia.com, Jason Gunthorpe , Mike Rapoport , Andrew Morton , kevin.tian@intel.com, david@redhat.com Content-Transfer-Encoding: quoted-printable Message-Id: <8735E3A2-795B-4D52-9634-D48C68645A5D@gmail.com> References: <20230810085636.25914-1-yan.y.zhao@intel.com> <20230810090048.26184-1-yan.y.zhao@intel.com> To: Yan Zhao X-Mailer: Apple Mail (2.3731.700.6) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BE516C001E X-Stat-Signature: cx4dwq5tpp5d49ynhfq3wae41axteuto X-Rspam-User: X-HE-Tag: 1691779986-442691 X-HE-Meta: U2FsdGVkX1+E/lTBMTfS/TYv/qpJWBFmR1gloHo4+J3nBNO0vnJV0piHjhXl2ro1ygXuqNa+FmQrUhktdfS40XHLIyw92vCcKz2jV7h7vZNmzCdBSdwzwfxVb5Zmpvo/BzKhK2ekzAurMmEF9QF5GZZsVJoqADgpyn4Lsq9K1n0BXatkfKGCnMSuvQF00kDWPPMVX6ekiHgAC8nL9lOMTV6w3Zy13G0UVXAE6EQ5XfzpLhEK7rxNrk3EfdOxMbL0AwI92FtawpErQp1A3KBuU5AVOFvyMS6E/xTE9J3Bjc0P4OV51VxUxUSQFe+J95n+mDGhsTO4N/6NJYm+0vXxOWxN1W6JOg2gJrvT+wL8e+WuYx5zzn2+6X4GeOWbQwM+2IYpz7OMIW9WSNu5V60lP4BsGVISEYV6l0DFnppbwnC20vzUqKs+Zl9QTqg7KclV9AQBuVMLa7dpLlEhOG66nuW2nwlplHJ+O/sibJ/FmE3YGX59HfjKVkJmpbvzeb35VqpPB8ifRn7KBvyW2cKjor2nxBj4viiQB2HpL76pKKrnvtOu6Pt8eoGyTwY8tdCS95xrGzdIvndejNw+XM8zO+0V9dB9MZtB/xcaFTH4qdug/iYztKxQKX/MltM2EdOA/5qbqkntTEYnwBxh5GNPie/mW2ihzqgX5pZDtV4oLTZuWZ/eNzVS1uyiF0XCuJ9sPh0e4IsU+9NmULq396ks2O3I+hkY43cstvHBTr5uVuUZHcod4VARppZ+bQk68+vs+vKOK2G2uXSYs57wZeiBxRW7V+Ru9X+dhicnXHxQdjOmbRUTI/Arc6VkBECnVmgpD2FMhHa7DM4T0bWNWz9dyiL5izkY90qTKv0vuG3oBFHQJSCawC6xyKVnTQvRPGzzmt2ICvotQQTNuKyEuBNe+JYWWK/0Er+83hQUS3qBeX4r9xHTbXOA57rNQoGtP/qs1M2n8o9pPr23gJhng3t EiMrpIsn u9LYtsQQrUVSy72SodRhlmtSh7ZKynDMFN5HnAyK/jw59EoRWdirVAze0h0eaSqtP3sWmqvb4M3oHT+VFW8CENbLQ49tP5beVrXOML721nXiy2wbtDkoFNIE5tTwpz77hhqvS56MwPBAnSELxHEWCHfbdcyH3V+YGFR/ResjqC0a6gTC/0lfbZFke13eETrT86W2YnEqgfGAGKVeCQPXCQ1c1dmZIvyKGW19b6X+62aYtZHDuWYm9JnfbPFyBk6zi7wNNGuFeZRmJEml6HO8rUb+GLfuhtYvWSJ8Fskuf2uwEw81c2ZZF9mlYZSSKi52TkuHPnehtGFlMS4zb9ylxkSr3B6KbFXBVI0/4IiF7J6dtZlVPzG+MsfKOqW0REDnQ0RtGL/pqeKg4qjjLtHPLET/s6RqqJ9c2tVFju9HOIM17XckwPWPfx3AYPOVj9GhaZN5lhifA+y6hJ5NEZ6Ay/9oZ/vbHzcJTjLNJj6buSy9DBkQmkGDKOXFu/I5cYQf7Z1b/mDxm8yqmHnEsI//SFt3VeKUo2wWIJ8mDp8PmwUJPLzFQPZVwJ/q8gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 10, 2023, at 2:00 AM, Yan Zhao wrote: >=20 > Call mmu notifier's callback .numa_protect() in change_pmd_range() = when > a page is ensured to be protected by PROT_NONE for NUMA migration = purpose. Consider squashing with the previous patch. It=E2=80=99s better to see = the user (caller) with the new functionality. It would be useful to describe what the expected course of action that numa_protect callback should take.