From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09F0C38147 for ; Wed, 18 Jan 2023 12:56:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE806B0071; Wed, 18 Jan 2023 07:56:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18EB76B0072; Wed, 18 Jan 2023 07:56:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056AE6B007D; Wed, 18 Jan 2023 07:56:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EA00B6B0071 for ; Wed, 18 Jan 2023 07:55:59 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9B895A09F6 for ; Wed, 18 Jan 2023 12:55:59 +0000 (UTC) X-FDA: 80367917238.19.068C5AF Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf02.hostedemail.com (Postfix) with ESMTP id D9FD48000A for ; Wed, 18 Jan 2023 12:55:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ageL71IC; dkim=pass header.d=linutronix.de header.s=2020e header.b=BRCPqEs3; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674046550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AB+InJFKr3A1hH76vbzTChAWIkJom+fRvriRNNNTKpo=; b=10KUhnpyIpTZCvYxbEgDY8bao3Sn4eDAeAVNE5I1LoiAefiCmcXVOcErWwg6xQ7BCCTfIz phZqQwMX6bXbCelBOUAS5WaWmK+HsQWpFCyneAPtG2UMPg0DQPHz11zvWRux4PvwTINqxj HmDhnHZX66QoN/+IfXE5X/e8ZRJVpak= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=ageL71IC; dkim=pass header.d=linutronix.de header.s=2020e header.b=BRCPqEs3; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674046550; a=rsa-sha256; cv=none; b=QY4yAcV4/4SYtDBhiT8yjLJSrn+f22z9+J2n0aIBAx4qJgOPV51h07ndiYXK9QihEbeRQO pstUQ/VkKXW1wopj/sRjJ6juK7lafBMiJlCR64LOHduF5ECeYMSUHPMGn/pTNuDgU7M3CA Prjr7ZvhJPNMA7jAGZT4xdbJ6KhRo7I= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1674046535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AB+InJFKr3A1hH76vbzTChAWIkJom+fRvriRNNNTKpo=; b=ageL71ICTbkCOZ+nxBWyWkzol2RTpEDfAtuxHDdk+oA0FdqjcjKXSUkF9inonv4ABtk15r oK8DBFK58aaT5/QzdDugGKSJzh81kHFqnR2EfMHG5j0+tsDI7mxPeOje1FLE88KjgMHuxW p9VC5bB01OSk0VGh3OhxAGVEG4W5Emfq3pbOOqRqbbGx+opCyRLc30Uq39GtLuYv7BGepM Nu0iSXPbwX5LudmSv5tlt1RWjOHLvM7m1i4n2NfF0/ovbFR/RpcvK1VAoEYKFcBkrzNrLa kxIN7zJOzgQryGkh9TI0SeFPbreQcetsJBkf8nWsJ6ViHrKp5s0Fb4IHVx8jGQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1674046535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AB+InJFKr3A1hH76vbzTChAWIkJom+fRvriRNNNTKpo=; b=BRCPqEs33kUEXskwliUVCvnmh8wCJdDfDjrmbTNuzayEWcjpccjqIWU1fLzS/xuCffBT88 uSrX6hUeLwzgQ6Dg== To: Boqun Feng , Linus Torvalds Cc: Byungchul Park , linux-kernel@vger.kernel.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, paolo.valente@linaro.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, Waiman Long Subject: Re: [PATCH RFC v7 00/23] DEPT(Dependency Tracker) In-Reply-To: References: <1673235231-30302-1-git-send-email-byungchul.park@lge.com> Date: Wed, 18 Jan 2023 13:55:34 +0100 Message-ID: <873588j92x.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D9FD48000A X-Stat-Signature: wfoasfuab6brc88u7f4jyrqu9css8z6f X-HE-Tag: 1674046549-595837 X-HE-Meta: U2FsdGVkX19bgOFnTBt9oSbpMPFWCOxiDS3q+3vfCTIFUhQwWp9eWfS6wk45baYIzBp21Tth29EywQkwvJHYrfx+RPgZ78hPoJ5k3NC65EiAdFFTWP/2IJt71BKBQiILnohrXLbXfmihU4PrcczQBPLfUCYblhj29kFV8jgHtLnfqh00BFyC9TCRsce72znOcxkGXIC3ilKRh+eWsjafy7AsJ2wsioDDaMZkgqtZYXC/JPTcV2daLDJPssdYY1h6Vw6Td/WtLH4qLHlZeJey+1SFaUNt6X8kzBQZQBYqRSVvCwBCUumTUpAGNKRCFkUz+r7UySinFKDN43JYLHkT1nPKVkYZ9+SvSpOIgNUqiYfQRb6NISnctbtTYfLz22U1lwwVvBfLGrHdEihUK73mUM0Y9kAOFloj6v3PCEHij93OmcuV7OyvfPANJZrzFpiemZqH1z04gdCM8vy2WjWjDBvfrWhemxNedLEqOSts5uoVv0ufYVnKEhTpZoi9mf7mj+5vnsCfaF7sQ5E/OZ/MYDrt7ZqAweG9a6MzkR/RvlA+0ZDbKIwIeSSUcLyiUZN0Mx0vURzmp4k0/o/RgkcQvEMySP2BeQDeGkYsrMG/s4IOd3YhpdEB/xvElVpBry3l6HBGhJ9jBnRNXxpykY/bY1CXwu21t3lqCwCkEYkcSzi2X8+hxOPFabWk180E6KBrut7ve3JJVd9XHkwjpoEMwa7Lxjm7+cEp/r7km9Q3VRuJdijQZQq6eIrQw2nXg5neKTYOcLUXw9zJGXHiKYN/oHsTmTv66Tcj5hZ5mGyhlYNJSkf0fe+Jd6KVbbcJfk9qUDnvS5TxXVfhZ59ToxQLdGz+5zbfD+xl7PxfZEJbI1cccAnbcIpoW/ykaM9Uou5l4ZyV0QPJoai+ifogek7h8DBRNlUT7O6u1E1RtzZciaRAeq6E3fFykRcn5W3hCAwmrsdzi+wyoLdyEUBQiSC RfkHZ9ep /16DruyPDEJup/baUkFvARs1zUi6nl383X+ksI64I+bI3kUrNLX4ZVzWOHhh1oSFd4fPyTl989x0Pm6tKqILuza1d0MkYHfJzOA4D9JKEEz2X16qYhVFH40JQ3fbWNwJXN+yEyY5aKgHuxA0UcsHiP24KzEjHmXJIB4rg2qAvVvdtVOztn/+5zd2ymQIA5ZI85kSzChoeGDwQhjQ8D54A337DW16ZmQl8qjkNdkpW95IJ6io= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17 2023 at 10:18, Boqun Feng wrote: > On Mon, Jan 16, 2023 at 10:00:52AM -0800, Linus Torvalds wrote: >> I also recall this giving a fair amount of false positives, are they all fixed? > > From the following part in the cover letter, I guess the answer is no? > ... > 6. Multiple reports are allowed. > 7. Deduplication control on multiple reports. > 8. Withstand false positives thanks to 6. > ... > > seems to me that the logic is since DEPT allows multiple reports so that > false positives are fitlerable by users? I really do not know what's so valuable about multiple reports. They produce a flood of information which needs to be filtered, while a single report ensures that the first detected issue is dumped, which increases the probability that it can be recorded and acted upon. Filtering out false positives is just the wrong approach. Decoding dependency issues from any tracker is complex enough given the nature of the problem, so adding the burden of filtering out issues from a stream of dumps is not helpful at all. It's just a marketing gag. > * Instead of introducing a brand new detector/dependency tracker, > could we first improve the lockdep's dependency tracker? I think > Byungchul also agrees that DEPT and lockdep should share the > same dependency tracker and the benefit of improving the > existing one is that we can always use the self test to catch > any regression. Thoughts? Ack. If the internal implementation of lockdep has shortcomings, then we can expand and/or replace it instead of having yet another infrastructure which is not even remotely as mature. Thanks, tglx