From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DBAEB64D9 for ; Mon, 3 Jul 2023 02:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 627886B00F3; Sun, 2 Jul 2023 22:30:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D75A6B00F4; Sun, 2 Jul 2023 22:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49F328E007C; Sun, 2 Jul 2023 22:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 381B26B00F3 for ; Sun, 2 Jul 2023 22:30:04 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0BBFC03A5 for ; Mon, 3 Jul 2023 02:30:03 +0000 (UTC) X-FDA: 80968720686.13.CD4A2C0 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf15.hostedemail.com (Postfix) with ESMTP id B5ABEA0007 for ; Mon, 3 Jul 2023 02:30:00 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gF96QMCM; spf=pass (imf15.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688351401; a=rsa-sha256; cv=none; b=eArYfU9PyFXO72OWFpMkeA7Or86/toVGBtF3EEbXy5sJMOuKkglUmTicK1y9zBCfrxuWYI 1Fulm25zy7IkgRGpIgm0U2JARTIkM6HVzKcIpnniNldsczTLDgGFTGkgNEMnbTFPozysGL 9fAqfbtSlg1XtSYAlqnoACsXe7GyMic= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gF96QMCM; spf=pass (imf15.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688351401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f9p4gU/iYMeooKUOEUxvXJP8UHvgr+fk4KlA08D+1Co=; b=05zWDNjLQY3e6IgR6EMgZICwD4unlysymIlMNF/Mn8jr7QZe1LiP+s5u4lAH0fm/yamoBh YMwSEa/5Nqrf5aL/U5hXXNHMg38SmG+HJGitmM6ieppxLxObGoIZ/g7WmC9XGMS/9fQENd CV8P5uFj/GwPQwvV19Mlzmqqjmzvwjw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688351400; x=1719887400; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=7Rqaouxd++5ZQK+rGNqNdncW9yRBw9BvAFd8Qu0PGLc=; b=gF96QMCM03JCiZ3EcoFl0PS6ETVecWEQxEjcmM8u/lKUB+zFfnGWVwAW 3a5UsWiIE/TTaYchE7KfoLW9ZnLTUsPDobkR1qh01NOcF8X/zxJubANG2 MU3T/QAXJw8IbHSySI67Y1BuSf891G1MHO0n3zpgZ/hQgiWoUhxK3rbaP qgTIMimA447BrwFR/IqQstVGqLAG946mboeEp08lVT7aWgEnJTUmBu1xF h7I8nLdqdG6TqeQDtayBKUeokHEdk7FFzhSpjuQuYhrLEOrCyvWU3Oi5L 31wM0y6QhOi2FEPbAK4ObXAqOGAtFoaQCETIzRpTpk3Sd8cSyf1Wq5a0I Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="361630739" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="361630739" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 19:29:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="842497210" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="842497210" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2023 19:29:56 -0700 From: "Huang, Ying" To: Miaohe Lin Cc: , , , Aneesh Kumar K.V Subject: Re: [PATCH] memory tier: Use helper function destroy_memory_type() References: <20230626121053.1916447-1-linmiaohe@huawei.com> Date: Mon, 03 Jul 2023 10:28:14 +0800 In-Reply-To: <20230626121053.1916447-1-linmiaohe@huawei.com> (Miaohe Lin's message of "Mon, 26 Jun 2023 20:10:53 +0800") Message-ID: <873525k9tt.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B5ABEA0007 X-Stat-Signature: 9dtp78tj5tbyd357kikjq8qg554oh89e X-Rspam-User: X-HE-Tag: 1688351400-581701 X-HE-Meta: U2FsdGVkX18WnKJFRPmSadB3qBM0X4fS4YZu9FnfyqPTlJEbTv8swTfExv9N2ihCGnVWoN0OUkqbtxNQBdEpqkpxNkYjlauORGjEF8VSc7OQyS9BRGPrg+9agsEjf1XVLZEOb7ZTOv1apZxy8Uc80pN7IeOcuhbeBjoJm8Kpiy56JA+Ch2OVjTFUvfEQ04qtfigR2A/KA8dTdfdDztR2W4BkMvwFGKnf/fuOKwmpwoG1GQQVfmOMnm0H10QwzEZwMeQPujRVwcc1WT46MKHZbo53ZynvW6cDlVU9Clmcg+03PG4HAIG7WX64FPoroAZsSSaUZ1hu0u9Zua9cZtdnjUeppWfHrIwo/xn+elro/IRdKghJHdIYhqpbHXWRzC2NGI4wim1yvUED3uXAKS+BAZ9KpeSWyPOpdJ5gWUnxPHrbwALBNQoaG/Owb1fWTaTYXpwpgAklfTkbqOIqOWtmap+or634cgeDtY+uQsGj4nFmoS3MkISm4QTC385jg4fdX1RMJCrndH6ry/vb6AITsjCJkhEgjIsZyRPreBSehBCGH2w5R2nHCTU2Uy+lq4X3BrRb3khz0eESxKd3RrTGUmQn8oaua0NpeiCGA4kdPqswGa/FvuTe1tMlhFW1lW3dbMB+QiV6zuLQ8yjXDZpogiQjSEdPU+g8uDmZ+rQ80eO1wdNMXPDp2U3WWTu4eVey0oKVTIMoZmC7A8hcGWC0b0O7ZZi3KBqTHNsDN1UxatFBNI5eH8VaHB6epYV8l2VgPN6touYoF6h/Aqvw45gCZO5cx0QSJTBFoneo2cwrjhxb+gjdb80xP0vON7hATHdcmIt9jFrS7KN3cpRZQshQzTCHbhSmP+QE7/6DiNnXLab3lyamFz76gIvu9tLDo2Bk3HD1TfWJAPdqArAbhagRBGzfVZVtOD40TfzCJePiGMvEUumUkoT7ToEzzEYSeE8vd7hJSNMi2WAJMlWhgvV Zcg+U/DI WsVzg08GWNGXOhQOpVeHWbVR6O7TUGGFuEL1cNbaCeahilaZWodreTwTXLp4GZWUD4aRL/EtNCVCi3ryxmH/UzecwZIXQJwrcVZPDiw/M/AZbeZAzp28pe/rC0oG/qEZjhuIRPEnOjYk7Cz5aphdiYt7rAp9o+RvDtb4W7lYNUX2WyxLwtQTDO3NnX5yRs5pqHqP/iVUe5Afn7Tj/QZuyoWKycw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > Use helper function destroy_memory_type() to release memtype instead > of open code it to help improve code readability a bit. No functional > change intended. > > Signed-off-by: Miaohe Lin > --- > mm/memory-tiers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index e593e56e530b..0b8b76078c12 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) > */ > if (!node_memory_types[node].map_count) { > node_memory_types[node].memtype = NULL; > - kref_put(&memtype->kref, release_memtype); > + destroy_memory_type(memtype); Not need to be changed in this patch. It appears that destroy_memory_type() isn't a very good name, because we usually will not free the memory_type here. Rename it to "put_memory_type()"? Best Regards, Huang, Ying > } > mutex_unlock(&memory_tier_lock); > }