Re: [PATCH v10 1/8] treewide: provide a generic clear_user_page() variant

[Ankur Arora <ankur.a.arora@oracle.com>]

David Hildenbrand (Red Hat) <david@kernel.org> writes:

> On 12/15/25 21:49, Ankur Arora wrote:
>> From: David Hildenbrand <david@redhat.com>
>> Let's drop all variants that effectively map to clear_page() and
>> provide it in a generic variant instead.
>> We'll use the macro clear_user_page to indicate whether an architecture
>> provides it's own variant. Maybe at some point these should be CONFIG_
>> options.
>
> Can we drop the second sentence?

Ack.

>> Also, clear_user_page() is only called from the generic variant of
>> clear_user_highpage(), so define it only if the architecture does
>> not provide a clear_user_highpage(). And, for simplicity define it
>> in linux/highmem.h.
>> Note that for parisc, clear_page() and clear_user_page() map to
>> clear_page_asm(), so we can just get rid of the custom clear_user_page()
>> implementation. There is a clear_user_page_asm() function on parisc,
>> that seems to be unused. Not sure what's up with that.
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>
> You should likely now add
>
> Co-developed-by: Ankur Arora <ankur.a.arora@oracle.com>
>
> above your SB :)

:).

>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>
> Skimmed over it and nothing jumped at me.

Great!

--
ankur