From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6C15CAC597 for ; Mon, 15 Sep 2025 12:44:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 197A28E0003; Mon, 15 Sep 2025 08:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 148308E0001; Mon, 15 Sep 2025 08:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00FBD8E0003; Mon, 15 Sep 2025 08:44:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DFBED8E0001 for ; Mon, 15 Sep 2025 08:44:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 817BC1DE87C for ; Mon, 15 Sep 2025 12:44:20 +0000 (UTC) X-FDA: 83891452680.10.9A25B0B Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf15.hostedemail.com (Postfix) with ESMTP id 4DF70A000D for ; Mon, 15 Sep 2025 12:44:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=dD4tf7gt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Km+PAh1x; spf=pass (imf15.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757940257; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cg53KnBMEMN86OdMPXwFzVcrhTkrqe4ZT8XqvpS3s2Q=; b=k5D4+PU0In/9zs2xCa/52R+ZDsS26t1yUcA+Wgdr6FGzVvPiTOobPLiyajy5fdr0FQ1cl8 mXxjPoIJSKhzrE3z19fZwzUzfJZq/2Dlki70Xs95RUHV0TaohSek27fHa7baHUbxrjRdkz 30ceBMKah1ntO8skzUqKE1fG2+qGzxY= ARC-Authentication-Results: i=2; imf15.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=dD4tf7gt; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Km+PAh1x; spf=pass (imf15.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1757940257; a=rsa-sha256; cv=pass; b=u45e7M1FGkHr8CBo3sn0OlyLTd+mDhn74Z/FycVn2JVY0Pbh6r8YhNck0vr19JAUisW4+H 0aNneIc/CW3WtGdsNvekADsvkgY4mb/qdzfY4SKNH2p8qRKuMHXfrI5WJRHc9j05tuirSN Ul+BPAbcIzpCQyAcYkSx1LVYfBREa+A= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58FAu22T028269; Mon, 15 Sep 2025 12:43:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=cg53KnBMEMN86OdMPX wFzVcrhTkrqe4ZT8XqvpS3s2Q=; b=dD4tf7gt3IHS/PhVmE/+Pkq2xtqCVMZ3// B3uZNFqZIy/s2mkJa8Pl6CR+awqIRJhjE/7gi8033WwZTmm8rrSLxQQrY0vFPCtD VMSMg+9EYhOuSEiEHx8CuWGbVdV+o9/DinJoizNUreF6b6yYKBcgCqQNiSLgB2Fw IyD2j+O3wzpnrOUQrjmJ6lfIGanjhhxdk8p5YLfRburyYORVAyjD9Raf8MKQGKVB HhMOj34mKK4SLuyEgW/6T0uevjD0g/eeIlrMW8jUYe0Zs7e+07ZW1rFbepkKgKyd yoH3ZcAhP/gf/xee5kogNVXSreSp0jN+8+lInJIokPxcKNS2yZeg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 494y1fj9ep-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Sep 2025 12:43:57 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 58FCaejU015290; Mon, 15 Sep 2025 12:43:56 GMT Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11012066.outbound.protection.outlook.com [40.93.195.66]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 494y2b0ekj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Sep 2025 12:43:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yUskIcun2a4nSWtCy0A6MbGJnGwqQDvx509kokTkFv2pN69GI5Nx131O7AxDLMx22+yNXJ1lhbHtREfBYLMzhlYmbQQh33Q1gKWnX+UueGp7e+st5PpI8+FnENtjadAyr8+QK3AB9WBaGnhpdkQzne5PI4vMMVBjR+sDnwQZa+NGGsTSI9WhSPFTF7CM2T9hiC/5j6CC7qmBy/MYOWxTcKg5G4jmRWNhG1OslcvGQyBy3CM4mps7IROAcdd2uQEjg/3tPyu92bKfDFM3I5bBEST2M01WDWaDui9l9MhG4dFBCyp1mHGRMyn3zhZo7/uTLA/iiaoJoqre1LePau2+vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cg53KnBMEMN86OdMPXwFzVcrhTkrqe4ZT8XqvpS3s2Q=; b=f5RMo0eliFzCDH6t/NgTRAam9RkSpS9lHiLNDGyIrIF/5DHDciWcA/VsHiKQ4M3vhihKOQEETzNL2zUiDh39h02cj/7JNbl6AehgtQ9QNuo/+hfnIr0DKR5bbF9uEhCw33aSZwZQqilkQ5Evn9Gq4dmujQGTMOguX9yo2WCKe3kW3NTMJ+F9iqWsaTDcJmF9JQaOVDpRyTHB9SRMHnG+sEy8AMMUsaYuP5EMM5uLjWaOBGVkc3yWyfgOoZg9Q2AGGkm+F2GSyFTBfs4iozZil+jR4ai/emrYQArXuM7QPOHAsuar5LJi4lbXq7zT20AeXHb2txR77EmjZszwVbISpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cg53KnBMEMN86OdMPXwFzVcrhTkrqe4ZT8XqvpS3s2Q=; b=Km+PAh1xRQX8WRWuaM+eKcJGFzPzvAJiv9Fn50OxLQFfkNRLmsx4iHKbeVHG1j9RHiV5u1GY9TQB/kT9CqHrbKAalhqwHfFCi6zfaAcEwx7xHGZ1e9O6ukTQ0nY7Go+1zY2xS0dtjJLQfsrKqKKglRbhgwmqlZW0qgc7vnbJHco= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CH3PR10MB7763.namprd10.prod.outlook.com (2603:10b6:610:1bd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.19; Mon, 15 Sep 2025 12:43:52 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.9115.020; Mon, 15 Sep 2025 12:43:52 +0000 Date: Mon, 15 Sep 2025 13:43:50 +0100 From: Lorenzo Stoakes To: Jason Gunthorpe Cc: Andrew Morton , Jonathan Corbet , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v2 16/16] kcov: update kcov to use mmap_prepare Message-ID: <872a06d7-6b74-410c-a0fe-0a64ae1efd9b@lucifer.local> References: <5b1ab8ef7065093884fc9af15364b48c0a02599a.1757534913.git.lorenzo.stoakes@oracle.com> <20250915121617.GD1024672@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250915121617.GD1024672@nvidia.com> X-ClientProxiedBy: LO2P265CA0056.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::20) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CH3PR10MB7763:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d2ebeee-e59f-492f-9f24-08ddf45586a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?e9pNiQ68uH1w8UA0ym309x0wPdyvCEuWVH13ivoxG0qkHPP0xtmhj4/Qa4+8?= =?us-ascii?Q?ucR6mCoG5CT2uPHniUU4yqp4PAQ4ZyXbwa1ZQxx4mwgaBH/uvdbvanWlRhkP?= =?us-ascii?Q?4naeU21ZDzjimgw4jQ51Pv+VsfL2Ng6uDNyFONlh2xEbbOCjaMJt4HYxHhnq?= =?us-ascii?Q?rO2a2uJz7RfWJg+soj+pJtXgxNkzh7j1H7HmQIpVY2URP92nz9sylGug+cO0?= =?us-ascii?Q?jdOQRzu/RjOz3L4AWQnIQDMO7LJAXOsP/ZZrE1odXRHNFbkPwDGoiYSk9Lhk?= =?us-ascii?Q?KpH+7rttxz01zBk1AinbGMaFkHFDb95jXpuAgyFrAlM4jsYuhPpKA2nD7jwy?= =?us-ascii?Q?S1EG4qnyip1saci2kRWi5qsjkIWxM1WvX2feAGuD5AgoJdVoSCIDHwabIXlx?= =?us-ascii?Q?EJ7iTn0FDRVs6PqdcyXH6dAkhgsRjHiZyd6r25EzivgW4Yc8Wm7W7nuV0n+Z?= =?us-ascii?Q?HQbhFDFC8TLJvaygwInjnB0oZhkWogOXmq57ufF0EZFK/u6UQWWHRGSCot5W?= =?us-ascii?Q?oXGBlV1yUOl9CovM6BvcRgIRTOPVWUGTsTkh2U6gyJYWyhDR7D8QtpLb45IN?= =?us-ascii?Q?GUV8lti0dZY/5zAmtSzI//Q4UUQxfUQTHXqTyAve4Gi7MBBMnJJ4IgOXNGqa?= =?us-ascii?Q?fqmjZgs05+KTxrqhWZWrSYM8jo/A+4/jsiBh+ysBJgwbquSlU3HwLzWD1toT?= =?us-ascii?Q?WirkzAOp8dOBLQgkL0ECIfmNMYuomjPd6dZsvFI/iZV2uDMJmQyNPd7UKMUK?= =?us-ascii?Q?rTOPDYLtmJ4vZp8LYnfMrU1qGB0pBfPy1/VLAVJAggRQsVxSCluWY1tcRLsr?= =?us-ascii?Q?zu/BCuFRja1ruubwXe+YbYuEWwkc2rwMBZKCXSLZhzeT0Gfk4ZQq+l41VtAt?= =?us-ascii?Q?ccOoPltGBaUWW9G38gl3+HC6YJ6y48QNRi0/QmcBEiOx2ovCJhz2W8qVFz0q?= =?us-ascii?Q?frbvifAuIHdIZ7lHFmF3RcdZpuXoCyJIPWE9x8TZhxc4UBsxddllMRGvN84V?= =?us-ascii?Q?NMCwywWBiJtXZfJdwaPH1+azk4iuS4aiK9ycWFy4dAHga4Ofb3Q/NzRlaMPl?= =?us-ascii?Q?Ztk1WejYgCsZUFC0CcM/Dj8wc9Q1ODiHNeQlcC4MMRZ4unW7LPjcP1gmbv81?= =?us-ascii?Q?5Ji+xdTFwNqDcuz9YFhUvw5sTLneD6vQwTmtXq5qv6jZy+lbTOL2ABa43Ezk?= =?us-ascii?Q?A2S1UEw3uaiFCikPt9dzThyE4/wyjVkzUJaTJ8cx/jhwvkZfpCT+YWRlu5uk?= =?us-ascii?Q?uZM1aknqvVNNi9ShHJe11iSrI2PF5cm0CDmhtV7t1kgdtKLCT5g1htSkGou7?= =?us-ascii?Q?xqLQJCmARZ54R3/G41oVFG4ynZLZQ/IXgyatT9M3DNyxplgvS6eGjgIH6Z8q?= =?us-ascii?Q?3t8eoGLMks+3qOl/PzxIzIs09vXxQwJtbjqYvLeum5gIFKNfnO5YCigyIpa9?= =?us-ascii?Q?aCMlbQ/3Qro=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w11LpkFoCaGzaupVvehj/AWMygl7E6NCXcHIueXAPbC0QM2P6kkwLrJWpqa3?= =?us-ascii?Q?+1YeDvj+aK09QSx64aEbMdCiy4Vf+tRQhV0ErpLDN4kIspqXkpSFxZmusIAt?= =?us-ascii?Q?c70CrCgzoqYzBsXphsyMywJKNyfFuon8i9rshKpSRHR0pRu4d7dck6gfnzUm?= =?us-ascii?Q?o3eRY6lLWca1KhqKFU+hdhawPaeRdlJ+f23zbODB3Cb+3zjev+y9EsjpyVu9?= =?us-ascii?Q?p5jfx2Kl7zNAfID1t0J8gZai8LQsTJZZjpvEvZYp4KoJ7CgN+UpYzoYkSq3M?= =?us-ascii?Q?KX7D96nBBohBHKKzivDKw6hCmz+WEWp4koMtFMrcxgYhWIIOlMFLYyu9tfL3?= =?us-ascii?Q?FecwyxBr6igqQ9qLWXbkSqkJwz0Md+jhFEoc/FCKPJVcPMdPkX7k59XFW9kL?= =?us-ascii?Q?g05p+47VTj0Qhjv8KhOIUE1i24JgxtIUlTpl0/Rf4uFeyO6YhDurbRCL+6z9?= =?us-ascii?Q?fEJunkA30XwBCfpMys5A2yO9RZZAmjxmUJlkSBIxuAEdr5sjVERK5KltLvvy?= =?us-ascii?Q?MDqav9PES9z7antTE0iBk81PEW9+Q9hvii2CnyDEHDQ8BhTvIjDTZi+5PStU?= =?us-ascii?Q?gX2zW1pBXVquAivzPhYMkWMgYHs+yHuZrsk/nRIR8QGsQKSaJNwHHDSPvu3R?= =?us-ascii?Q?6QD04bIUR2zXzgfovQ3oTwXz3N/M8lENtmfgud5bXhK+4oTKP6CR6VZVZF1u?= =?us-ascii?Q?hGHCkXZpkQThwnpQE6MvJuXoSgdJwc2Ehc5VhfMPr51ZQ7KzB8H+pYrs1hhI?= =?us-ascii?Q?arYGERkEqDDy/68IflDVp157F37OVlfJ4+MvgVzyY/FmKBo9IZQtHwT2S/bJ?= =?us-ascii?Q?8T4wckYztK/r0GVLTdAGdZmpgW8Ncz5IwDB7VdHu5uDIzDaLEl/otsjkxY9d?= =?us-ascii?Q?m1UGHVTWs7Ng3UMj/v9csyuCloHh5xsc9xeNTBMqbrW6Ka9yTBTq845XvuuO?= =?us-ascii?Q?fNB6tNqzT6aMCne5RD7N/yai6W6oyXOQZaIL0Nz/RvGTKXjArWqWvJbS5VIP?= =?us-ascii?Q?YaeM3iBVxUEk2OIeT5JVpJXuQXLB5ij+fPYC6u+iloNhfpcII4ppiUbnoR/f?= =?us-ascii?Q?orgltS+gsiLDiHAnOEMbbsUwjmmj4tLnQBcAJeyaER/i+dVLaco14qSTfrU+?= =?us-ascii?Q?Zm8eBVYrb6ym339LuZjTOqNggEkS4RPCCRIRleG0yYDBlymfO9zILs5sg1GV?= =?us-ascii?Q?cXt5D0v7HExhmMfHJplMAh4WMWsDzEYFko1PiUWiC6sPpfeFIdi4ry/2hz6Y?= =?us-ascii?Q?eWbxsZpqN0CmflaNEkyIVAw2hI9hUui4bTa3yg4dU0YjnHbEXEBFdRSJmUW+?= =?us-ascii?Q?w9BU9vKydEAc89JUbFRuHb6vrlGofPxfbW8cUcj1/GRirK5imwdCWp4T8Be1?= =?us-ascii?Q?SJH57ohD57ulKbyXpOTNBF5agV1k5KZiVDkGF+kb5otF6w+HskkN0vbUsnRR?= =?us-ascii?Q?17gZrPY5Ix8+isf7CKhHC1gNmkYdKfnWzZNZHJRESSWzn4J2IUwoLATwDuUF?= =?us-ascii?Q?eNF4Eb+h/0+lHBZdJMqV0mjxSvkVqZnkH5ZZEaRGG5sGQyx+NFSN/nrjuCQu?= =?us-ascii?Q?IwbnRSSfotQZ/HkkpbstJTzR2DzeCXhgwO1va7dy/RDEQMxj/T2QMaJNtP/T?= =?us-ascii?Q?5g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1QlTbM6eaRW1MPAw5I77VTfYV3YrhTBo1dlJIs9yjaEzECEf423w58j9cFscGT+uJZI8wDzTGghmayo2SQ0KYwuRlNVR2XSm2OZV1ihWYlw9LpRjOexFs3QEyUqyFvTog1mBMOLw9o21IHXUUoyAJ5rKwXETQ8qvy86XbfhSNVOeTYyazdS2XWLtZHnwMx/D1TFZBBj3bla4+LY0ksIFrWQUEEniKoj658mLD5chr09MVyf2nlkJP3t6a7Fr2fPQpgck7ujieV7f7hz/195y8DWx4Z3noFmZP5jsVwTBkcoxi+49SL0zTWCwJhHnabFt5DzAzr1HieJPCFRsG8WiaMZMLIKoXK4pdLKZCPQ8FMdh3E8WBUGcwptQDvENZbBsjpXfDUyOCgmj3i081VJCDpg+shGIRjjudMKyNEaSh6km9KZYR7n46LBQ0LnP7miR/KtBvLXJG988J+w8ozrd2bZSyc0ngDB6Vy5u/nSGUz9LblxaLH+CtRCTx2Tjsvl0KOHSCC605FzpqNpVwD2KXClqVozRTReUKJ61OdEpb8aQRRTfum6WmtfPZgPP3ugKYtkA+9piLRRJsulPQc4ogsQv033PrYb8ynRHeldj32k= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d2ebeee-e59f-492f-9f24-08ddf45586a5 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2025 12:43:52.5503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XYY5l6c2o02LW1jKmybiI/dcWQbgdN9e1cjXT0ntHatt1iyzWioRVVVd4GOOrMFbkgt5qCja3BD19il9sg2S0dFS4KDlGfoSXlfkg0HdDWE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7763 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-15_05,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2508110000 definitions=main-2509150120 X-Proofpoint-ORIG-GUID: srWhRiwTleQMjLRTZqeBZXySo3uCTmbp X-Authority-Analysis: v=2.4 cv=KNpaDEFo c=1 sm=1 tr=0 ts=68c80a0d b=1 cx=c_pps a=qoll8+KPOyaMroiJ2sR5sw==:117 a=qoll8+KPOyaMroiJ2sR5sw==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=GoEa3M9JfhUA:10 a=BLP_E2ZtPSKGuAszSdcA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:12084 X-Proofpoint-GUID: srWhRiwTleQMjLRTZqeBZXySo3uCTmbp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDAxMiBTYWx0ZWRfX+C82R48jyNy5 8oZao/OJ5JdP/oqqz7xYfG/KekgzGnlo6WnJDiwIJ5A0SgKR5NZTNA+3DjXLTDRzvLoldDZaDEl TXJp8jVZ9k/n2ZJTb9xqDAg5xlu6UdMCb7/PgrZ4vGiviG4MAVCGllDtdA0F66ckE9I3PlPBd0I 2jCajh4d612U99ltSlEBde/LeWt3giNaJVkMB1mQN0onwe4ry3tZowjW6xNB7Urk8ZPPLODD4nq wK2+P4rnKgTajnimie59krE3NCOmSmEoXvylN4ODHAOWXZk/TGLQl55CS89/OjoqkY9L1Uba0xQ wzz9DcQawaPpfuMg9ZmvtJJW0LzKrNmpDhZH2BWJujNLzNJtTp6m77mV0KVLCvNrCPdDPwYxBfe cU05U8eLDVNIgD4gYmXIN4Wfls20Fg== X-Rspamd-Queue-Id: 4DF70A000D X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 3kpcus5npah5rg4ay9sh8uium1up5tk1 X-HE-Tag: 1757940257-457222 X-HE-Meta: U2FsdGVkX1/BzQXYKuBIV/bCvpSYdcjcXmjcTt/EkJcLqQDrSixcrdGA0wDj0SlM9PSuc6/rA+QU+XqNhR6zDEMX7m5X/rclEvYn+fDz5cW/E+ouaDM4rW1ZeNB7cFi1xk7WkwJ92O4sm8qvCLHSilFCqylUP3XcLDUpVzUTKxa123+Afv+8+Q5nM6AOA93g1Sg1LA4t2CjwLSQnp97SdbV9ZmWVrP3EntKe8OkjAm5qPGN787QVp+Hky1qb1gsN3FyWyHghG2Qj04gHX+hyQEBs4xjt/kYXLt+d+5R/RDlDlQNubxmY5T6UwtmOxlTIbmJEYFNNjd4wTJH/q4uQP42Gs4uuIa9moFxhsYpi9gBr+BV/b973LSK+2+z2lwqPn/nDrrh+G5fWLIBZBjddLMVhdzyGcNJSNU/AT/DpCpHZXmDUZhyjmAyGuBeK0m2G+C6+Rx3DAzxaPOTIn8CNmetDmL3B1yfJ6bZwvhDhh5z6J0EkNwYnmRWdrhDS/SDYLpPKq0xTs/PEq75/Jx1axkqe+Nn64gfkPPSzs3YDRpRsHRs2tORi4KH03LG3ksP13ZcN9uBH+8HpUnvThp0AsoWrmHr9nT9KJCJo2UP8EggUiZKImokVyXgRhl0gjr2QXNMuXpTGhwZYmdUMqZj1CIaFcpnOfmllXr3V8MUhyf4epix8hrmOY/jThcJEvXVNMURzCQFkl71VQE0VyYKQJeU88GEl2B4f37zlkNtpPO2WR6OCoCEhkqdLB/TDVDv5C5VI+5WbA4h6GRDg3bk71BroWM5pz5N99IaUTnAnfcRDuVHiRqLFqVT9jvEt1LGKaNA0Pk+RsvmHj19uomMj1IOCa/Y2KEcyFSnMObW2GRaHY78nbUPos/UimyziIC3ITBkGUVje4O++za4QL9QKRPxw8t1orwMq+D35tEpfgbScf8ffKv/E3LQCb5fTS+79yzE9Vz2IPCqdZHQQOUK UE6nR4wd RgmwLd8Cj5THpMO2ziiZfKgyTY5vXYDEbzJzHjeXt++3e4SUl3/qiwDsgciDdjVDWMlLosoOrXoLOPT4AWgpbNdJPqEDeLPkOveoWVrFBwjc9+9WG7eUuWH/qT7GlaRx98NAh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 15, 2025 at 09:16:17AM -0300, Jason Gunthorpe wrote: > On Wed, Sep 10, 2025 at 09:22:11PM +0100, Lorenzo Stoakes wrote: > > +static int kcov_mmap_prepare(struct vm_area_desc *desc) > > { > > int res = 0; > > - struct kcov *kcov = vma->vm_file->private_data; > > - unsigned long size, off; > > - struct page *page; > > + struct kcov *kcov = desc->file->private_data; > > + unsigned long size, nr_pages, i; > > + struct page **pages; > > unsigned long flags; > > > > spin_lock_irqsave(&kcov->lock, flags); > > size = kcov->size * sizeof(unsigned long); > > - if (kcov->area == NULL || vma->vm_pgoff != 0 || > > - vma->vm_end - vma->vm_start != size) { > > + if (kcov->area == NULL || desc->pgoff != 0 || > > + vma_desc_size(desc) != size) { > > IMHO these range checks should be cleaned up into a helper: > > /* Returns true if the VMA falls within starting_pgoff to > starting_pgoff + ROUND_DOWN(length_bytes, PAGE_SIZE)) > Is careful to avoid any arithmetic overflow. > */ Right, but I can't refactor every driver I touch, it's not really tractable. I'd like to get this change done before I retire :) > vma_desc_check_range(desc, starting_pgoff=0, length_bytes=size); > > > + desc->vm_flags |= VM_DONTEXPAND; > > + nr_pages = size >> PAGE_SHIFT; > > + > > + pages = mmap_action_mixedmap_pages(&desc->action, desc->start, > > + nr_pages); > > + if (!pages) > > + return -ENOMEM; > > + > > + for (i = 0; i < nr_pages; i++) > > + pages[i] = vmalloc_to_page(kcov->area + i * PAGE_SIZE); > > This is not a mixed map. > > All the memory comes from vmalloc_user() which makes them normal > struct pages with refcounts. > > If anything the action should be called mmap_action_vmalloc_user() to > match how the memory was allocated instead of open coding something. Again we're getting into the same issue - my workload doesn't really permit me to refactor every user of .mmap beyond converting sensibly to the new scheme. I think this kind of change is out of scope for the series. I'd rather make this as apples-to-apples as possible for now so it can be done vaguely mechanically. Of course we can follow up with improvements later. > > Jason Cheers, Lorenzo