From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B79C83033 for ; Tue, 1 Jul 2025 08:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65C926B00A2; Tue, 1 Jul 2025 04:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E6A06B00A3; Tue, 1 Jul 2025 04:30:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4863D6B00AD; Tue, 1 Jul 2025 04:30:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2FC196B00A2 for ; Tue, 1 Jul 2025 04:30:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C54EF105B2C for ; Tue, 1 Jul 2025 08:30:04 +0000 (UTC) X-FDA: 83615023128.24.B6A63DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 4C6841A000A for ; Tue, 1 Jul 2025 08:30:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LRgi+AO+; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751358602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dly7kLJXAODD4HRHbtgbrL2VqDcoupb5huNWDKMA8X0=; b=43ExqRJyMsP0mFCRV1u4a+C8FHEswsDn6AkEYxww+5IVoF3Jh8nPM96tJKug+TOftx8Qwl lSex/rkC5HSCALOuWQiwNeiueBALVbxJ4wytbycftib/yUl0ddyM81M2fZapwgoN4JEKA2 wsX0j72JV/kCfVhiDD4ypTKJj5H96lg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LRgi+AO+; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751358602; a=rsa-sha256; cv=none; b=yFL7iKwl6l+7btzg3bTz2ejuGJ5Gcu9yNxeZWQAZoRPXyaNBG4jY6RrRdcX1tNEKcDA/Er 9IQxa/rluLRva2R7o2EImbwFL6di5r9RBrpUn7RIe3yWMxFomfb+vTzUReiFVqaelK3ZmF aKn43aMAOJfrw7teUxNU3tuOB8ZuTsI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751358601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dly7kLJXAODD4HRHbtgbrL2VqDcoupb5huNWDKMA8X0=; b=LRgi+AO+UD+pqUiGYKRwH23G6m9rYMLZs8Wgkq/8X7JTomACY61p2AsPWJ0QBGRbgdys+X 9KPwUkEWC8e3X3EBbshRSDWKm0sO5kbAWaIR2GAFF1BYIGvEFiaxqjoV1zEzpCUvs5oW3S LK2AFIeCyyAP6vvjBjsj9J2Jw4PGV7o= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-nEVcr4_cNTqY-DXG5ZyqzQ-1; Tue, 01 Jul 2025 04:30:00 -0400 X-MC-Unique: nEVcr4_cNTqY-DXG5ZyqzQ-1 X-Mimecast-MFC-AGG-ID: nEVcr4_cNTqY-DXG5ZyqzQ_1751358599 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so25715365e9.2 for ; Tue, 01 Jul 2025 01:30:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751358599; x=1751963399; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Dly7kLJXAODD4HRHbtgbrL2VqDcoupb5huNWDKMA8X0=; b=XCydZLxBR0yRAPmiu7jM5b7wOIgshEEtSW1X6+ZaA3d0rQxGXea1XKC3wFjAKVJHx5 p165Z2oeSBaRu+bN4GciU82Xatb/vX6T1sOrb3tkWGYBwjiTdLRXv/7aC1SbmnS5lUk9 niSdRiP+E8npGk0n9IdnT6cgflPh0M2xncj8W1596bYKvhAOWlWDK+dkzBHX5RBpn3r8 4UiJ6ppFxBnsWL5bXgYwMEsbNLzrGwPeh3azYrabYwjLpvLN/xO04j7ecA+w8lWF7D/m gD9tsQcBwpY9oKTq8tKaPKqkB68IrQ94q2DFfZqNwFQHF/oy4l4rR1DSASPxu1XESwMX zWWw== X-Forwarded-Encrypted: i=1; AJvYcCUOKsjCAxqu3hZ0DmfVqC3NBEPe2NgOgQk0rxYU4Ts/VrCAFPwvxy57ekbC/Loyj3TifrfXQ7Fcbw==@kvack.org X-Gm-Message-State: AOJu0Yz8fDRJW7NqEX2UyCef87X/ht0j7FfiX99X4HMHW+Q0TlbyT0EQ cLbZyVSe1ARoFCnjimsfEIlmgwq/JgbORieeBHefRTDBpbdAbWABY51Bmv4LgXjW3xKnfHcEDC5 qxSYRDHiQcPIElAmaQOJXTT9VRpHp7EVaWYCKaPiih/aolIhSMZ6H X-Gm-Gg: ASbGncsvzDTZs6abGf6pcunSujPCbxHbji+1oY1wTbCgGX/mXCgCElBugxx/u3ETgZw PUpOZe6TVfBtrMJ/CGylUFAVxZUGVDvtObKfzO93PuvCIHPqEnIOe4FiHQd8ZkLQ4Sw2GU0DLYb jWotuxXbN6FReTNGW6jPtt+h8J3W99egsrI4jum+ZkfLVCDaCaODv4Qf5n5U6ngYBIe7a6Rs9F6 +G3vv4xCymUKyM6CWV8z37gAGGC2yhPPYQ/SY6TVSn8yVMBRuiY0LTnn9MpZL2mAbITWmxDz4yW fRih2j/uzom7ubl82g95MdSSse9r3b+Tsdi/ancM5HEWpgCiqLD34fJgkZhtypIHvCaXqNLt8ST ncP2vSXYjosg2EcxEOpnA/6K54TWjGwYs4ZZa2m6cjFCZZg6vCA== X-Received: by 2002:a05:600c:458b:b0:450:b9c0:c7d2 with SMTP id 5b1f17b1804b1-45391b6b96dmr133227495e9.11.1751358599101; Tue, 01 Jul 2025 01:29:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEWpMztTlH2ZF2ZQcI5K0kw/h7norGjoB/XuG0q+YJAXvrKR/hZBsXnJltourxu7zIahXchVg== X-Received: by 2002:a05:600c:458b:b0:450:b9c0:c7d2 with SMTP id 5b1f17b1804b1-45391b6b96dmr133226535e9.11.1751358598437; Tue, 01 Jul 2025 01:29:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3a5fd2sm157378465e9.15.2025.07.01.01.29.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 01:29:57 -0700 (PDT) Message-ID: <872810e0-3570-47ff-8f91-3cc97a8870a1@redhat.com> Date: Tue, 1 Jul 2025 10:29:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 07/29] mm/migrate: rename isolate_movable_page() to isolate_movable_ops_page() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-8-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MiItIGPCpney2p82cLZcgxhmWrA7jAoUQJzL7dypYh4_1751358599 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4C6841A000A X-Stat-Signature: wxbty6q7yw8y8r4s3py9kiy7t871rwdt X-HE-Tag: 1751358602-437700 X-HE-Meta: U2FsdGVkX19WLOh4SJjdzSgJiZyf1N+9vglGR5jf1Z9XNyarqL997rTdUDQ5E3K/D3TSP9HGn3FhUQ/jyR6RMr93ASATqsiv1hrgJ+QH8FyVL9Ypgh+m9ZATvucWJEuqTGi9845w5E1UFqNv3H31agMRQC6t7JN0wq0xkxxDs+fewVt6eTkemv09rvtD8shk3pihyQqo/KGJFHEXOfSlRf/I5vlC3/hO8+cFtJepoDapAQQqY8LBEOoXwaKgjvlyxMo2YVl/VzjbUgxtL77wcbD249iLZdas/Jflzf/2peRpFKRwOSTjEx/yuA6rYbIKRzkl22vgUOpI9f9p5BSY+ShsA02tFw2HkeotZ8Kf7uaWRiJuE3BReOlTKIu+zc6Nu6eCAgD/Ic6Wm0GVWn7RFGHT6tw7U88EB4Fc8qOjomQNJiBzalYKk4HLpGACFKpQfiNJmDDu+qYzpbMFU/WMfudQxSZi2MzD41aqgyZYaKJWZ3idhmULr1FPdo4KSUueBRS/WXWcEg7BzF43/fyMY0nAmlALDro9ylHPaCvB8skW5rR54LfDfISlwd8Jp2ELWix+j92kVLbgN9y2gwh36BJqMxj0/tjxRKvvznOHPWZGeE6BmBJg7VQgOBqHVt7LRTjCRtBIj1mbOqhLNhiUxoP7mW/iF3OpcYB256F/8utc4xNfDGk1uBjEZMwMr+BZ1j+XNJlMRuchbQq1X92tRHb7cdIR8TzhV1FiGdRXYbqQOSPP0VPsAx3/OaHzRc3Wnw0GEbnjcQ2BXJLEZBpAxRKQF5+ofdwscZld9qbvv/gGL7fk668aOqwxmXbxd/u0TEBs/IbIMHQlIRMuILHG9Me5EdUPFFKB3QpoWMIff0IA7vdIrHTKUWiCRumovbxqmCRJB4XZwMYMBLN4irMOUcCkt/7AqCQNrA22tmDoTWtuMQSbvLOHvyMBqK+D8My7PgolDcv2EKhPGC9JYCF Wxh53P72 S5Va1cluMEB6/YfGfEmNqFKEGaGaNc8b/w4guVXp06RizXcrIIYrxBV+P77ymDwWrKguKN17RvqmCf7wcRJOqcA+z7KW8rpiko4p6m01G2AjqrJQPN7ix0ZH6yTjdIZsgHbiNCRNlS4PQfO/8PBlSdi6DQFUHC3Aq3tQllYGKlx2+2KOwAewF/lzB07IJc9SZ2oN6VAnU4m4DTBahP51kdYhB15ieyWTjLPUTGvftd31fFQM4V14IOiArirPFNbZAbMh7HnlwYGrR1dsX6E2eaa/sExDjbYodeH9Xg1qdxuhwoRjbOvSks/dqjq7MmsY6O+nbmnVGoI8rgyZ7NMlvGjN6pez3XxsuAnTq9oTWLTH04zKn0kjFIrzV/04g1gpdX90LytcpmZ29squOIG70G32ZnHuG9Jp74QpK3d3Pgl+p9ffzK1KBVv6d04JCq2e0XvVRSDfLd7fbGXgdsTAfWhCluJ5Ks0wBNLotFIrOLoXqiddyKTLV0+NP/dBq7lJN5FlFKDDY/Pad5Y7gK0TzhMTOR5EhPDmqgIUPOJHwe+Jsk2sBCMqQIrsFPGyKWnum+7RCKul8QTpA0WSJfTqFP5IE7rsIxJ+hGE9jzlfXj+dy7rfW1HQqgc2g2kIPCm4MYfKBg5z/zYOATms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 18:24, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 02:59:48PM +0200, David Hildenbrand wrote: >> ... and start moving back to per-page things that will absolutely not be >> folio things in the future. Add documentation and a comment that the >> remaining folio stuff (lock, refcount) will have to be reworked as well. >> >> While at it, convert the VM_BUG_ON() into a WARN_ON_ONCE() and handle >> it gracefully (relevant with further changes), and convert a >> WARN_ON_ONCE() into a VM_WARN_ON_ONCE_PAGE(). >> >> Note that we will leave anything that needs a rework (lock, refcount, >> ->lru) to be using folios for now: that perfectly highlights the >> problematic bits. >> >> Reviewed-by: Zi Yan >> Reviewed-by: Harry Yoo >> Signed-off-by: David Hildenbrand > > Seesm reasonable to me so: > > Reviewed-by: Lorenzo Stoakes > >> --- >> include/linux/migrate.h | 4 ++-- >> mm/compaction.c | 2 +- >> mm/migrate.c | 39 +++++++++++++++++++++++++++++---------- >> 3 files changed, 32 insertions(+), 13 deletions(-) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index aaa2114498d6d..c0ec7422837bd 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -69,7 +69,7 @@ int migrate_pages(struct list_head *l, new_folio_t new, free_folio_t free, >> unsigned long private, enum migrate_mode mode, int reason, >> unsigned int *ret_succeeded); >> struct folio *alloc_migration_target(struct folio *src, unsigned long private); >> -bool isolate_movable_page(struct page *page, isolate_mode_t mode); >> +bool isolate_movable_ops_page(struct page *page, isolate_mode_t mode); >> bool isolate_folio_to_list(struct folio *folio, struct list_head *list); >> >> int migrate_huge_page_move_mapping(struct address_space *mapping, >> @@ -90,7 +90,7 @@ static inline int migrate_pages(struct list_head *l, new_folio_t new, >> static inline struct folio *alloc_migration_target(struct folio *src, >> unsigned long private) >> { return NULL; } >> -static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> +static inline bool isolate_movable_ops_page(struct page *page, isolate_mode_t mode) >> { return false; } >> static inline bool isolate_folio_to_list(struct folio *folio, struct list_head *list) >> { return false; } >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 3925cb61dbb8f..17455c5a4be05 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -1093,7 +1093,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, >> locked = NULL; >> } >> >> - if (isolate_movable_page(page, mode)) { >> + if (isolate_movable_ops_page(page, mode)) { >> folio = page_folio(page); >> goto isolate_success; >> } >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 767f503f08758..d4b4a7eefb6bd 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -51,8 +51,26 @@ >> #include "internal.h" >> #include "swap.h" >> >> -bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> +/** >> + * isolate_movable_ops_page - isolate a movable_ops page for migration >> + * @page: The page. >> + * @mode: The isolation mode. >> + * >> + * Try to isolate a movable_ops page for migration. Will fail if the page is >> + * not a movable_ops page, if the page is already isolated for migration >> + * or if the page was just was released by its owner. >> + * >> + * Once isolated, the page cannot get freed until it is either putback >> + * or migrated. >> + * >> + * Returns true if isolation succeeded, otherwise false. >> + */ >> +bool isolate_movable_ops_page(struct page *page, isolate_mode_t mode) >> { >> + /* >> + * TODO: these pages will not be folios in the future. All >> + * folio dependencies will have to be removed. >> + */ >> struct folio *folio = folio_get_nontail_page(page); >> const struct movable_operations *mops; >> >> @@ -73,7 +91,7 @@ bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> * we use non-atomic bitops on newly allocated page flags so >> * unconditionally grabbing the lock ruins page's owner side. >> */ >> - if (unlikely(!__folio_test_movable(folio))) >> + if (unlikely(!__PageMovable(page))) >> goto out_putfolio; >> >> /* >> @@ -90,18 +108,19 @@ bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> if (unlikely(!folio_trylock(folio))) >> goto out_putfolio; >> >> - if (!folio_test_movable(folio) || folio_test_isolated(folio)) >> + if (!PageMovable(page) || PageIsolated(page)) > > I wonder, in the wonderful future where PageXXX() always refers to a page, can > we use something less horrible than these macros? Good question. It all interacts with how we believe compound pages will work / look like in the future. Doing a change from PageXXX() to page_test_XXX() might be reasonable change in the future. But, I mean, there are more important things to clean up that that :) -- Cheers, David / dhildenb