From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7D7C54E67 for ; Wed, 27 Mar 2024 15:46:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C9C16B00A9; Wed, 27 Mar 2024 11:46:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 178A16B00AB; Wed, 27 Mar 2024 11:46:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08E476B00AD; Wed, 27 Mar 2024 11:46:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DE2E76B00A9 for ; Wed, 27 Mar 2024 11:46:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9CCAF1C0F39 for ; Wed, 27 Mar 2024 15:46:15 +0000 (UTC) X-FDA: 81943245510.07.D811D5D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 960C68000C for ; Wed, 27 Mar 2024 15:46:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711554374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V/oqMb5B+WaGyGqvTveS5lXPkGeRsQMa2WAcLT9k28U=; b=0pCa1Mmj3d4ray9F5qAyl+Wvtyc+uLnfD4PfILGt8GEVDOJ07Hn0JJsgXOyZ9diaBci7FK MMN3a+bFu3FGTGTxXQGgfa+zDD0UJ29e22SWCX0eBp/7iKBg+IqSpPQdWtO1uOXgnmxQL5 djjZAVZPvi5JzshTXp7be5pYZZqi5I0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711554374; a=rsa-sha256; cv=none; b=J8h2A1pJUz2npVp+AGYWmqVyyISePx1uVPN22L9cAwQg0VWFfLssuCxSLPmza4fnFY602J MgzMljbNEiuZh0EVIi9DYQNARBmQ8uQwmwlHf8GgsSvf/Zh1sdNbAUnO4sjIDZSTkF9QN3 oiepuJAARJwG9y39FsPnbeESHbmuMK0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACC782F4; Wed, 27 Mar 2024 08:46:46 -0700 (PDT) Received: from [10.57.72.121] (unknown [10.57.72.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 25BC83F64C; Wed, 27 Mar 2024 08:46:09 -0700 (PDT) Message-ID: <8727a618-30c4-4a13-b0e9-eccc3fd67c73@arm.com> Date: Wed, 27 Mar 2024 15:46:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast Content-Language: en-GB To: David Hildenbrand , Peter Xu Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mike Rapoport , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Arnd Bergmann References: <20240327130538.680256-1-david@redhat.com> <3922460a-4d01-4ecb-b8c5-7c57fd46f3fd@redhat.com> From: Ryan Roberts In-Reply-To: <3922460a-4d01-4ecb-b8c5-7c57fd46f3fd@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 960C68000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bjprpf8tbjymtwt8k1m5a9wi9m6maemr X-HE-Tag: 1711554373-650803 X-HE-Meta: U2FsdGVkX19ktTZSwugSfdxYgpU7tE/A78ohyfMmcvVwYJVYGkQTA1wvaMv8WGG7gGG14S2wiZI/BRRWR1+4pDAHdt6FX1NqVHF5TJvTbjrtAvutZ9EotaiXeYg5BVT5jS87Tqm39hi6nWR7w2JZsrxA8w3QqXsrMFP5J/YO8epGjNssWOCw2Esp8USg+bKqZha7KXrFWbQkQ57TFIzbh/CLefftTc7BeElxEnta+/hzw7PCe9J67yf6qSSfY6bvdQfY5oNos1eBXUJRa+j+DG1QordnAnu44st481N5h6rxD882YqmeP09UrIvs7uzW4ohZ7BJPw582R/nFGCGqc45ksvfkUz/TXJNJ+zn7+/jY+pwYvp8yPncDpQk2vkdYDI3+pn7My9tSUDQh8Fb258zefDvObfPGFIgowHnQwTuU4cwIflNbMQPD1k1Bh7YLs2lMT5IrWmvRIBSUDND4QuNqCJdLnTC+aLtGFO/RorEQkebR45j5sz4FNucEMExl/tADnfWTh5qE94o6XEj7pxr0hDxDn3k9c12MpUhF5bro6zhkVYKnidbTHALEhzfVUlaFXgnLH1h2f1iR2ZjSCIjtTX0y+yy1twEE7GJbx+9kxpVHh8J90d/IJ44FlxMWt1PRXqUoJH0ng3fN6Zdn2rcR4dBgJ+XiAMluLzp3fnSgCF4VrzSCDlt4uVoxCtiJ/b+JYYIkDiYyZUkZSYhbZG5PvuoCaAiWoadEQMoaXs1U4ubioPW7fS7goygLxJzTwSADy8utJsmgLIXth0F+lowCBiiDNrJNZShnqb2rA4iqJ7AWytm9AU1IEwB4q2VFd/39Dz2w4xDfRvr11tHfihWgHf+hivudENOyv+tYPN6t3OpLmynlyj/g69AE7ryRxj0vV58YXlau8xo/ztjoPMgohwjsoDN56BDim/ejTRiVhxtS0K7O8Gok95rTydk6hzoe728Tz8S+dW0mCl1 RV2eQvSi se7m/S7SdguVnpGc0LDUb9URVVTDEVsdj2yr25ji9CvbgjiwyHPbMFxWhxdhi7WKyRfzRK/II9xf+QOk9BkQ96ZVyoMKSt5TkX3nNFX+fMPgGn7qNJroansxHt/7aexIjDGxmaxurIdECFvKZ3WGAlxkokRnyWpXy2U2zRQOiY8disx4gmPUjeKmXQOOLYScVQZvW0u7EvJZgxQt+a0lLiljUN/OdGZOssuywH1uhSTy3PI3Fypnwm547GjpiAle43NV9rJC44nD1WRa9lPqs2GcOhou4i2mPKoF7U0cxuzn1K6oasi6mphRnYGHyfe9Z1lYPehBYpMBDwEM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > Some of them look like mm-unstable issue, For example, arm64 fails with > >   CC      arch/arm64/mm/extable.o > In file included from ./include/linux/hugetlb.h:828, >                  from security/commoncap.c:19: > ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of > 'arch_clear_hugetlb_flags' >    25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/hugetlb.h:840:20: note: in expansion of macro > 'arch_clear_hugetlb_flags' >   840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ > ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of > 'arch_clear_hugetlb_flags' with t > ype 'void(struct folio *)' >    21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) >       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ./include/linux/hugetlb.h:828, >                  from mm/filemap.c:37: > ./arch/arm64/include/asm/hugetlb.h:25:34: error: redefinition of > 'arch_clear_hugetlb_flags' >    25 | #define arch_clear_hugetlb_flags arch_clear_hugetlb_flags >       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/hugetlb.h:840:20: note: in expansion of macro > 'arch_clear_hugetlb_flags' >   840 | static inline void arch_clear_hugetlb_flags(struct folio *folio) { } >       |                    ^~~~~~~~~~~~~~~~~~~~~~~~ > ./arch/arm64/include/asm/hugetlb.h:21:20: note: previous definition of > 'arch_clear_hugetlb_flags' with type 'void(struct folio *)' >    21 | static inline void arch_clear_hugetlb_flags(struct folio *folio) see: https://lore.kernel.org/linux-mm/ZgQvNKGdlDkwhQEX@casper.infradead.org/