From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B908C3600B for ; Mon, 31 Mar 2025 15:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A8A9280003; Mon, 31 Mar 2025 11:44:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 657B5280001; Mon, 31 Mar 2025 11:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52050280003; Mon, 31 Mar 2025 11:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3375F280001 for ; Mon, 31 Mar 2025 11:44:52 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CF43F161361 for ; Mon, 31 Mar 2025 12:08:19 +0000 (UTC) X-FDA: 83281723518.08.1E0D9F9 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf22.hostedemail.com (Postfix) with ESMTP id DFB5CC0004 for ; Mon, 31 Mar 2025 12:08:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sPs4UG8j; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743422898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u1GWmMoHCvsubRoH93WkHaw6HXEFrK/VzVaX8jj4hCw=; b=170wG3Xdwl3wol4mf2T7VZFRIlhB96BHnDj9DZ62pGw4mgdA+ZETfmY7lmbhAgaJA+CBOL ytVe/gIfJwZtFglsS0Mj3JPMWmKU5uEIef9/xlBH0/+udHu11Urh+vTmEi2wFpeRZTPEbi ayZfVeDTmvnFqm5vqjQnue8ma2JvhWw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743422898; a=rsa-sha256; cv=none; b=0KGPpTh1ReOnIg13awXbVa58u7Iq5VVEdDBsZe9r81VbVcCxwDpSE2f1Am46S8g9tj0HcJ ZOohuY36pHpAKb95g31nS3ZBV5Cpoxu3UzZfezgV74+QiBAVaZ9v8HpFmkICa9sRctg2FC 527p6CcnCYvUq1gwpHonA79XqZmO5yI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sPs4UG8j; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=ye.liu@linux.dev Message-ID: <8720c775-c0fb-4fbf-a1a8-409fef2b67ad@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743422895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u1GWmMoHCvsubRoH93WkHaw6HXEFrK/VzVaX8jj4hCw=; b=sPs4UG8jWktVkHSe8cvVWOu6j+50Z/ao9cJTDZ+VO6PtZ2s8yk3wYbKtpraNBurtnePyge bBEv/GqIJ/KC/iXzkR3Ae5udUvGup6od/aKoDp1tByiXTb5NbKhN7f3QNEhR91qgIlirCT O6hh/mlEMTs01zImwhtm0jU7sQOx6TE= Date: Mon, 31 Mar 2025 20:08:01 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in page_expected_state To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, Ye Liu , Sidhartha Kumar , Anshuman Khandual References: <20250328014757.1212737-1-ye.liu@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DFB5CC0004 X-Stat-Signature: ns85qkcbanx154r6dqwztijzczf5sfn1 X-Rspam-User: X-HE-Tag: 1743422897-459660 X-HE-Meta: U2FsdGVkX1/7NtRvkDDHRcnOFCHAXSfuFCBWst03ehOXgMgZ3fPaQF9IGqVcEBgvusBO05VFKY517DpRdh1UhozDur1c8u7PtWQk+9+ZQOrXLxFU7yyaObT4fdgmzb86l350YFp+Tywk3/MIdZ6gdaf2XiXFP8qJIr8FukFaM8tC6NbkB1hDPzNyoxU7EK7RyYFqpvejsRbuoNaItK3r3FgJjxi6uKmkRbTFg7BO5zvAaIL1LJhw9Cpw+Z7VKkhGKzN4N3wjsjXl24PdcTNze7ahRE580/tbhWzEa9qrgSYMpgCMxxjIGMYvbZ3hvOmGoNfUh+//TluipNjHpsh5qu0GaUEu9YL+8lcauLBUKDv63mkkGk/POsDPSCiyNnoMu6jA4fmEYnKsDZlUnoY9vBT0g2Q2m1Lm21z18brWcxhcE6qzbJq3ID9JzbU4KMxXlXtfjTn6v9nT3Rsq56diHHr2eaGZBtyemInIwhPJ1HVfj6NZJPQBxwiNMTixEtgueVEEAIngdxK9HVSoR2FXa1t+u+xKI16aaDDb8UHjzp4QhN+qRPMqhxKKdBxqNqxUdaedS1X6LHZEN4TrxnZ/SJeBAg9Sr5jdVGB50pHFOGN6at95oyBq4Sy1HkXZOHWZ2Rj8ckZ2lgFVOaDTRDNyIB5o1pLoKNAXyxLBEBgxMijP3WuS2H21NZnhVvPE0ycNt/UvY89U1ofw73fN8KzQkhbs1VKzzDGft+CLCN8eOprBezMrQEIrK6a/q1pVYza0z41av6moQm9ty2JB9Pryh8n60cK/tJwR9XXpOcRvcAf27H6DrrqZoX+pBrTAMaHnRasGGmRlL94UxaAXNA6DJy5/u07Dle2EUkuS05JGCECUWF1AwtXbXBuLnjp6iks426YUH9+F5OHfZkTRYeRCtAlPFUqm+5PK2L7IVTpnaUEEJDKYhDiAMnbazO40vYByOo0Qa5QCYT4EMs3kDAQ mDlMyawn Gls5wuZwwzf3DzcEFep/xACW6h/9OghBTNBFXDXdfaMsYO6KncGMWMM+MCMRUo5J+sVOHH8jM3V3R0KXHVABteWR1KmgXpApbzRVAfJaKwhcTbjVvMeo6OhRHYKL8sBgrS1CC7cO96KuPsYpb0kqBaQgHdk1Ee0qkL+gfKabob9HENU1NqqRAGqCrOO8lsdpJ8e9as/UyqIn9hQzeKdS3quHCpWqIS1gk2+rRQjj8RJr3225dLOH96kfxaoyF7qpOlK3v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/28 22:29, Matthew Wilcox 写道: > On Fri, Mar 28, 2025 at 09:47:57AM +0800, Ye Liu wrote: >> Consolidate the handling of unlikely conditions in the >> page_expected_state() function to reduce code duplication and improve >> readability. > I don't think this is an equivalent transformation. Could you explain it in detail? > Please, stop with these tweaky patches to incredibly sensitive core code. > Fix a problem, or leave it alone. We are primarily short of reviewer > bandwidth. You could help with that by reviewing other people's patches. > Sending patches of your own just adds to other people's workload. Thank you for your feedback. I understand the sensitivity of core code and respect the limitations on reviewer bandwidth. However, I believe that reasonable optimizations should not be rejected solely because they involve core code. If an improvement enhances performance, readability, or maintainability without introducing risks, wouldn't it be worth considering for review? Regarding the reviewer shortage, I’d be happy to help by reviewing other patches as well. Could you please share the process for becoming a reviewer? What are the requirements or steps to get involved? Additionally, I’d like to clarify that my intention in submitting patches is to improve the project, not to create unnecessary workload for others. If there’s a better way for me to contribute, please let me know I'm more than willing to collaborate.                          Thanks,  Ye Liu