From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
dhillf@gmail.com, rientjes@google.com, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH -V9 04/15] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages
Date: Wed, 13 Jun 2012 22:07:06 +0530 [thread overview]
Message-ID: <871uljnp71.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120613145923.GA14777@tiehlicka.suse.cz>
Michal Hocko <mhocko@suse.cz> writes:
> On Wed 13-06-12 15:57:23, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> Use a mmu_gather instead of a temporary linked list for accumulating
>> pages when we unmap a hugepage range
>
> Sorry for coming up with the comment that late but you owe us an
> explanation _why_ you are doing this.
>
> I assume that this fixes a real problem when we take i_mmap_mutex
> already up in
> unmap_mapping_range
> mutex_lock(&mapping->i_mmap_mutex);
> unmap_mapping_range_tree | unmap_mapping_range_list
> unmap_mapping_range_vma
> zap_page_range_single
> unmap_single_vma
> unmap_hugepage_range
> mutex_lock(&vma->vm_file->f_mapping->i_mmap_mutex);
>
> And that this should have been marked for stable as well (I haven't
> checked when this has been introduced).
Switch to mmu_gather is to get rid of the use of page->lru so that i can use it for
active list.
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-13 16:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 10:27 [PATCH -V9 00/15] hugetlb: Add HugeTLB controller to control HugeTLB allocation Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 01/15] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 02/15] hugetlb: don't use ERR_PTR with VM_FAULT* values Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 03/15] hugetlb: add an inline helper for finding hstate index Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 04/15] hugetlb: use mmu_gather instead of a temporary linked list for accumulating pages Aneesh Kumar K.V
2012-06-13 14:59 ` Michal Hocko
2012-06-13 15:03 ` Michal Hocko
2012-06-13 16:43 ` Aneesh Kumar K.V
2012-06-14 7:14 ` Michal Hocko
2012-06-13 16:37 ` Aneesh Kumar K.V [this message]
2012-06-14 7:16 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 05/15] hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb Aneesh Kumar K.V
2012-06-14 3:09 ` Kamezawa Hiroyuki
2012-06-14 7:20 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 06/15] hugetlb: simplify migrate_huge_page() Aneesh Kumar K.V
2012-06-14 7:28 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 07/15] hugetlb: add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
2012-06-14 7:33 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 08/15] hugetlb: Make some static variables global Aneesh Kumar K.V
2012-06-14 3:11 ` Kamezawa Hiroyuki
2012-06-14 7:38 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 09/15] mm/hugetlb: Add new HugeTLB cgroup Aneesh Kumar K.V
2012-06-14 8:24 ` Michal Hocko
2012-06-14 8:54 ` Li Zefan
2012-06-15 6:20 ` Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 10/15] hugetlb/cgroup: Add the cgroup pointer to page lru Aneesh Kumar K.V
2012-06-13 11:32 ` Aneesh Kumar K.V
2012-06-13 11:34 ` [PATCH -V9 [updated] " Aneesh Kumar K.V
2012-06-14 4:04 ` Kamezawa Hiroyuki
2012-06-14 8:44 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 11/15] hugetlb/cgroup: Add charge/uncharge routines for hugetlb cgroup Aneesh Kumar K.V
2012-06-14 4:07 ` Kamezawa Hiroyuki
2012-06-14 8:58 ` Li Zefan
2012-06-22 22:11 ` Andrew Morton
2012-06-24 16:44 ` Aneesh Kumar K.V
2012-06-14 9:25 ` Michal Hocko
2012-06-15 10:06 ` Aneesh Kumar K.V
2012-06-15 10:08 ` [PATCH 1/2] hugetlb: Move all the in use pages to active list Aneesh Kumar K.V
2012-06-15 10:08 ` [PATCH 2/2] hugetlb/cgroup: Assign the page hugetlb cgroup when we move the page " Aneesh Kumar K.V
2012-06-16 6:24 ` Kamezawa Hiroyuki
2012-06-13 10:27 ` [PATCH -V9 12/15] hugetlb/cgroup: Add support for cgroup removal Aneesh Kumar K.V
2012-06-14 4:09 ` Kamezawa Hiroyuki
2012-06-14 9:31 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 13/15] hugetlb/cgroup: add hugetlb cgroup control files Aneesh Kumar K.V
2012-06-14 4:10 ` Kamezawa Hiroyuki
2012-06-14 9:36 ` Michal Hocko
2012-06-13 10:27 ` [PATCH -V9 14/15] hugetlb/cgroup: migrate hugetlb cgroup info from oldpage to new page during migration Aneesh Kumar K.V
2012-06-14 4:13 ` Kamezawa Hiroyuki
2012-06-14 10:04 ` Michal Hocko
2012-06-15 10:50 ` Aneesh Kumar K.V
2012-06-13 10:27 ` [PATCH -V9 15/15] hugetlb/cgroup: add HugeTLB controller documentation Aneesh Kumar K.V
2012-06-14 10:07 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uljnp71.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox