From: Punit Agrawal <punit.agrawal@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mike.kravetz@oracle.com, mhocko@kernel.org, will.deacon@arm.com,
akpm@linux-foundation.org
Subject: Re: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes
Date: Tue, 25 Sep 2018 11:02:45 +0100 [thread overview]
Message-ID: <871s9hsxmi.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <1537841300-6979-1-git-send-email-anshuman.khandual@arm.com> (Anshuman Khandual's message of "Tue, 25 Sep 2018 07:38:20 +0530")
Anshuman Khandual <anshuman.khandual@arm.com> writes:
> ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
> This just adds mmap() system call argument encoding for them.
>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Thanks for adding the encodings.
Acked-by: Punit Agrawal <punit.agrawal@arm.com>
> ---
>
> Changes in V2:
> - Updated SHM and MFD definitions per Mike
>
> include/uapi/asm-generic/hugetlb_encode.h | 2 ++
> include/uapi/linux/memfd.h | 2 ++
> include/uapi/linux/mman.h | 2 ++
> include/uapi/linux/shm.h | 2 ++
> 4 files changed, 8 insertions(+)
>
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
> index e4732d3..b0f8e87 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -26,7 +26,9 @@
> #define HUGETLB_FLAG_ENCODE_2MB (21 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_8MB (23 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16MB (24 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_32MB (25 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_256MB (28 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_512MB (29 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_1GB (30 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_2GB (31 << HUGETLB_FLAG_ENCODE_SHIFT)
> #define HUGETLB_FLAG_ENCODE_16GB (34 << HUGETLB_FLAG_ENCODE_SHIFT)
> diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
> index 015a4c0..7a8a267 100644
> --- a/include/uapi/linux/memfd.h
> +++ b/include/uapi/linux/memfd.h
> @@ -25,7 +25,9 @@
> #define MFD_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MFD_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MFD_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MFD_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MFD_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MFD_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MFD_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MFD_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MFD_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
> index bfd5938..d0f515d 100644
> --- a/include/uapi/linux/mman.h
> +++ b/include/uapi/linux/mman.h
> @@ -28,7 +28,9 @@
> #define MAP_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define MAP_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define MAP_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define MAP_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define MAP_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define MAP_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define MAP_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define MAP_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define MAP_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
> index dde1344..6507ad0 100644
> --- a/include/uapi/linux/shm.h
> +++ b/include/uapi/linux/shm.h
> @@ -65,7 +65,9 @@ struct shmid_ds {
> #define SHM_HUGE_2MB HUGETLB_FLAG_ENCODE_2MB
> #define SHM_HUGE_8MB HUGETLB_FLAG_ENCODE_8MB
> #define SHM_HUGE_16MB HUGETLB_FLAG_ENCODE_16MB
> +#define SHM_HUGE_32MB HUGETLB_FLAG_ENCODE_32MB
> #define SHM_HUGE_256MB HUGETLB_FLAG_ENCODE_256MB
> +#define SHM_HUGE_512MB HUGETLB_FLAG_ENCODE_512MB
> #define SHM_HUGE_1GB HUGETLB_FLAG_ENCODE_1GB
> #define SHM_HUGE_2GB HUGETLB_FLAG_ENCODE_2GB
> #define SHM_HUGE_16GB HUGETLB_FLAG_ENCODE_16GB
next prev parent reply other threads:[~2018-09-25 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 14:06 [PATCH] " Anshuman Khandual
2018-09-24 16:48 ` Mike Kravetz
2018-09-25 2:08 ` [PATCH V2] " Anshuman Khandual
2018-09-25 10:02 ` Punit Agrawal [this message]
2018-09-25 16:39 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s9hsxmi.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox