From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15A5C433FE for ; Thu, 3 Dec 2020 17:49:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 18138206F0 for ; Thu, 3 Dec 2020 17:49:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18138206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 250C56B0068; Thu, 3 Dec 2020 12:49:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DA938D0007; Thu, 3 Dec 2020 12:49:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A4598D0005; Thu, 3 Dec 2020 12:49:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id E40EE6B0068 for ; Thu, 3 Dec 2020 12:49:09 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A8F7D1F0A for ; Thu, 3 Dec 2020 17:49:09 +0000 (UTC) X-FDA: 77552707218.06.sleep99_320b7c5273bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 81E4210052182 for ; Thu, 3 Dec 2020 17:49:09 +0000 (UTC) X-HE-Tag: sleep99_320b7c5273bd X-Filterd-Recvd-Size: 5862 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Dec 2020 17:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607017748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YZXe59hLHI7lUJaoCikBZP/PP9yfQkA8Mgqf1mIV4UE=; b=hJgHLfqL2JnQqGx1b98qQ++aW9/t53FJEkQoAwKf85SntGaM5+0VVm81TdUUjZnzPN6ebU 0OaFWt+mKAa3gOq4qE7V+pG2lMqEJt37ZxDjeQOlo89/eHME350hEOhW4/0eg0uJpt2LNl Rgm2WIByRWxwpfmg/9uufPwSzVXDri4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-cdN79np0NQWOWki5HLnGOA-1; Thu, 03 Dec 2020 12:49:07 -0500 X-MC-Unique: cdN79np0NQWOWki5HLnGOA-1 Received: by mail-ed1-f70.google.com with SMTP id e11so346280edn.11 for ; Thu, 03 Dec 2020 09:49:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YZXe59hLHI7lUJaoCikBZP/PP9yfQkA8Mgqf1mIV4UE=; b=EbPHIAIFhD66ddcBroBLujJQ3QmRuzxevljHy/DQyDUhgQFqkCDtKMksl4R04i6TOL tFB846Cs5GaRICC4MUGPbXFCrBNJQXsa/7EjVjzFfBJCAQsPcdTpQRaXZin1db49soFS 34VjgZPfyqqXOV1Cm9lwHC/0erLz46bSOe9Ir0H2l4bx0eeGxLd9LeKKI7RRAXSIryd+ o8RRsXL1mMyrHpQZiSdV4LdeVmwp9uu8S/+GLquACHNHn3u42ozTjmqo9gii031s3PRN 1gKTv7rppfHo/VokZEKEl0B77GL1ihWl72gIuWdSbjEZ99HS0NpCLOc5UEhAvSuz+mbt B3Fg== X-Gm-Message-State: AOAM533EVw8ca5e1u1KSiHWt12DNrGd3RkxCdw37y33a6WmhAW0Q23tl S7fVMUqQVgXZJJOWmB0udD1RErTdYWBHvihKa3Dpm9H1v6eXZezGWOU1SPUkUXu5JWmD2eiLkbL A6CWjcZw40Ahjei2bK5TwaXmkJy1EIboC66qV3Xd+mm+35GyDPXRLtyHS9zVLcHQ= X-Received: by 2002:a17:906:edca:: with SMTP id sb10mr3612244ejb.284.1607017745660; Thu, 03 Dec 2020 09:49:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJyp0k7CatgeJ755yk7AjY9Y6ia6uo6Bm6jyGm88jmShQrJoGutTAD06IVsR7/e0vtPLY3KDQg== X-Received: by 2002:a17:906:edca:: with SMTP id sb10mr3612222ejb.284.1607017745440; Thu, 03 Dec 2020 09:49:05 -0800 (PST) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id x20sm1308351ejv.66.2020.12.03.09.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 09:49:04 -0800 (PST) From: Vitaly Kuznetsov To: David Hildenbrand , linux-hyperv@vger.kernel.org Cc: Wei Liu , Stephen Hemminger , Haiyang Zhang , Michael Kelley , Dexuan Cui , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] hv_balloon: do adjust_managed_page_count() when ballooning/un-ballooning In-Reply-To: <9202aafa-f30e-4d96-72a9-3ccd083cc58c@redhat.com> References: <20201202161245.2406143-1-vkuznets@redhat.com> <20201202161245.2406143-3-vkuznets@redhat.com> <9202aafa-f30e-4d96-72a9-3ccd083cc58c@redhat.com> Date: Thu, 03 Dec 2020 18:49:04 +0100 Message-ID: <871rg6ok4v.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vkuznets@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 02.12.20 17:12, Vitaly Kuznetsov wrote: >> Unlike virtio_balloon/virtio_mem/xen balloon drivers, Hyper-V balloon driver >> does not adjust managed pages count when ballooning/un-ballooning and this leads >> to incorrect stats being reported, e.g. unexpected 'free' output. >> >> Note, the calculation in post_status() seems to remain correct: ballooned out >> pages are never 'available' and we manually add dm->num_pages_ballooned to >> 'commited'. >> >> Suggested-by: David Hildenbrand >> Signed-off-by: Vitaly Kuznetsov >> --- >> drivers/hv/hv_balloon.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c >> index da3b6bd2367c..8c471823a5af 100644 >> --- a/drivers/hv/hv_balloon.c >> +++ b/drivers/hv/hv_balloon.c >> @@ -1198,6 +1198,7 @@ static void free_balloon_pages(struct hv_dynmem_device *dm, >> __ClearPageOffline(pg); >> __free_page(pg); >> dm->num_pages_ballooned--; >> + adjust_managed_page_count(pg, 1); >> } >> } >> >> @@ -1238,8 +1239,10 @@ static unsigned int alloc_balloon_pages(struct hv_dynmem_device *dm, >> split_page(pg, get_order(alloc_unit << PAGE_SHIFT)); >> >> /* mark all pages offline */ >> - for (j = 0; j < alloc_unit; j++) >> + for (j = 0; j < alloc_unit; j++) { >> __SetPageOffline(pg + j); >> + adjust_managed_page_count(pg + j, -1); >> + } >> >> bl_resp->range_count++; >> bl_resp->range_array[i].finfo.start_page = >> > > I assume this has been properly tested such that it does not change the > system behavior regarding when/how HyperV decides to add/remove memory. > I'm always reluctant to confirm 'proper testing' as no matter how small and 'obvious' the change is, regressions keep happening :-) But yes, this was tested on a Hyper-V host and 'stress' and I observed 'free' when the balloon was both inflated and deflated, values looked sane. > LGTM > > Reviewed-by: David Hildenbrand Thanks! -- Vitaly