From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F19C05027 for ; Sun, 29 Jan 2023 05:24:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 349936B0074; Sun, 29 Jan 2023 00:24:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FA036B0075; Sun, 29 Jan 2023 00:24:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E8A86B0078; Sun, 29 Jan 2023 00:24:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0B9266B0074 for ; Sun, 29 Jan 2023 00:24:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CFDF8C023B for ; Sun, 29 Jan 2023 05:24:53 +0000 (UTC) X-FDA: 80406697266.14.F8F0415 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf04.hostedemail.com (Postfix) with ESMTP id 503A540012 for ; Sun, 29 Jan 2023 05:24:50 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M3dKq+ov; spf=pass (imf04.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674969892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xp2gbG7Ip2ej8Tc8HZ/Y05GJGe56kCenV2bXMmVY1kQ=; b=IJf1KjsgiAejq/9XdGPIDatadLWjC+e0IXdHTVtHUk/GLA0YfzMEaV0EYuXolLbBvEGzMV 9LkrlqPMi50QrVpm7eJRVxY5px6ebTw/ijbzkGwba2TPL976K7UldVzTWdfoEDhIO2nJKI WQR+ggfmW6tbK30SzoUvbVl2vu7vM9Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=M3dKq+ov; spf=pass (imf04.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674969892; a=rsa-sha256; cv=none; b=VvfOQ81H4t5v34fdh0ae30P/dEM391FnG5D9XdwRundUiyOuH0AHVX39y4yeO12OFhBBXC 9lEVQ8RjftgFP1SZ4Vd7U2oC/gtdPpUPOTMl5vSKlJSXRlvjKefbGKlT3WX+awM2M12iu/ aMdxz16NXclM6xjLLtJkDaC12s4x9vs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674969890; x=1706505890; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=1/Nx5EbWk24yvzBVTOmdsvRqtT8ma3CKeSrmvR0r+JA=; b=M3dKq+ovpJvb1/GESrZ/YfemINh4rVI9bS01UfnuA3XmHVI3X9n9rBb2 Avq6sXzObULJ6qkiLlYlJlK3UX/vJvgjmtW3PonDoVZ5UXk2QoqlbDmal p+x92PWePPkzzb4ihQAM3de5iFDI+YA5Hnt3tl4pnmavuqeVkHV6FABIg vkDQAI6eFKhYVNUfrCnz+ja/OOUrKPoZddI2y7boZc+wDI33TtsqOvOzm y16aeTwfET5h3o51mI5aZt/elLardEeiqp6IL3jXOK0Pi5iNb5MLKXIIw URNSPIXNPY7YYDD4ozLOgel7/XnzewoZacJC8o1SWGUYjRBxCGLYeWh9n w==; X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="325058121" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="325058121" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 21:24:48 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10604"; a="787644921" X-IronPort-AV: E=Sophos;i="5.97,254,1669104000"; d="scan'208";a="787644921" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2023 21:24:46 -0800 From: "Huang, Ying" To: Chen Wandun Cc: , , Subject: Re: [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios References: <20230129033910.1327277-1-chenwandun@huawei.com> Date: Sun, 29 Jan 2023 13:23:38 +0800 In-Reply-To: <20230129033910.1327277-1-chenwandun@huawei.com> (Chen Wandun's message of "Sun, 29 Jan 2023 11:39:10 +0800") Message-ID: <871qnddicl.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: h7qterbrxib8szierfym139ezikh9oic X-Rspamd-Queue-Id: 503A540012 X-HE-Tag: 1674969890-779130 X-HE-Meta: U2FsdGVkX1+6zL6TauEjkRk32BnqhEu8eY3B6ba5wCtOXFXcUTfQYEg9XxyoaBTA50GnQ7uauetYQ7g51ussY40Pl4TsHmCvUAl3rCAbh68WvaiEMKgqOXZaFLS+5cFLOqyjpkgAqx1Ds7Wb/d27mDthDN54953T9kbsbVsau0GPMneK1dj6ucAYTd2fWQf9oYFJFZkgm2JysnAHyVDjuaK8ZtUX2ke1MPWzRXKgPvbix+o+h0iBL5hpaXL54+qVVtGcYd8PIS8TefXw2qV1+UAo7SCKcRLEP3Tl/VzInjCdOItJN8iPs+B2qkzKS9XAnvLm+WeFclDFBguF2WDSjctU7ecb/JSGkKSRXjgnfyE8r3DYOVzohd/4jXbAwLXgJfMB5O1V6q/1d2aYU28ubSIbSm9FUV+QNitJqHTf6PDMreK79kyYRzKnbuKUQqHMmuWS1dni1+cs3v9zDQUEz2naIgl1zHwOf5SqgnMSm20dSg7znffxZmjAHEj1HQUPILwMb91fht6ALpkuG+l0m+b5rUWQzln24CsTVm8TTu/NUMS6KA2ZPyoeq1mYIuJOhi5/GE4hZwBklXORbXtUjgcO7iPQjHlxuLewkbJ2LOqABb3UQRU6PfNn8LHV6/QqR/aQrUzv2LArUp+MSsjTQDlFNT70PSZQiirnWsJblByT98wWCQax+dV6yD4Huy0IaH7qbhUfHMhSlOwmpHVKs+Jr0YbwOOllszn0vYO54YtoUsSHrUspLYRBAeYMcofjbtxTEOk5ehWGsVXjgHoIEHzmR+Xl/rBWN2ZnF27YSXXtcwfzVjgBamshU4kPBLUarMb5Hw9/fN4ZyK1TvJ0JzxgbEWrcpCYMkd+/l+dGw13fCPbHYckaGXQzCF7uDFJIMtbnnvDp/aIgTp1/UM8mwnuDEkViD9XGuAvhns5F/E+6uyAMk7nidxOZIsf3JJvnHNTeUqxgeQAuR9sro19 1dIUm4Z4 k8BmuOJkvC8QOBYufXIJcqFDPPvA0K3ceoA23Cxy/kL4HZR/3uDCpVmw/UQ4qQcFOQb2l0uQrBXyd0k2J10d/UgO1vhPRLcKZKh0g8b8CPzyXAy3BuDVfQgEvop7XuFkyEZJKYnGMM4u370B/y2fCzbx/5wwH5yCROnfV5faj0TmsbX2jt/53gycegXxh8pkWCdEYu2xkZos5Djc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Chen Wandun writes: > migrate_hugetlbs returns -ENOMEM when no enough hugetlb, > however there may be free non-hugetlb folios available, > so continue to migrate for non-hugetlb folios. > > Nowdays the only negtive return value of migrate_hugetlbs > is -ENOMEM, keep compatible for coming negtive return value > instead of ignore return value. > > Signed-off-by: Chen Wandun LGTM, Thanks! Reviewed-by: "Huang, Ying" > > --- > v1 --> v2: modify changelog and comment. thanks Huang Ying. > --- > mm/migrate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index b971edbf32fc..68927aa06f9b 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1939,7 +1939,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > > rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private, > mode, reason, &stats, &ret_folios); > - if (rc_gather < 0) > + /* There may be free non-hugetlb folios available, continue to migrate. */ > + if (rc_gather < 0 && rc_gather != -ENOMEM) > goto out; > again: > nr_pages = 0;