From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE53C77B7C for ; Sun, 28 May 2023 16:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ABDA6B0071; Sun, 28 May 2023 12:33:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15CD06B0074; Sun, 28 May 2023 12:33:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 023B86B0075; Sun, 28 May 2023 12:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E805A6B0071 for ; Sun, 28 May 2023 12:33:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B140312024C for ; Sun, 28 May 2023 16:33:24 +0000 (UTC) X-FDA: 80840209128.01.FC1D731 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by imf19.hostedemail.com (Postfix) with ESMTP id 436231A0017 for ; Sun, 28 May 2023 16:33:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=xmission.com; spf=pass (imf19.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.231 as permitted sender) smtp.mailfrom=ebiederm@xmission.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685291602; a=rsa-sha256; cv=none; b=lK7LZcu8SxXWuNKdQBI2np1nLe3JPcrUgDQXu0rHwelAF0AvuSSeNbN25aZpVQYSfNs85Y 1WDQI4aeRJt7miaq0N43veEKdh0WowRs4ztXvvBj5wKJ8pmmXcQX86F2KwdxW0CL1OUivH k8Yf17muFhhCwjWF5rDgyH3dGGRYcnk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=xmission.com; spf=pass (imf19.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.231 as permitted sender) smtp.mailfrom=ebiederm@xmission.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685291602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N3sGxQ4cCl5e2lfeC1JxVzeMsppLgw24pOwnAtrEM7o=; b=Ii8o9Dyr1KK/m0/E/7VuGbRSK6qF27zV/j0gt5FQ9dv0puQbzu3N7jrGEkhBXxnHNyqYtM EXuCdGJQS2a9fmPd4XKB21kNc7at7o8msgbVKU3ZzvRcNlzqO5cExdlsYJZPXdVVuSyMW0 mRrz82vUYEraYrCxs7l0kxCXxelmiUI= Received: from in02.mta.xmission.com ([166.70.13.52]:46880) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1q3JKa-00Ciru-2q; Sun, 28 May 2023 10:33:20 -0600 Received: from ip68-110-29-46.om.om.cox.net ([68.110.29.46]:56530 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1q3JKZ-005jqW-4W; Sun, 28 May 2023 10:33:19 -0600 From: "Eric W. Biederman" To: Christophe JAILLET Cc: Alexander Viro , Christian Brauner , Kees Cook , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> Date: Sun, 28 May 2023 11:32:52 -0500 In-Reply-To: <53150beae5dc04dac513dba391a2e4ae8696a7f3.1685290790.git.christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Sun, 28 May 2023 18:20:24 +0200") Message-ID: <871qj0l8ln.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1q3JKZ-005jqW-4W;;;mid=<871qj0l8ln.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.110.29.46;;;frm=ebiederm@xmission.com;;;spf=pass X-XM-AID: U2FsdGVkX1+tXXgu/hTVpYUB13NneAVqnHHTh5F4BPI= X-SA-Exim-Connect-IP: 68.110.29.46 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH 1/2] binfmt: Use struct_size() X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 436231A0017 X-Stat-Signature: k6o7ewn1suhmpo4es9i8z43a3tatcqzh X-Rspam-User: X-HE-Tag: 1685291602-302831 X-HE-Meta: U2FsdGVkX19veW54/fhJwt1sBxkNuAWuqB0rxq6bin+CTXpP98ajC62dL0WVXVIecjsrt245daM8Ob5Hx58vvt0bJFHmOdfth+IT0BhzlhDpJowW/9ZyXQX2HntBRsSnf5iqetPSXlrqa45aPxJKtQefgzDaIPkUeQnqUdQRydXXb+vJeq8yE8KhNGdRCvhq2C6H37ubdqhIHnTmDMjqRi/kkNEofniZMs4XEF1ZxDooMafGFKWeT2PrwIrqztIbDjFQQXy4ZtP9ZGFYtJEfrAI3W56gShwBh7jiyQnuG1BdeHdPWOCUEOnGdZukH2ytWn7nhta68JQPHVdMZTi+2ZEJ+/l310dr6UGqiVHCytI9p8ZPJIkGpjI/pNLv/It5NEMr8n2NP3jYILgSPTdXtZe2qBI1zVwUoD1ke7kktOCx0gHT69wyGcMNbgp/WJtcDgal5gjM6nBvd6FZW3NhPO+NYxbeP4uRExGTwaW7Ql+7xgxS0n6oOCbemSifFqbxgTpGXitpEUkjeOPCATUP0M6CAHrvf/ntzkuK7fAK1CGgZpvhFjCiK+Yei+no8jgqfJi37F60WMdhJjUW9bZAVT+z7k5IM/YwLM/Szj0js+TQ1b7xXrynQ6R8FFiAKHz6YLcBu4AKNnFxPHVmQlmETBYoqRvDNyID01muqY7e93+30WJY2y7NSP/5Iiql4rw4vTeYZPPS6KPveYVtXXf4X9X6B4a7XhfOSgSP6It0mQGHPguHtEbpQ5067lrXUO9aiQUDGISl2sO5U8+wA6gBufAD3GBBzw5Kxfya9T6CJR9HbnrUyvxSEvZYRmfH7kBnQGbyp0+hVg6oWHb2YwBa0+OywEF8ZpoWoIGB2DR4Y8wfYDhgPWCeg9pGQGOT3FTCyVsociYeybadhDsI22/ZCSp6lQnRrd3a6dgmwctFQwLkRUo9Od9D8p232QrtDaQDXsgXqs82yjiulgO0kD9 yN8yBzIS kFWZ2DuhgLwKGl3Hc3gi1S7QyPcKH8VElnkC3zbVTEUOwJEOMSPfMF8k6D3FwOEwqrasnYVKpD5CUuhjHMQj3I1md67Z20hTjODR5urCdgkCqvCuLaHYJg6EmuYFM9FFEVN0dzERycp12mJqHRRVgZXzf9KbrpUOZvt8s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Christophe JAILLET writes: > Use struct_size() instead of hand-writing it. It is less verbose, more > robust and more informative. Acked-by: "Eric W. Biederman" Obviously correct transform. > > Signed-off-by: Christophe JAILLET > --- > Compile tested on arm > --- > fs/binfmt_elf_fdpic.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c > index d76ad3d4f676..237ce388d06d 100644 > --- a/fs/binfmt_elf_fdpic.c > +++ b/fs/binfmt_elf_fdpic.c > @@ -748,7 +748,6 @@ static int elf_fdpic_map_file(struct elf_fdpic_params *params, > struct elf32_phdr *phdr; > unsigned long load_addr, stop; > unsigned nloads, tmp; > - size_t size; > int loop, ret; > > /* allocate a load map table */ > @@ -760,8 +759,7 @@ static int elf_fdpic_map_file(struct elf_fdpic_params *params, > if (nloads == 0) > return -ELIBBAD; > > - size = sizeof(*loadmap) + nloads * sizeof(*seg); > - loadmap = kzalloc(size, GFP_KERNEL); > + loadmap = kzalloc(struct_size(loadmap, segs, nloads), GFP_KERNEL); > if (!loadmap) > return -ENOMEM;