From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302A7EB64DD for ; Wed, 9 Aug 2023 09:20:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73EBD6B0071; Wed, 9 Aug 2023 05:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EFFD6B0074; Wed, 9 Aug 2023 05:20:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B73B8E0001; Wed, 9 Aug 2023 05:20:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4AEBA6B0071 for ; Wed, 9 Aug 2023 05:20:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 03D14A0E91 for ; Wed, 9 Aug 2023 09:20:18 +0000 (UTC) X-FDA: 81104020158.04.CE4CD96 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf30.hostedemail.com (Postfix) with ESMTP id BA77B80011 for ; Wed, 9 Aug 2023 09:20:15 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RnPeCjwV; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf30.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691572816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hc1lPSPlgK3uMeOacJXHg0IdjuxtqCC5DKCkms2sJaQ=; b=zUEJU2mMgq4VZgLvZHRY2UaiLlPyuUhZC82r5+JoxMlyTH27w9SQFPt6iDd0VnWfsVq6vr J79fCnNDXXEXnHWV+b+ugcsX0+ViUm92SIopnPUGcQmrBO60tO3DQ4G0FFzrvPHask8ePZ swmo2TovMVPeKCdsSqhYi0RfPr/U2PY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=RnPeCjwV; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf30.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691572816; a=rsa-sha256; cv=none; b=cicYP+lvia5l7ooocah/816k7ljmr7OTbsHiRlPQ8Jjwmynk/FprMkM9qKDAWt2qIOFeQJ 2SWCrwmhWW+7HkSwKFIZwK5PXwd5WlzPIeT9VcIM5QGmHisNSpJi4GP/rpiWHote5Kf757 wH+fpOhj5ywoS83xNt7mfXtFhna5ZXw= Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37999gXY028908; Wed, 9 Aug 2023 09:20:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=Hc1lPSPlgK3uMeOacJXHg0IdjuxtqCC5DKCkms2sJaQ=; b=RnPeCjwV6852lGGqKsOw4QNDksBgEnEDuMAL7FrGZ55qNfMJc1e17uiIkA/8GnpoRI6c tvSg5/4Nr4byVgkuqFf/olk1PxjEtWPaKpUfv011akk/5a85N8bMFWEBgEPQYRhDXdQ8 SDo+K9RQLt2ceu5debBETYrZ1il0uQZWeVM9V2224COmWHok4U9GKuopFvn/m7wSPKVY oZvk1UAVM7I+TGkpaGpl45sKYd/UV6HkIa88Q6OHoiJjd4Zpc1Lb5iqXBmSFqHY6S7Yh 5rbsWlsAaC5u8O1la57T+FbGQz98F7MMuWaUgn99gZSDTrLJM2vPyMcj9r+lG92eH0an KQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sc7rqrh1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:20:03 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37999x6L031997; Wed, 9 Aug 2023 09:20:02 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sc7rqrh10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:20:02 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37981XO8006719; Wed, 9 Aug 2023 09:20:01 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sa0rt77hs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Aug 2023 09:20:01 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3799K1Db32440850 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 9 Aug 2023 09:20:01 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0156A58066; Wed, 9 Aug 2023 09:20:01 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A7CE25805B; Wed, 9 Aug 2023 09:19:58 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.109.212.144]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 9 Aug 2023 09:19:58 +0000 (GMT) X-Mailer: emacs 29.0.91 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Yang Yingliang , linux-mm@kvack.org Cc: david@redhat.com, osalvador@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yangyingliang@huawei.com Subject: Re: [PATCH -next] mm/memory_hotplug: fix error return code in add_memory_resource() In-Reply-To: <20230809081552.1351184-1-yangyingliang@huawei.com> References: <20230809081552.1351184-1-yangyingliang@huawei.com> Date: Wed, 09 Aug 2023 14:49:56 +0530 Message-ID: <871qgcd137.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: XyBOPzRM3IgycoFeNsjtqMX-5r1F-oL4 X-Proofpoint-ORIG-GUID: xTeGhBV-ys_x9CRX2YmmIcJzBKtbn36g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-09_07,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308090079 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BA77B80011 X-Stat-Signature: 56ztz8c67kkeqmmqtumdsf4sguh8fzz7 X-Rspam-User: X-HE-Tag: 1691572815-907155 X-HE-Meta: U2FsdGVkX18rYEh0naVPX2kpPMWN4L4HVt9u13R2U7h6i48N3yDArAf9mXYT73ucIjvvBEuQ1mGDiaEiqaAtf6ExbceKc0cyJtnkZgs6q6JtKKeov4CD+nrGBrX2cSK1KjvEwiyrbEkWe3roWj3T6ZoXs/NYpdA3tZ81Nyg5cIJKQCorttG7OxJGTUvh7uuCQpRqdnSJvpGbeg3P/07E7tWguQnlXbiivWAJPYjcJyysGWDImH9qHBthS/rFpWP6wHfFoYgZdyM2BkDxBUtLwvI3azq4OOKjf49geZTXZe2yn2BKlYx/tOX1iYIphM3MqU5EhD13aIedsynh1qDiUg3swemPQf3D7AIv5K5YeCt9gAStY4ASFqn/ddQBPp9fXLGgDgj4EFZ5C1o2XxmQu1d/XBoG4/h9+tadRnrM6c+ZSqnchp/OKqAskCKytxB8Ldsk9IhTvxbfBkS9VeCeIhu8hWLc3Mi3NQRi/9Aft7g+414g1jg+6ApgWbe1XN8siNqkEcNrVTUQ6PQcvy6vO6C8mvuDARVH2EfS2y4I4Gf6PmCzhaaXObOMY79zF6qrvi9AA8LI2u1zCrUKNHEtR60kEOmtmvijQYOyrCgm91OF1u8hvDN3uqmv/GX4iAd5M5i6ALfVXTzudII1f2TAGvTgrlHia9VKrWBSYDAHu4vM4wvK2BM48E2XWIrc9MBkhiib2KkcAEyDB3TTNoGKyVtkd0q2Pdm3smGxJBGNEXnO1js5hfJz1LFoQN5/sutihfGXoFr08PPNYwgqyndqMrQ8qwhGq3J3KT8JpPD9uAQgbcj4ERUg9euh6gm5nB2euQin4OkoY3RcvjLQPwCoqNR4/ax+PcGicMy2mzdDqSt9sHs7r0mAgjyshMD4+eF7lJGpW2kScc5Dp43v8tcJgCEiXAYF5Ys8dtsyUSZywyU8M/9CB94DHXmaRwmOK5BYpJi8AtgZRAmWR6qHUY0 d+j3EEvB vFGu6QBSd5NhpkzqipsnX0qbTbkTBJ6BJ7v716X6wx/b7ptGzdhC3JZMEA7zHJbIlc0Y5hQJ2mMkBm0vj5Bzf2+RLvpNPmgLqwUR3G+2x79wI+By0RGXqjC36VifcWPk/btRYVPkZ+Z3L1vfh1tNbRIAb5sHWCWGiwEoji4u5+0hVHRbGPceIn63egjGr6pLi+BbAvBZBlVavbMDNRUG8jbNzuJBb2a/UT1zCCuXZ9w23h30wsPe5d5Y37v3ug05L6g+FxXcBG8thXK4fKM9LiQtXjfcXbABVUoMZKDNCGhfYjJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yang Yingliang writes: > Set error return code to -ENOMEM, when kmalloc() fails. > > Fixes: ad3232df3e41 ("mm/memory_hotplug: embed vmem_altmap details in memory block") > Signed-off-by: Yang Yingliang Reviewed-by: Aneesh Kumar K.V > --- > mm/memory_hotplug.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index f8d3e7427e32..1b03f4ec6fd2 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1440,8 +1440,10 @@ int __ref add_memory_resource(int nid, struct resource *res, mhp_t mhp_flags) > if (mhp_supports_memmap_on_memory(size)) { > mhp_altmap.free = memory_block_memmap_on_memory_pages(); > params.altmap = kmalloc(sizeof(struct vmem_altmap), GFP_KERNEL); > - if (!params.altmap) > + if (!params.altmap) { > + ret = -ENOMEM; > goto error; > + } > > memcpy(params.altmap, &mhp_altmap, sizeof(mhp_altmap)); > } > -- > 2.25.1