From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB37CDB47E for ; Wed, 18 Oct 2023 18:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 916478D0187; Wed, 18 Oct 2023 14:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C5DB8D0016; Wed, 18 Oct 2023 14:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78DA78D0187; Wed, 18 Oct 2023 14:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6993E8D0016 for ; Wed, 18 Oct 2023 14:48:08 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4300D1CBDA6 for ; Wed, 18 Oct 2023 18:48:08 +0000 (UTC) X-FDA: 81359467056.01.949CE66 Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by imf15.hostedemail.com (Postfix) with ESMTP id 453B7A000B for ; Wed, 18 Oct 2023 18:48:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of whitebox@nefkom.net designates 212.18.0.9 as permitted sender) smtp.mailfrom=whitebox@nefkom.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697654885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mIDpBnnjD1WunlaGc4O6AwQ6sW5R9u3+ry9UKNGNwYk=; b=2AahSncZCTubptmU4e6YNyR89Xu7zCe/guYRl+FPwUBas3FpMzjhjLiaKlgF7jHd/E2aB7 rZA25N05KDA9AaFbZhFhqp0jBuZ/clVt2GoKc32Vn4Kqjso0MrbB/yttresqNDgQ3B5p4W WMCegFoeiH7k+6x3MIAKwcy8n3nJCq8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of whitebox@nefkom.net designates 212.18.0.9 as permitted sender) smtp.mailfrom=whitebox@nefkom.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697654885; a=rsa-sha256; cv=none; b=utbjseherBSyj/HhX1s6EwQB/oYZHI5ukmuS7mvZ6zIWn8yjT3niujgqvmCC/r8p45fPhb fAwBw3IgP+QsxeY0l17SXa7mRXukP2fxFREKABpbiLndnxYJtkJU6Ru8CCGyKnOCQaY1rq brcoT1dCjQ/K+wSUXXbDEs40xQUem5o= Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4S9fxD6sb1z1r1fc; Wed, 18 Oct 2023 20:48:00 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4S9fxD5Pq3z1qqlS; Wed, 18 Oct 2023 20:48:00 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id yVsnDci_gSYG; Wed, 18 Oct 2023 20:47:59 +0200 (CEST) X-Auth-Info: z53x+HAGnC5Mr85hNarHhEetogq4Juc1fsSdAKqHPeyff1cH7hkefuC/L5r3bMDv Received: from igel.home (aftr-62-216-205-223.dynamic.mnet-online.de [62.216.205.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 18 Oct 2023 20:47:59 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id C38602C1354; Wed, 18 Oct 2023 20:47:58 +0200 (CEST) From: Andreas Schwab To: Charlie Jenkins Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman , Kees Cook , Paul Walmsley , Palmer Dabbelt , Albert Ou Subject: Re: [PATCH v4 1/2] riscv: Add remaining module relocations In-Reply-To: <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> (Charlie Jenkins's message of "Tue, 17 Oct 2023 22:34:16 -0700") References: <20231017-module_relocations-v4-0-937f5ef316f0@rivosinc.com> <20231017-module_relocations-v4-1-937f5ef316f0@rivosinc.com> X-Yow: I am having FUN... I wonder if it's NET FUN or GROSS FUN? Date: Wed, 18 Oct 2023 20:47:58 +0200 Message-ID: <871qdr938h.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 453B7A000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: a75d579hcpdoickrg13ejp1gphcsqrzo X-HE-Tag: 1697654884-41318 X-HE-Meta: U2FsdGVkX1/yzV25oPYM0RG735gvfCw0Oti6Har67NXG2cTq8PkC73C3Phmbl2G9W6NqE4+ZSPUTl72A71KEUbHef9Y/NhPmBhhQFUqQ3XTKGCrbeJiH+DDctzOY0Judy5MIuKZVYsF5ACwDau/eN/w+qxkgwitTwJbWda3sl2x9xjkd5rUipByKG//nTHcpM5shgznxdmoMRZjtA/L7tsSK3Au6QXPeo7gQUiN90PKe3o+iE2ZfxVveJESs5TW7OSSpaNHB00ZvThgdF1DEXLaT3ZtePbWLdTam9skcGo+4z0JRHbx6LvjewlJCE28+c5IpvGKXJBmer2p7fcndRFyx5Qs/ZOxJa5RsU/EYV9ahStCsPifa6jFg9TZesTt2vAopFVMDDo63od1yzQidET4Nq153sRglRrs1f7is14PSmGbp5NGgO08wShu+Vz4QW2w1/V8hDL1ZNrhK5clFgJfxAzpN/ycl9vQ2wdPDXCYXavKDz+9JxuUBDWPu+hFoyZZkzOj/ev0am64I2CakfxsMcfUrzKS/RJm5qy0TD37I778RTIL/4Ofcccb9aT9SkOwjL61OO5+zhVBOXOZF7XDxqEsFHKpvEW6FmWN4m5493pY/MtifMVj2A4SF3+6a4bJF6CIKLq5AmtuBMCpK53JsTSFPls2LGr18p70+G6zJVNzOKvv14j54OTv7G7Ug5QgOpz5Lm8gcqqwT38hNV7s9TOvDp1lU5sNFv+eyyOGljtvpp2nasZYVvyMRegx4004jMUykpLQwKpB9u20eG+ZVf6A49U+dCIBxlI2Qsw4S3oBrpAO/I/NmatZcw3cqz7Vhc0cgxrBWoBQt6UG+KTXxGHOzFgGxAj45sIifmNYkAE3maWz4E87TDA8nmh/t1LbtUhQN3HjE7CKw009rLlItvmjOKPUTd9XMtqB30kpbK8VxMICCL1qcQNib2YtrkYHQHcj7ESfpk3EIGjH FVlRJWrd 8qD7scqyjlkSLB7jg9CFZSdvRPxosmjiK/h9eSxe/tkLiIeTezzRQtGajIbEzns0UOX5L0ExUFPb3gKzvxeHujweYZ3iUlxjzuJRpqFDhTstFNJ0IqjjKCuwVP0cvyGjUckyD14cyeai/sBIO+x2/IM3iajzZ4BjQ+Jhcthss6j8CVvHZSS7iwGb5buGBwuOllu9SvDw5/BBgpUy698+FND5Amy2dVRROSMBDf8C/EpnslAvBLl2aTeR2zGJqOUtRtmcqzR9p9If9sKjHEIC8w+qH7ERwvY1XnikK9ZG5L60zE+sBHotYozaSNw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.171531, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Okt 17 2023, Charlie Jenkins wrote: > +static int apply_r_riscv_sub6_rela(struct module *me, u32 *location, Elf_Addr v) > +{ > + *(u8 *)location = (*location - ((u8)v & 0x3F)) & 0x3F; I think that should use *(u8*) on both sides. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."