From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C42C4167D for ; Tue, 14 Nov 2023 01:14:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6154A6B017A; Mon, 13 Nov 2023 20:14:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C4876B017B; Mon, 13 Nov 2023 20:14:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DAD76B017C; Mon, 13 Nov 2023 20:14:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3F4766B017A for ; Mon, 13 Nov 2023 20:14:13 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 11111B5A6E for ; Tue, 14 Nov 2023 01:14:13 +0000 (UTC) X-FDA: 81454788786.18.0CA42C3 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf27.hostedemail.com (Postfix) with ESMTP id E916D40014 for ; Tue, 14 Nov 2023 01:14:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gTVfoBY5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699924451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AlaeHmXQXclZdBBHdFffxsjtELUaod+chmdXe9eYaec=; b=Vq4l2iamWZqvthIDpV2tty3MfJHxfOEbIzH2At4v3KG0KBYQtHclauQPsEynOOMng/xQtE iuUtJnhkdQXpQOgj2W4G4WIqZrXX7bH+ESxhO/2QuPpzGP00/artN6NzDMiAu8F1BiuRWZ Jjdx8lolxjmiDDCBSbJj1OQBtmxQ+ek= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gTVfoBY5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699924451; a=rsa-sha256; cv=none; b=Nh/ybiz8pxgxST/PO8nw/wPd3kllbPXiONsoyPOu+/B0GYN+PqUk2APZpg48VvdTm1du5E eQ0/KYdN1suyl9xzKtHFmR7nPvMVh6A4DhYJdOcXwLcsmr2sTpoyyufCjCJiKM3MD7yAcP f9wUTMbF3js6vpDysxTJGJZYu0PTecU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699924451; x=1731460451; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=oQJpuKDOhuR/4NqGomdXErid0IdxtIX2pZNk0d/K/XQ=; b=gTVfoBY5Sz7ho5HVT9IDMdRxY08kJCfwnfGye7l4AqjBtucM6rWudA0M 3h9SijBHvsAfveuPfKpC3Jw8lxd67MuKNHqO/zevZWpzaQbts1sZydJ7N 2+/9rqw9RDrGBzK2GFwBsulCBQQzabFdcDKMzWjnZ92d+K+ApO3mDXx0q jS+ZhmA5bvsWTpAySb56H+CPVrAcBhnaTxkhYvSfwzBaMXIhGmll7xp38 ey174kj4xLu1bqa8kcdg3V5jRpaMm4c/5t4ipiaxMxKifK3RXuKQDT/vG UjNjd984xXuO9IGj3hkE5GguolIycymDxZt8XxZpnrnUkYDtzjrNU1WG8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="387704498" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="387704498" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 17:14:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10893"; a="768080707" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="768080707" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 17:14:06 -0800 From: "Huang, Ying" To: Baolin Wang , David Hildenbrand Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, John Hubbard , Mel Gorman , Peter Zijlstra Subject: Re: [RFC PATCH] mm: support large folio numa balancing In-Reply-To: <606d2d7a-d937-4ffe-a6f2-dfe3ae5a0c91@redhat.com> (David Hildenbrand's message of "Mon, 13 Nov 2023 11:53:12 +0100") References: <606d2d7a-d937-4ffe-a6f2-dfe3ae5a0c91@redhat.com> Date: Tue, 14 Nov 2023 09:12:05 +0800 Message-ID: <871qctf89m.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Stat-Signature: afdqn14t7g6r3wzs3ijnqhjo8eaeashq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E916D40014 X-HE-Tag: 1699924450-81811 X-HE-Meta: U2FsdGVkX1/dw+ayN4k2a8nwTOW58oSdZ1Pha5sfxaMVp+ATDwd9MKSxhZwi+QkLi++4bYOpjO2sKGs9xg4fMGG57G5M7jvxj2aKM8QsM2BSgxhQOPUHe7HwIs/j/fuG8Wzb1MmvoyA9s+LNhv++9xKew4hHmTCf24EqCmeXzR3bOV9p04/iftuVQZfSa3yoyGJ0EQWL0zC58jVzwcIxBtvohP8Y7Xr/4LmNUYAF6rBsB9abMhWxSugEjf+E4UDx1J81tb4mXGPQsyvbo34rnG/39zh4tbazpkyLnB7cKY8auWrwe5ExBIHsWNAKtt3jQCyqD68VxbHk1VHLoByTNy9tUdScXYP0TpRrOWF+1VWi/agB35F7KWe+hCUz8XD10lfAntBkmrMn8fkKRYApyRcR3Kf01R0UVklQSxHNY8zcPBiJMzrFtBDb9GDMMYE3xbJS1nlatJmRfLDOF0AtkiaRldKaDH1+kBeDsHmdwL8Lku7E8OHBYQclEWzajWVIbCCN+2dmV0aHC+9znf3htK24Tx9gist9WYKgvKc5hHxWWnzql6A/NBY9OtUwfSO6cKij9cuugR/2nBgMGRwONLHM0bg1uIWJ57ple1tM0lCq97F/N4DcvB+TSEb8YK2Zt6rzx0P3NtBcfeB95Jg0svA2YeoxfpQs+6ETiiiHLAis9gmWIE7DNFcBaUvolE8GtoA/s05vUTZWc6Zh2wD3E9JyI+34JruqlaUAV1l5u8j0Utdh3tM+qOgJvYuOTyZqh3PNfHtav2iImWT8K7y3W2mrsf4I6EIbnV1B9m0ZB3ucsjzOg11u0olva0F/BtGu9ZPll/PgRphME3zeWqVi7mXKigxV3WFvSmj/hFQwARbCpWOki1C6qhIhJsEd7c1ASJ0gz+7e/YagH+bNHHnXCfF0y+3eCPj5kO96o4Y7HXbITN0PbhIzrjoBVb1pOicZ856YDFJM+/xE1rDjr6K m2SrnZtC ukf6IHUQcMsKv0bxZrqUFXOLVQxOshEk4Lks/K1WExJfR0NqV0a9FDn/eLKg/KjgGwCcAkMAzQBIqpSsY7dlI6bgKV/3nmnp27TBbAPC7n0iKCTE91BGLmljmlvH7zz4UXR22++QSkgCEaB2JCAWVyiEyaaD8aWuMAxzWEDZq45KA51PNBCvTt1pcy0FyxdBMrPFn6vZcgegsrsMa6avJSEl8qQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 13.11.23 11:45, Baolin Wang wrote: >> Currently, the file pages already support large folio, and supporting for >> anonymous pages is also under discussion[1]. Moreover, the numa balancing >> code are converted to use a folio by previous thread[2], and the migrate_pages >> function also already supports the large folio migration. >> So now I did not see any reason to continue restricting NUMA >> balancing for >> large folio. > > I recall John wanted to look into that. CCing him. > > I'll note that the "head page mapcount" heuristic to detect sharers will > now strike on the PTE path and make us believe that a large folios is > exclusive, although it isn't. Even 4k folio may be shared by multiple processes/threads. So, numa balancing uses a multi-stage node selection algorithm (mostly implemented in should_numa_migrate_memory()) to identify shared folios. I think that the algorithm needs to be adjusted for PTE mapped large folio for shared folios. And, as a performance improvement patch, some performance data needs to be provided. And, the effect of shared folio detection needs to be tested too. -- Best Regards, Huang, Ying