From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1F8C48BC3 for ; Tue, 20 Feb 2024 03:44:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 407AC6B0082; Mon, 19 Feb 2024 22:44:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B7CF6B0083; Mon, 19 Feb 2024 22:44:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27EC96B0085; Mon, 19 Feb 2024 22:44:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 17B2B6B0082 for ; Mon, 19 Feb 2024 22:44:36 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CCF75803C7 for ; Tue, 20 Feb 2024 03:44:35 +0000 (UTC) X-FDA: 81810790110.05.CF5D0FA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf21.hostedemail.com (Postfix) with ESMTP id AD0F71C0008 for ; Tue, 20 Feb 2024 03:44:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E7HJw+XE; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708400674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WZOMFzFt3yXQ4Glv6lMv3YAgc93EEwfKopVi+OsXkMk=; b=A7Ql11C79pcsOfaIbBs84lkb3OHaz20xYeY3YIzxFnpaPYlgix9gsfzcAJ1UIYrfV+/ePq bCxXZHp8QpZ6JmKNNmmo3/R3Cl2jST1wy7apVRxdzELSwSyMwXyI/5CnRocONhzXaDVhfH DW9NsgkTghD3qtCZS9TDycbmSVFn1ww= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708400674; a=rsa-sha256; cv=none; b=J9/fCYKeC463/zXxSQdnU7OYKgK5ZV1dX85kjq6ksQkoE7J5r7VcwzD7/UPVfrYKTDuQQR zhtr+KHvi7VD2hNZtQjRXloqEbBu8rvKD+zeQoyuZVoMRwGmYlvI/pjCgqumqB4wNfHmlO wqdD6aKypngqdpH6zVnYPs+MbfLD4tw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E7HJw+XE; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708400674; x=1739936674; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=s0pIo5DSPJMtUCiPNiZk1cDWJiQ2gwkCboeixgJnEIo=; b=E7HJw+XEFnr3JiKQFhZ2GYnuiq8Ozso8TZfx6BvGteonYIXPSqITFdP5 Emgy6tK72bL0prei9ocD+hau3ym5lWMWvPdc1WulgbCnLRiTY4GbSJo5o Rb10WrrlBeOhJ6aojcoIXLjDIkuSkAeBlz9hkOaJjZEqWiNCAG2bD0cdx XQhd+kDtlCmAqlvLKb9B/E43If/gUioMGN2zM5veN9pAmsinc+YhMaJ11 /hiuYnOZ/C0AbKqvoeSLNpAUgCGqLDQrHYZAPRaOcMzHaksUCY7bRFQGn BiPA4ZPCkw7ZfnheCllKoNTZpEfBhCIkWJswdvVS7IhEJgZxHM6A3Nl0X g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2363950" X-IronPort-AV: E=Sophos;i="6.06,171,1705392000"; d="scan'208";a="2363950" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 19:44:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,171,1705392000"; d="scan'208";a="4949946" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 19:44:28 -0800 From: "Huang, Ying" To: Byungchul Park Cc: , , , , , , , Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index In-Reply-To: <20240216111502.79759-1-byungchul@sk.com> (Byungchul Park's message of "Fri, 16 Feb 2024 20:15:02 +0900") References: <20240216111502.79759-1-byungchul@sk.com> Date: Tue, 20 Feb 2024 11:42:31 +0800 Message-ID: <871q97rec8.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: g7azcg7dzry89i8xj8j1xn7agaxdwk76 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AD0F71C0008 X-Rspam-User: X-HE-Tag: 1708400673-473235 X-HE-Meta: U2FsdGVkX18iXz137XBVZWPJpzkQ1NzWBkU2X71pSxrFSLaYMYqZUtwu4+PDlhg6vYUT2RPJAAMulVNV6K+d6rfLbwxsIRe1W5v+rH45tcpTfYuoBjDmsmdQqMH8dzVgJg/TCLuZMzHyWRXtuI07wXF5EQ9KPWNerP8KMpvgBfd/9ZPyCN5LzpmRp5ltbn3yLTIXV7qSA/KLAdcRSXIqcFB6oUxHeueTAx4KDeWTLs7qMQu+ZXTM+q+jjlCs0TNr4WKqCrILUP2SSogwzGXqgB+wPcp3gDBlr74hL5zjfGFFEWnI/mDcoaMpg1c01Vhh3IoOzI+A/8m3ghJLIpuWAt9g5YRwJGS/rEP3bj3iY/TJH/Eoh6bhnvs6d29mMin3RJJda5cIh0mjIBevM7ytXLOLiOu/cH1OsUFLh9pqdGEtCiPQCW+EVbf/SBX/ZZjmBVQEOtKWxVfFb0PM+unEX83RN+wCPiGgvTU5vXEvSGDeKoZRgsLLB8ke/2nN3K58g2CW3E7DVs20CFF5VKrf0Hx4ow0oCJEypFrYaLfD4A848nbJKDqmLlKnaszTQDG/3dm4Bm6GVuA/O4D6gPMcm4TnuEioyf/ChoA3YzsZ+/IFr+Q7vFjs+s8QW31gXOQ+eOFZ1I/l6T8kTImmZZkVqA34GA0hKkGvHQHRhh9b+IH5evAqxBeBvnlp3nqi1FIxqMhrcksdGNd8q8lL6nKkuV8yIxVhE5vdiCpS6XVdUYF3OeTlhuwK5549jQkJRu4MxqnwKc2alsXzfLTLRMm3e/+hQG5ZhJGjH4a1OTP5foFnGT2N8U2JFqUXT5Q/yl6PN7nOgj0JopChri18iUokrm8UBl7hg5rULP/qsBZ9rWPCCQmAQcxERobWeS+MNgFU72t0Hq2qmu0zy/a50Ej6eG/PgxOwewJiqneDmYFh5t9Bk8QZMpIlp54Y480jqDHdSpcQz0LLJAkbrI1/YjN Pl0QdbNB 0+3iX6tHJgW5Yk8qnKiloLFBCSDjXbrXoMnO71Nc8AyQqrlo0f0z0RVIcYk8UW9JDBIJPoQ1b8fpMuseeyVZCSVgcHa5PPNKwmJ3uVGbAhweE+TPeNOOVTvNyg0ZpIRmnLdhYau4Y0iDXXUloNVegQ9eq07ZnTK4GI61uPgWNRSfOPcCvJDHR46Jc4pObiRmGg9Zj/cXtFJal6eY2R3jX/BpgVo7K1crm8IDZv2RRy3quaJZR+AfhxlJDG6LES1ufasw0tKDVU/684L5MK9vGb4cZokwt478KXILMdYxANtBLF90reo2kdzu4DJjICXkqB3uOS6CcCH8BtmKqdB6rvuFVGfKDusKM1wKucRX2MvSwNr+pnc2Qz0WCAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > With numa balancing on, when a numa system is running where a numa node > doesn't have its local memory so it has no managed zones, the following > oops has been observed. It's because wakeup_kswapd() is called with a > wrong zone index, -1. Fixed it by checking the index before calling > wakeup_kswapd(). > >> BUG: unable to handle page fault for address: 00000000000033f3 >> #PF: supervisor read access in kernel mode >> #PF: error_code(0x0000) - not-present page >> PGD 0 P4D 0 >> Oops: 0000 [#1] PREEMPT SMP NOPTI >> CPU: 2 PID: 895 Comm: masim Not tainted 6.6.0-dirty #255 >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS >> rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 >> RIP: 0010:wakeup_kswapd (./linux/mm/vmscan.c:7812) >> Code: (omitted) >> RSP: 0000:ffffc90004257d58 EFLAGS: 00010286 >> RAX: ffffffffffffffff RBX: ffff88883fff0480 RCX: 0000000000000003 >> RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff88883fff0480 >> RBP: ffffffffffffffff R08: ff0003ffffffffff R09: ffffffffffffffff >> R10: ffff888106c95540 R11: 0000000055555554 R12: 0000000000000003 >> R13: 0000000000000000 R14: 0000000000000000 R15: ffff88883fff0940 >> FS: 00007fc4b8124740(0000) GS:ffff888827c00000(0000) knlGS:0000000000000000 >> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 00000000000033f3 CR3: 000000026cc08004 CR4: 0000000000770ee0 >> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >> PKRU: 55555554 >> Call Trace: >> >> ? __die >> ? page_fault_oops >> ? __pte_offset_map_lock >> ? exc_page_fault >> ? asm_exc_page_fault >> ? wakeup_kswapd >> migrate_misplaced_page >> __handle_mm_fault >> handle_mm_fault >> do_user_addr_fault >> exc_page_fault >> asm_exc_page_fault >> RIP: 0033:0x55b897ba0808 >> Code: (omitted) >> RSP: 002b:00007ffeefa821a0 EFLAGS: 00010287 >> RAX: 000055b89983acd0 RBX: 00007ffeefa823f8 RCX: 000055b89983acd0 >> RDX: 00007fc2f8122010 RSI: 0000000000020000 RDI: 000055b89983acd0 >> RBP: 00007ffeefa821a0 R08: 0000000000000037 R09: 0000000000000075 >> R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000000 >> R13: 00007ffeefa82410 R14: 000055b897ba5dd8 R15: 00007fc4b8340000 >> > > Signed-off-by: Byungchul Park > Reported-by: Hyeongtak Ji > Cc: stable@vger.kernel.org > Fixes: c574bbe917036 ("NUMA balancing: optimize page placement for memory tiering system") > --- > mm/migrate.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index fbc8586ed735..51ee6865b0f6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2825,6 +2825,14 @@ static int numamigrate_isolate_folio(pg_data_t *pgdat, struct folio *folio) > if (managed_zone(pgdat->node_zones + z)) > break; > } > + > + /* > + * If there are no managed zones, it should not proceed > + * further. > + */ > + if (z < 0) > + return 0; > + I think that it's better to check pgdat->nr_zones directly earlier in the function. That is a little easier to be understood. > wakeup_kswapd(pgdat->node_zones + z, 0, > folio_order(folio), ZONE_MOVABLE); > return 0; -- Best Regards, Huang, Ying