From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C2E9CEBF72 for ; Mon, 30 Sep 2024 20:11:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1EA280028; Mon, 30 Sep 2024 16:11:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55184280025; Mon, 30 Sep 2024 16:11:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41946280028; Mon, 30 Sep 2024 16:11:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 236EA280025 for ; Mon, 30 Sep 2024 16:11:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA845160B43 for ; Mon, 30 Sep 2024 20:11:09 +0000 (UTC) X-FDA: 82622498658.01.8DB7DCF Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf05.hostedemail.com (Postfix) with ESMTP id 52EF3100008 for ; Mon, 30 Sep 2024 20:11:07 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727727028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=16wgqX3QeEVfNDAe/n90GmLOm3v9Aejvw0xD7oxZ77E=; b=yFo882rEh2GIKBSHnF1TqxAUTmDnviU7EdorGjvnF31+B1pZvXYuwYPM6NUHCl63uxnEjL DaG7IPRujHFw9DmTS440M9us+ywh2+q7T/N+PizfLlT79PYWJ3gkjAH/Qxg5irZzuFS2uV dnqU4F4bEEI2NGoSZnWjpxOiHrU9zIs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727727028; a=rsa-sha256; cv=none; b=YGWvxxym/YxJpSj1FVoZIaKna5b6PNgCFIg06pcLkBUfr1wcmdb59wKMWyYydRkbXmbtgQ VGxsuLtllI/4LnjIOW7KDDaXRBbWljveBJ6lqQyJ2n0mxmr/ewSSNMaDSZcrYiPxQ4NXZb Zuojj0/1DtZ3UBeSw16lGWT9p14l1zk= Received: from in01.mta.xmission.com ([166.70.13.51]:40336) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1svMjY-00FenK-1S; Mon, 30 Sep 2024 14:11:04 -0600 Received: from ip68-227-165-127.om.om.cox.net ([68.227.165.127]:60936 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1svMjX-00GHAt-4e; Mon, 30 Sep 2024 14:11:03 -0600 From: "Eric W. Biederman" To: Kees Cook Cc: Tycho Andersen , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen , Zbigniew =?utf-8?Q?J=C4=99drzejewski-S?= =?utf-8?Q?zmek?= , Aleksa Sarai References: <20240927151746.391931-1-tycho@tycho.pizza> <87ikuhw155.fsf@email.froward.int.ebiederm.org> <202409281453.B9B9999D@keescook> <87bk05vobx.fsf@email.froward.int.ebiederm.org> Date: Mon, 30 Sep 2024 15:10:29 -0500 In-Reply-To: <87bk05vobx.fsf@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Sun, 29 Sep 2024 21:59:30 -0500") Message-ID: <871q10vr62.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1svMjX-00GHAt-4e;;;mid=<871q10vr62.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.165.127;;;frm=ebiederm@xmission.com;;;spf=pass X-XM-AID: U2FsdGVkX1+saTEKwt+JRZ60ZDFuo0pZti0glltWxMo= Subject: Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm X-SA-Exim-Connect-IP: 166.70.13.51 X-SA-Exim-Rcpt-To: cyphar@cyphar.com, zbyszek@in.waw.pl, tandersen@netflix.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, viro@zeniv.linux.org.uk, tycho@tycho.pizza, kees@kernel.org X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out02.mta.xmission.com); SAEximRunCond expanded to false X-Rspam-User: X-Stat-Signature: edqzp943qry3sedm6b7bkm4br49rdsta X-Rspamd-Queue-Id: 52EF3100008 X-Rspamd-Server: rspam11 X-HE-Tag: 1727727067-411516 X-HE-Meta: U2FsdGVkX18TCbYr/dvNUb1E71DRAGrMdMnXycCs8ok5/0/VErqObjK0MXkF06Xo8mfFQ500E66H71+qG1xSF1YkejqOwkhHvaA0f5Pa/5A0x8VJqsNp94FDhSy8z6hycFZXH3jZGMLMoRrMh1o2CNk1iNV5QDleMeX75iBRACtymy0NWTJP+ODzyAiCQ3iqp2v/Jtv3u5GwLHJa8wXlaJLs5NJQ2imrP1OiciFzXkfDnM0Gvhmu3rMLUD51ApjynzELX7m7zF4tJkQlQ5IP+B1WRIJitTOjyoV4YGfT8sVI71pwMZ2Oejcp+VivaR0rBBiESIoi97VCCzh0YUda4xU1fW77cwbE/0eXX5yFMgMiSLHBY+3bR2TOjDqSX1tY/aUGBiMdIQ017l3wCgod9lHG0Y81DIs8gUd2VuWQDhtze6HmZt1XYjGn7w5Q0+wMOhrJVI7W9PWjna0OO9KalSWRQgy/2xy6vhTzXf3E4whOLiqcU90Pj2chaGNtWkSVFBMDEvVZVgQirSUxhD0hwl0+v043BWw1WRX2KspTOjP9uazoK+sMRHKVf8MPE8r5mM6ly6d0g0AMkseu4lvU/Gu8ZOMhQ5YfhIOHQ8IQ7ui5q9NMxy7VsjZaJUNUL8ZMs/GhJH2QNgKol+4GnNNm0Xnp18LgZVHgXmQIuJIyjcBK4tCfRdYM49iQHFH7dHdX59Ml+cn6gGpO9NLoDQWg7xH93L12ujPvD+n/lgt5mkpBXW9GcLyXXo+HBsbMyd9WUPQ0dMiTftNIIaJPjCs4J0kzNHi+KXzdQrNjf8/XQAHeswHE9MnaUsTrRwKYKKPRzSJNX+RO6pBfLCGrKI3jS2ou7Nbf7AloHLpA5Q06Q5jpZHxfC1awujI7MOb7+VNt2rwFbiA+cy9f2Uf9uK8h8uvxFYanigUBol0kaI29Wuj3z8wuR2iDhIBmGX9PWfTKhhwg5eRFHj5dLNBDZVW pT2vwEAG BX2ez5xRujGl14FzwF2w2EHMCRkHtIHGH+a7Wud3kokR/+j5X4aYewDbYwpMquJ6Leez6oEN90WvwkJacLCdiybMF9fpdAVAM3u1fHrgXb/iVd9U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Eric W. Biederman" writes: > Kees Cook writes: >> I'm not super comfortable doing this regardless of bprm->fdpath; that >> seems like too many cases getting changed. Can we just leave it as >> depending on bprm->fdpath? I was recommending that because I did not expect that there was any widespread usage of aliasing of binary names using symlinks. I realized today that on debian there are many aliases of binaries created with the /etc/alternatives mechanism. So there is much wider exposure to problems than I would have supposed. So I remove any objections to making the new code conditional on bprm->fdpath. Eric