From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A3DC5AD49 for ; Mon, 26 May 2025 08:17:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E91726B008A; Mon, 26 May 2025 04:17:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E696C6B008C; Mon, 26 May 2025 04:17:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6926B0092; Mon, 26 May 2025 04:17:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BB9E46B008A for ; Mon, 26 May 2025 04:17:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 58D5912041E for ; Mon, 26 May 2025 08:17:15 +0000 (UTC) X-FDA: 83484354030.16.49EEFE1 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf05.hostedemail.com (Postfix) with ESMTP id 74AE7100005 for ; Mon, 26 May 2025 08:17:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZzUiDgRV; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748247433; a=rsa-sha256; cv=none; b=PW0B2/GhuvozKQsLTjknTePSIlwEkdka552yt5Dnti/4PXi3MwwF90rta+NBm64hcgC7Jd QQEfc9lmFiyvn69fJmHXmvVPJO3ZsfoDq1L5CbBPL74jeEug1VpXfC1jkF6fJ08kFuJbY5 STArGi1hMdNLjqWmvKHGU+sS/7c6llA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZzUiDgRV; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748247433; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZfYIQZDZ3jae9SXir7MKTbFoTwWvnvk/F4s97c9ME2I=; b=r0sgyBjSnEO6WMl5fQWfQaW1R19HG/tHua6dl34/fDnAA21TZji5eelERyXYKGXNS1/s5M PLO6CNLBCSflH/txKXynRdmfcx6/lAANyRNPqVMDj2EsVoF5arm5ZR3Q7P3dzkYGiJ/v66 Qspst1ek9UC/kDMTsk+GJmYMne+svSM= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1748247429; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=ZfYIQZDZ3jae9SXir7MKTbFoTwWvnvk/F4s97c9ME2I=; b=ZzUiDgRVFb37RqPrnRvHiCPQNayaWNb+cW4Pku3+DqutojjjizpjwdNb4n+5OIkc5emHPPWCNMr+VlMTzJkEybRgzVt1StTBTo8FD4jNfVCgNKGJiXBbZR0Eo2tzjnx3ULysa8QKyYy7n2FCDAyHeDE8iOfHkEpgB4HH8yyIf5k= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WbmONlS_1748247416 cluster:ay36) by smtp.aliyun-inc.com; Mon, 26 May 2025 16:17:07 +0800 From: "Huang, Ying" To: Bharata B Rao , Cc: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v0 1/2] migrate: implement migrate_misplaced_folio_batch In-Reply-To: <20250521080238.209678-2-bharata@amd.com> (Bharata B. Rao's message of "Wed, 21 May 2025 13:32:37 +0530") References: <20250521080238.209678-1-bharata@amd.com> <20250521080238.209678-2-bharata@amd.com> Date: Mon, 26 May 2025 16:16:55 +0800 Message-ID: <871psbdbwo.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 74AE7100005 X-Stat-Signature: pnywofh7w7o115yzydaz97m1cyk7nqum X-Rspam-User: X-HE-Tag: 1748247432-696268 X-HE-Meta: U2FsdGVkX1+nGndJb1LlDltJIRNBstIDDkD82emE7ZYSKrTcKeDDsjjJcawfuipR57GhA2tHohoRVHvXpB5xWYZ4Sn7EzIAkALNeciwK3h0EcKJvxBz+yspo6eEdsVGXzRSWVGtJFDVljmcH1Xyya78qA4jz6lnZB54yt7D8T3j0oI4VFkKs/qd4nhd5FIRHDaPqKjP2EgiK6HW9f6xeLuu2kMt8pDU37yLBaQlYwVUhYTfmT/kX7oQZvb0yrDIpQ37kESb9cidlwRbnX1YWImHTrFOuR7tzgTfPn8OaKf0NMBJmYNaxOEulRaypIuR/oXqQbgurxoMc4Vr2x7GTEcLsOkN731bP2OYQY4RJ6HQjmAO1vPx/tEu50H+tq8h/hBWOLc5f7hnL5h/KgnMXERN8x6w2f9eF+tdMGozXXd04+x2ySB8BqH0tEZMNLNx+i5stbneyu8ZTBNruaHWzbthHhXHZ3ON1bPBBik3smOPMK1smCZ+p8aDqfUIEbtoky2Pk4zLJsCXe8IhXVvkxiIIJRqbCk8cN0FizjsclDkDp/xDKT8G/mQKTwITvHZlm/LXcrOLMvj94dBbkBpH72qCbhCyZcLofGWekYUD2t39r6Hf65Ggkf33Tm9rcEb0FN5SpMA9jyS04e5zUWRvXwge3F0bN3derCZR8k0IsETHYVWp6cuupv9jMPoGz8M/+wYBkmfcEa97UNlmMdWt/3Ao9/doovpOg5QTZDZbsVmaTPW3oe5S/juc5x3sTTkmjkrwgBtpa2L2hS8mo7i/GOkHw92tgjeNB9Ye2MydkcW1F8OX09wmje9XwajRSk4eA0oj1lyGrBFRn4EbvT+jXa1Wzu+88hzyGybmCDLPhk+sb+kbrwy7C+0Hnw6YHaI7AALGvEoZMBDtJeetbeFPr3uz50uCQZUWZDuZ8qEIEEyk3sWUGgG5w89yFl/6116Vl17iGnkj5/Thro5QvbOG g8L3cTYh KpYm3mIogbhJVQriciXtp0HKTrTI04us39H8Loe5BzgGyznFQNI+oFH1pbpUMnkh10NQ2huAyIX504cqIgsj5m3TLrApYGfabwsuVDhM4Hsg/J/RoELRCZ4ChEKw/l+xGQEhNXkwI1i1OaB4BPu8iTMt7a3qmCRQQZKPpoGjwzUbaD31BZSvnhiXrxh0NgWWj/pzpNiF378TVpkKxJy9BPrhQSoo3wjql1zyo8C3rA8cXJ6E03W5V6jxMzEXjffBOA0BElqo0qyWHnjXgopBimR6p6Vkv3RlJPMLw5086xwUA0XUaCR19NHOy4KzMbASLJHFIllmQX0FcjwUGeuYtmql4d9EgRnirWBvxhNLC7r1uaEiiIn1+k8EGVeU/MCuAoat8oXClAMwg4XWA1L7cBYU05EyN+Vs2u0NcbHs6dV78TNcxuWZIJPBvE5d1bV3QyupdDBe+v9CBTe5ddg8ldzRAyLhv8AQhP4dH1z5dX7HEq64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Bharata B Rao writes: > From: Gregory Price > > A common operation in tiering is to migrate multiple pages at once. > The migrate_misplaced_folio function requires one call for each > individual folio. Expose a batch-variant of the same call for use > when doing batch migrations. > > Signed-off-by: Gregory Price > Signed-off-by: Bharata B Rao > --- > include/linux/migrate.h | 6 ++++++ > mm/migrate.c | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 37 insertions(+) > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index aaa2114498d6..c9496adcf192 100644 > --- a/include/linux/migrate.h > +++ b/include/linux/migrate.h > @@ -145,6 +145,7 @@ const struct movable_operations *page_movable_ops(struct page *page) > int migrate_misplaced_folio_prepare(struct folio *folio, > struct vm_area_struct *vma, int node); > int migrate_misplaced_folio(struct folio *folio, int node); > +int migrate_misplaced_folio_batch(struct list_head *foliolist, int node); > #else > static inline int migrate_misplaced_folio_prepare(struct folio *folio, > struct vm_area_struct *vma, int node) > @@ -155,6 +156,11 @@ static inline int migrate_misplaced_folio(struct folio *folio, int node) > { > return -EAGAIN; /* can't migrate now */ > } > +static inline int migrate_misplaced_folio_batch(struct list_head *foliolist, > + int node) > +{ > + return -EAGAIN; /* can't migrate now */ > +} > #endif /* CONFIG_NUMA_BALANCING */ > > #ifdef CONFIG_MIGRATION > diff --git a/mm/migrate.c b/mm/migrate.c > index 676d9cfc7059..32cc2eafb037 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2733,5 +2733,36 @@ int migrate_misplaced_folio(struct folio *folio, int node) > BUG_ON(!list_empty(&migratepages)); > return nr_remaining ? -EAGAIN : 0; > } > + > +/* > + * Batch variant of migrate_misplaced_folio. Attempts to migrate > + * a folio list to the specified destination. > + * > + * Caller is expected to have isolated the folios by calling > + * migrate_misplaced_folio_prepare(), which will result in an > + * elevated reference count on the folio. > + * > + * This function will un-isolate the folios, dereference them, and > + * remove them from the list before returning. > + */ > +int migrate_misplaced_folio_batch(struct list_head *folio_list, int node) > +{ > + pg_data_t *pgdat = NODE_DATA(node); > + unsigned int nr_succeeded; > + int nr_remaining; > + > + nr_remaining = migrate_pages(folio_list, alloc_misplaced_dst_folio, > + NULL, node, MIGRATE_ASYNC, > + MR_NUMA_MISPLACED, &nr_succeeded); > + if (nr_remaining) > + putback_movable_pages(folio_list); > + > + if (nr_succeeded) { > + count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded); > + mod_node_page_state(pgdat, PGPROMOTE_SUCCESS, nr_succeeded); > + } > + BUG_ON(!list_empty(folio_list)); > + return nr_remaining ? -EAGAIN : 0; > +} > #endif /* CONFIG_NUMA_BALANCING */ > #endif /* CONFIG_NUMA */ migrate_misplaced_folio_batch() looks quite similar as migrate_misplaced_folio(), can we merge them? --- Best Regards, Huang, Ying