From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04ADFC5475B for ; Thu, 14 Mar 2024 10:26:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6945380096; Thu, 14 Mar 2024 06:26:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 643EC80073; Thu, 14 Mar 2024 06:26:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BE1380096; Thu, 14 Mar 2024 06:26:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3BDEE80073 for ; Thu, 14 Mar 2024 06:26:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D9B3EA1B1C for ; Thu, 14 Mar 2024 10:26:51 +0000 (UTC) X-FDA: 81895266222.11.C376EE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id D667940009 for ; Thu, 14 Mar 2024 10:26:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SP9h2h42; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710412009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VceHz9tnflHoTdK1aRS1c1t+57oaGQPxLdMIKGoUzM0=; b=rPfXDX1XixnOoPyqU5XXbRqHIGJJ6gOCmVHrMRhhaaNJvLkSyzlA1tE3B5lccRr9drvajl KkjuPA7BnKFshd1U1me3gDzqER2OckO9M9pri35o5zy6+lXaNuU53vPJBBOI8GRzTPCht6 38AlLwAZc9GDZIl5tPRjw5+2Eq6hO0M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SP9h2h42; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710412009; a=rsa-sha256; cv=none; b=Hj7gLfBpysMzYmfC8qFaj0v18Iytiw6/RRlbbOetVRkbdp9ZBrVhO4mzo5Qyww3VsMi1ky 3jonSzVGt+xHmarHoF60Cke+z14Fk+CjfNNRh69RAcC8c57lOUB9UnxXvOzdqZw/Tn8dTD cegqxtXFtAWR9MMVnXZ5BZ8F9mxOgl4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710412009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VceHz9tnflHoTdK1aRS1c1t+57oaGQPxLdMIKGoUzM0=; b=SP9h2h42xVtlE2TgD3kT/vgdPW/5/rgRUc17icjzqGprLbm1qvtsVwodea9zWxIJ4Fd1pJ WH21/vzEmUN52kENOis5BTagVDMknnK8VlWFcYYyK0Kn3QzU2j/EkyjtfDTEFBJbs4YP4i E7r2IMAaduDBhdzcE/AWSSeyuOPWa3A= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-160-rVn_T4RyPeSQJwoPCYzeJg-1; Thu, 14 Mar 2024 06:26:47 -0400 X-MC-Unique: rVn_T4RyPeSQJwoPCYzeJg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33eca6f6e4bso82235f8f.0 for ; Thu, 14 Mar 2024 03:26:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710412006; x=1711016806; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VceHz9tnflHoTdK1aRS1c1t+57oaGQPxLdMIKGoUzM0=; b=wjjm9/GtXXnktWaWWfRj/BC1IzWJUCNjp7I6ysR2hIo6lYxkDR55ERNdPt3aXp6MSj pxk3lRxF0AjHo0ZF1ZFf0xUPhTtwS7UeN4pD++rQfHfkRYMbUB7ZzheomDVe8hpJBffE 5KixnIvEOGMTZlzV73vJmtsNyN0Vhr80Nsk2ShtYxk4040oQ6QwAZ6lLSobBZjFBMvHA fJSJKiB2jv11R+3XX1fszTDcJdCGCKyty3+etgV2HOBpn5vBaRM53Cn+hEhOWPzPF07u fA5KARyJ/qwS4HfOjKojJ88vp8DQMPLdNmLKbWrfeXs1dArCGlAzUvKZT76/m6tmLLZV trkQ== X-Gm-Message-State: AOJu0YzLA/fNiQuNlI0uWTOln1HL55H5n+SSD3sJJKx118Dj2BXcz60s idzyWULd1VHZATinLzHn/D6/a+U/Y7WgJKw9A2Adyl8xAQrBrzWk5s8T1pHLElmfkL3tYmO0OD0 7MfVxv52iSWxS7uh9jUqRJ95eYa3+aIKyYjM9maUFFtteK9Oe X-Received: by 2002:a5d:4e11:0:b0:33e:7404:be91 with SMTP id p17-20020a5d4e11000000b0033e7404be91mr866663wrt.43.1710412006515; Thu, 14 Mar 2024 03:26:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQoCArQqbkaB4aAM1N9ODFMxa099A4yK2FAoMvgZB7mpFkLJ+W0/+pGzpRFrzesePcguMKsw== X-Received: by 2002:a5d:4e11:0:b0:33e:7404:be91 with SMTP id p17-20020a5d4e11000000b0033e7404be91mr866647wrt.43.1710412006005; Thu, 14 Mar 2024 03:26:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:a00:7d7d:3665:5fe4:7127? (p200300cbc7090a007d7d36655fe47127.dip0.t-ipconnect.de. [2003:cb:c709:a00:7d7d:3665:5fe4:7127]) by smtp.gmail.com with ESMTPSA id z5-20020a5d44c5000000b0033b87c2725csm408427wrr.104.2024.03.14.03.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 03:26:45 -0700 (PDT) Message-ID: <871f8712-11b4-487a-9457-2cd544089402@redhat.com> Date: Thu, 14 Mar 2024 11:26:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: Remove a call to compound_head() from is_page_hwpoison() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Oscar Salvador , Miaohe Lin References: <20240314012506.1600378-1-willy@infradead.org> <20240314012506.1600378-3-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240314012506.1600378-3-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D667940009 X-Stat-Signature: 1thw9p8kni9qkxpqhmoenti66unacsuf X-Rspam-User: X-HE-Tag: 1710412009-587677 X-HE-Meta: U2FsdGVkX1+p9Hr5cUBPvmEKTRR9Po4+jpBPbI0d3SX67KR6PbiUvA6F6+EFyRxS2/8GNWl6XGxYfbEELrYBBniV72xjk/dHYkqhx9ZyeYfXjfms+fzOHuh3X1br2q4e8plfXlWyevgjw4hxf7zWQlkvaAG2yKIGCax2o7eQmDNBaj2KfLbKCq2P1U/dsAMnNRCDmET2w2R3b+/OhujUQdVzXAmwdV+KkpFOxlK2omww2LCUO326kmHWvC0K2SV4nmc3CcuHj6PDEfXTYVGBG37RVasAMAKuMJfd3LPftPzczczNZ+onzSWwQCZirN1uglE/DlFqiIjd+UAEH9Im/6QOaE4MFZM7PhW4sYZQ7Un6WIzOtovMlMN3Gk+XO0CfuZ0LeX9vqFXw0IN0haHN+Cuvl5kDIw1RXNTShLN7CoNCX6W2Dpr2NpyTWHFq1JfgC7+b5z9oZMDdyoYelibra6P96UIOOcZKzkpEDnXd4EITSUl9nnyJofgnPUyr8rpICaZMcyTOTb/vh1BPfFMXMXf+mjvdoCEq2HIWj6q2LSobQruyXxWV2h9yQ2LMCyY+SjBbljxmzL9pcHa3kq5q4wt2mkthCRTduMh2/HUBIrQ6TsZNQ0r0gAzAb+abF5b7V54ymAyTq6MVnMRoX2XlTQC80nH3cIAzuls2qlFQvlS25T8MM9LEoJ3zQMX8Y/MTYSRKUeB4/5F0sjpO7CGhF8k/u94IV6W6tv3A3M45HBepfMBDGjQCeNKPgS9mDgKbgnW0vUURpKXGaEd1kU82P0/szaWboH43sjtkn/k6eL5G4ehK2VQPxM30JdWqkSBHtTq/xK30+OLEfQqPIcpRYbLP5NMhDz7PlU3mjj0hNIw9q+lavkgYYhlJowtCXGhjLepyzXY0yejIUkzbcvCVda3Fbublp8EMFOdHXOaJ5ug5xmn9vuxQlngufE6SbgGRbwQNsjR2jw7/dcDsgDL 4QKCnWmO NKoPCwdizGRDH0Od7pJn5b2Ooj22XIawLpBH/CgQiqYUUoc8ySNTvuoJyrOqJ5i8J+LM1/9DCSSFGWAm70qGYU6a8aWL+4vXDLmcPDhcNRtB5cAVfyjIfH/O2N3PbvmvqyGxc3p99wdgxPWNdHX+XXlhqGtSUMHoLqVpuFQMhVrFv0LcPUznpNjL7X3yDzPk2qEohCXiIHG6TBXFUN8ypCBt/mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.03.24 02:25, Matthew Wilcox (Oracle) wrote: > We can call it only once instead of twice. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/page-flags.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 6ebb573c7195..f1d65a72b378 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -1017,9 +1017,12 @@ static inline bool PageHuge(struct page *page) > */ > static inline bool is_page_hwpoison(struct page *page) > { > + struct folio *folio; > + > if (PageHWPoison(page)) > return true; > - return PageHuge(page) && PageHWPoison(compound_head(page)); > + folio = page_folio(page); > + return folio_test_hugetlb(folio) && PageHWPoison(&folio->page); > } > > extern bool is_free_buddy_page(struct page *page); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb