From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF4F3C433FE for ; Thu, 20 Oct 2022 08:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60F496B0071; Thu, 20 Oct 2022 04:31:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BF6E6B0073; Thu, 20 Oct 2022 04:31:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 487F66B0074; Thu, 20 Oct 2022 04:31:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 380396B0071 for ; Thu, 20 Oct 2022 04:31:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0B437C10E7 for ; Thu, 20 Oct 2022 08:31:57 +0000 (UTC) X-FDA: 80040659916.22.F5D7931 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 92D4216003E for ; Thu, 20 Oct 2022 08:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666254717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3l+iydm17a7yf04/2AxRgbGtzA4d4ED+DxN4tpd1g+E=; b=Ju6tVq7ZdSRkI/n4hIj0UgunxNGcf3NQo9UvCFWSy9aUVcPQ8HR8T6l6JlaeD7e7HoZS3s n7wqSrsj+wYESUFjHXgGS/0aqTAk9O3RQN3MhA2Sk/gBr/7Vs77mTlj0kgjIcrSJVRBOXF mzKz9rHRuFiO29IyRBgzd88mPfhOD00= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-564-N88z14pTMmqO9oJGN5-Lxg-1; Thu, 20 Oct 2022 04:31:55 -0400 X-MC-Unique: N88z14pTMmqO9oJGN5-Lxg-1 Received: by mail-wm1-f70.google.com with SMTP id t20-20020a7bc3d4000000b003c6bfea856aso749307wmj.1 for ; Thu, 20 Oct 2022 01:31:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3l+iydm17a7yf04/2AxRgbGtzA4d4ED+DxN4tpd1g+E=; b=S5Ozf+TYTxHkNZ1egoEs5giGQ/dXeHroUZBKHOZsQ4hmqQ/qIVBuTgOEWYxQTrmkB2 P6oRDO0TtkhwkrWFVY8+Aer4JD5cr29n71YLwW0dsL+ts3XUQ23W9EJ19NlWSY5Ee01s F7uPhOdRrweWqTnNS2mmd167s/gk4QtETtwnbZbqc1RpgFntus7aaDjqH32uTl2VfYLe F0ozWjx6TfMaX7HruakMiWXc9NVWl7ctZ5OU0SsKz/VCw1BxGQJkcvJqZ+IK303RCoV7 wD8Tg1tS61LZBD9cSLUcnSAacl0CESvNxSeX9XukQITrgTEk4bcZBGSkj1VW9aJbv11E Dnmg== X-Gm-Message-State: ACrzQf3hHj75MlTj9Y0Cj7Qg3DepkLlGS96679vuAPwEcZW+3oZuF4bn Zmk1sHqXDagdKUILWtFoZW7SIeNYIuiytZ8VmMTtoBCAYZtarXNuP3cZbrfN2D9i2kuk1i1lYg5 D6IdJuGaAWEM= X-Received: by 2002:a05:6000:1f0f:b0:234:eb90:cf91 with SMTP id bv15-20020a0560001f0f00b00234eb90cf91mr2582393wrb.192.1666254714489; Thu, 20 Oct 2022 01:31:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CT0c7LccgiyMRTUozWHzxPuNcoBK76s0z6AiCO/gINQBaWPDB8H8Xg9fUJLxFW4THIthjiA== X-Received: by 2002:a05:6000:1f0f:b0:234:eb90:cf91 with SMTP id bv15-20020a0560001f0f00b00234eb90cf91mr2582376wrb.192.1666254714140; Thu, 20 Oct 2022 01:31:54 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:b100:1443:78d5:341f:c97a? (p200300cbc708b100144378d5341fc97a.dip0.t-ipconnect.de. [2003:cb:c708:b100:1443:78d5:341f:c97a]) by smtp.gmail.com with ESMTPSA id d5-20020a056000114500b0022b014fb0b7sm15959122wrx.110.2022.10.20.01.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 01:31:53 -0700 (PDT) Message-ID: <87104912-6615-4917-eae1-6ae0a80677e1@redhat.com> Date: Thu, 20 Oct 2022 10:31:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH -next] mm/ksm: change break_ksm_pmd|pud_entry() to static To: Yang Yingliang , linux-mm@kvack.org Cc: akpm@linux-foundation.org References: <20221020075913.1046481-1-yangyingliang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221020075913.1046481-1-yangyingliang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666254717; a=rsa-sha256; cv=none; b=8es3dZJ4J5+M8FdbfctKmnmilnvuCLX33WzH/NfDahyRTaM3gQA0UWiyu8+rzgw4Gv6ZRr Np/Gt+yBXTNxOjLgiuFGssh2A8Bh6XbNfxPOa1fi3lkbTBGtbx41Yp8cx9yPjsx63lFl1q DvHgScrLP60yzhLeL7DfoagGk3lMYWs= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ju6tVq7Z; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666254717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3l+iydm17a7yf04/2AxRgbGtzA4d4ED+DxN4tpd1g+E=; b=1wmkGCgO1RhwXHV31J0/9/Y3RjFZeP0i4bgtVbl10UX6o57d37ESQRe2MJSgQSWy2t8Ien eVBaVQA3n2WcGvRki/rEtRLojKhStgo/haacJipMjxmG4E3lixBWQmAa+/O+acg2DL/LDd 4ZDAzazCgH7zgSJ1xcZPn/cDoombuwQ= X-Stat-Signature: ppbw3irhgbdnxi1kegwa1a9xdzky7ss9 X-Rspamd-Queue-Id: 92D4216003E X-Rspam-User: X-Rspamd-Server: rspam03 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ju6tVq7Z; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1666254717-158766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20.10.22 09:59, Yang Yingliang wrote: > break_ksm_pmd|pud_entry() is only used in ksm.c now, change them > to static. > > Fixes: 16ee05ec4698 ("mm/ksm: convert break_ksm() to use walk_page_range_vma()") > Signed-off-by: Yang Yingliang > --- Thanks! I'm working on a new version as we speak that e.g., gets rid of break_ksm_pud_entry() completely. -- Thanks, David / dhildenb