From: John Garry <john.g.garry@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
willy@infradead.org, hch@lst.de, hare@suse.de, dave@stgolabs.net,
david@fromorbit.com, djwong@kernel.org
Cc: ritesh.list@gmail.com, kbusch@kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com,
kernel@pankajraghav.com
Subject: Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition
Date: Tue, 17 Dec 2024 20:51:53 +0000 [thread overview]
Message-ID: <870c2e1f-eb60-479b-9429-761810cf8e5d@oracle.com> (raw)
In-Reply-To: <9fadee49-b545-440e-b0c9-e552bec1f079@oracle.com>
On 16/12/2024 08:55, John Garry wrote:
> On 14/12/2024 03:10, Luis Chamberlain wrote:
>> index 167d82b46781..b57dc4bff81b 100644
>> --- a/block/bdev.c
>> +++ b/block/bdev.c
>> @@ -157,8 +157,7 @@ int set_blocksize(struct file *file, int size)
>> struct inode *inode = file->f_mapping->host;
>> struct block_device *bdev = I_BDEV(inode);
>> - /* Size must be a power of two, and between 512 and PAGE_SIZE */
>> - if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size))
>> + if (blk_validate_block_size(size))
>> return -EINVAL;
>
> I suppose that this can be sent as a separate patch to be merged now.
And if you want to send this as a separate prep change, feel free to add:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2024-12-17 20:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-14 3:10 [RFC v2 00/11] enable bs > ps for block devices Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 01/11] fs/buffer: move async batch read code into a helper Luis Chamberlain
2024-12-17 9:56 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio() Luis Chamberlain
2024-12-14 4:02 ` Matthew Wilcox
2024-12-16 18:56 ` Luis Chamberlain
2024-12-16 20:05 ` Luis Chamberlain
2024-12-16 21:46 ` Luis Chamberlain
2024-12-17 8:46 ` Luis Chamberlain
2024-12-17 9:57 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 03/11] fs/buffer: add iteration support " Luis Chamberlain
2024-12-17 10:00 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 04/11] fs/buffer: reduce stack usage on bh_read_iter() Luis Chamberlain
2024-12-17 10:04 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 05/11] fs/mpage: use blocks_per_folio instead of blocks_per_page Luis Chamberlain
2024-12-14 4:46 ` Matthew Wilcox
2024-12-14 3:10 ` [RFC v2 06/11] fs/mpage: avoid negative shift for large blocksize Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 07/11] fs/buffer fs/mpage: remove large folio restriction Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 08/11] block/bdev: enable large folio support for large logical block sizes Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition Luis Chamberlain
2024-12-16 8:55 ` John Garry
2024-12-16 9:19 ` Ming Lei
2024-12-16 10:13 ` John Garry
2024-12-16 10:23 ` Ming Lei
2024-12-17 20:51 ` John Garry [this message]
2024-12-17 10:05 ` Hannes Reinecke
2024-12-17 21:00 ` Bart Van Assche
2024-12-14 3:10 ` [RFC v2 10/11] nvme: remove superfluous block size check Luis Chamberlain
2024-12-15 0:39 ` Matthew Wilcox
2024-12-14 3:10 ` [RFC v2 11/11] bdev: use bdev_io_min() for statx block size Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=870c2e1f-eb60-479b-9429-761810cf8e5d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=da.gomez@samsung.com \
--cc=dave@stgolabs.net \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=ritesh.list@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox