From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EFCC433EF for ; Thu, 5 May 2022 16:32:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 008F96B007D; Thu, 5 May 2022 12:32:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF7C56B007E; Thu, 5 May 2022 12:32:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE5E46B0080; Thu, 5 May 2022 12:32:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE9C76B007D for ; Thu, 5 May 2022 12:32:08 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 80C322FB5B for ; Thu, 5 May 2022 16:32:08 +0000 (UTC) X-FDA: 79432231536.12.F00ECB9 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf11.hostedemail.com (Postfix) with ESMTP id 230614008F for ; Thu, 5 May 2022 16:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651768327; x=1683304327; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J1ejMXF3Bd/GCmguw/mohOzkY0z/abBYcpbEVngnjig=; b=I5+3kJIMTzU7UUqqo3c/HkctSIlLGSEFSXEMBT6nft9MivGoc9nOKPXV Nm+pzuJkOp5XwZqUwiLgBzTV9HQBlccdD9KnrnEN/GGdRiShOIMNkPAID b5CtKK88UkuNyS+G4midsR9yBPRgXKP1Vs9uyqoJSpNZcyoc8riY5HONo m9Tvj27XIec+Px29uTp8VVdlBZ98Omt1ZGfV6Jii+GeBapB+hIbmk/6MG XyuZ/nNSpWNP53JIvFGG32+cBACnu7HB/2JA0p0K/OcztsrCpS1dvB+qO ZT5IWo/VKHclc2o8txVVX33DU94Vi8OdNZFmAGg6f/Fy9a2izXqpeOY6h A==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="293375714" X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="293375714" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 09:31:18 -0700 X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="694739879" Received: from evegaag-mobl1.amr.corp.intel.com (HELO [10.209.187.127]) ([10.209.187.127]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 09:31:17 -0700 Message-ID: <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> Date: Thu, 5 May 2022 09:31:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Content-Language: en-US To: Arnd Bergmann , kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List References: <202205031017.4TwMan3l-lkp@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 230614008F X-Stat-Signature: cbm8to9d9uxk4xbkyyqpft18q5fim4wu Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=I5+3kJIM; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf11.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.88) smtp.mailfrom=dave.hansen@intel.com X-Rspam-User: X-HE-Tag: 1651768322-402647 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/3/22 00:21, Arnd Bergmann wrote: > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: >> From: kernel test robot >> >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 >> >> Remove unneeded variable used to store return value. >> >> Generated by: scripts/coccinelle/misc/returnvar.cocci >> >> Reported-by: kernel test robot >> Signed-off-by: kernel test robot > I checked the patch, and unfortunately it is wrong, the current code > needs to stay. > The problem is the SET_DMA_ERRATA() macro that accesses the > local 'errata' variable. 0day folks, do we have humans looking over these before they're going out to the list? If not, can we add some? If so, can the humans get a little more discerning? ;)