From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D33E77188 for ; Tue, 14 Jan 2025 16:45:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76657280001; Tue, 14 Jan 2025 11:45:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 717216B0088; Tue, 14 Jan 2025 11:45:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59016280001; Tue, 14 Jan 2025 11:45:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 380826B0085 for ; Tue, 14 Jan 2025 11:45:55 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E6481160A52 for ; Tue, 14 Jan 2025 16:45:54 +0000 (UTC) X-FDA: 83006634228.25.E22B100 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 698154000D for ; Tue, 14 Jan 2025 16:45:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aRXVFrW4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736873152; a=rsa-sha256; cv=none; b=vo1MirPHDRm85gwwFX7AgijtmNLUQH5ZeFbT5Y3b8AhAPEemi9lJeFatcMa578OcxDQJK1 rYkVfO07sMxgVneFP0JTAEI0N2F3gEHffNHII7VGy8fXQQUWmUzJC6UQPVVBJWr/WdSS2Y n3QetX/r7Hzl5tdgogiGmguG2lQzLdU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aRXVFrW4; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736873152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYdAwCr8qGYS0S8rKw89Mhn+3rwLqpam4TbyhY+NPyI=; b=GvupvxmAjJ8rE2lXeq8anNpz/bD4cThPTa/4sWf/LHXURb8E3n2nKGd55sKzbsYylCZ9mK sPjjA5WqQVxroVeHXOwC/PvRUf+3L4evgDOJyX148jPm05DIAB0ST7of1/jId2/BjZOeGI Y9TZRdeg3vkFz7vHrOjk98AvsWrx2qA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736873151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iYdAwCr8qGYS0S8rKw89Mhn+3rwLqpam4TbyhY+NPyI=; b=aRXVFrW4NKSOV5nCiyMajEN7VFqmtV5lBkPuS+M54DPpiZ2mFMsgESMhpDImBV97mWgsj0 gmrpL4hgBCqOr+XeNcBNZHgS0xD1BG3l5S9HRF+qXU7dKNM1/TgNeqdMewsCVPE8e2C4gK R3DWdLzhMca7o0U8lJVvTO/GKYuBD1s= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-hLzO0cfZNV6BycKak9KCvA-1; Tue, 14 Jan 2025 11:45:50 -0500 X-MC-Unique: hLzO0cfZNV6BycKak9KCvA-1 X-Mimecast-MFC-AGG-ID: hLzO0cfZNV6BycKak9KCvA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38634103b0dso3431223f8f.2 for ; Tue, 14 Jan 2025 08:45:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736873149; x=1737477949; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iYdAwCr8qGYS0S8rKw89Mhn+3rwLqpam4TbyhY+NPyI=; b=dyPK2tzP0WK7bON8TKh28Ap5SH0Nl4jn9mpSIKbhXTcIi5HGYjinkiWB+pC/lklI9L +B8/98hHEcEsoBeXVxebFMm2Cd8dZjqP/G+DAe88sp+4NcusrW0kJufvEysuB61fVZxD FIHqQ8g3sSTdMAmFlsKgIX94bp1smt/BVo+wdJJIZ2vL8FadJYc8doIk94wp36ysa1QC 9xlWz/oWZ5iwigbSfA/97LUkkQ/cqu624MUBzsZWRVP46PsZJ8GTAXUICE2HX1IHaHzb OxW1eQLkJR2asIEy3PUmcMNbBqePLLZdVVLsT+7gS9pmexza0shfUvipUsyrrDR8UVki L1hg== X-Forwarded-Encrypted: i=1; AJvYcCWIHjge82Pcf0kLmdIBK4mugP0cgPIgUusN9VHhGalnNACHkqxajN486k0+WUBAb7n65l7PVPgquw==@kvack.org X-Gm-Message-State: AOJu0Yx/cjXiWy/jIpqsVR698IsOZDf8e5OoBMG54GAmPPRgAmV/NxgL xHAvk0G3kHtXS1p6jbJ3+OB6gtH5XKulBnG1lqM7OZ6jui2bR9SzsbubgE0XKiE50Cg+GMxvyfS OUeJhM9ogkWRcwntzUZ1XXHKTZuceLyKjEt8BgS3xHJktkX2X X-Gm-Gg: ASbGncsSTqoS2SbL4RxbNn7ta8hGDSjQLShRmBfq3FE6aAIPBEjlw/4+GlokAdHmoVq BmzWLMCe2MkDMJtRCZEBmNwH1AE+cBFxI5pdfZzy8vcB0gjCnM1zgTa9/a8His+NIdPGifig7nJ JCOw3+M+8DlNqJCPrqAd9bPZWsIUdujuOYoQkBDk1+icQUXiAxY+OvcoIOJM0Hiqamgox1Hra6u Pd7dY8s5rzEg3GchJYBT0LXtt7QQOnL4ZiaPiTdQ5hJCsEzBblyfAU+jtJDWJkXvGQJykFblvq2 NlezSIYhLB15sHkrDZOuwpx5M5RASH7b7gFILRE6Y2DjNTAONwKcAGnqddFjE0UnPCYptqQG0CN 1FcPpTf/x X-Received: by 2002:a05:6000:4020:b0:385:e3c1:50d5 with SMTP id ffacd0b85a97d-38a87338fa8mr26780501f8f.48.1736873148950; Tue, 14 Jan 2025 08:45:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEz/61i1ZjhaPWPp1WC6/vgt/fDvbl6dYaUXZA+9G8OX1twYhKZREnloz3KEM1phDS6xL7CAQ== X-Received: by 2002:a05:6000:4020:b0:385:e3c1:50d5 with SMTP id ffacd0b85a97d-38a87338fa8mr26780479f8f.48.1736873148535; Tue, 14 Jan 2025 08:45:48 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e320329sm15298458f8f.0.2025.01.14.08.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 08:45:48 -0800 (PST) Message-ID: <86efded9-c1d9-4efb-bf41-f67faa49bf69@redhat.com> Date: Tue, 14 Jan 2025 17:45:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 19/26] proc/task_mmu: Mark devdax and fsdax pages as always unpinned To: Dan Williams , Alistair Popple , akpm@linux-foundation.org, linux-mm@kvack.org Cc: alison.schofield@intel.com, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: <6785cbb7125bf_20fa29418@dwillia2-xfh.jf.intel.com.notmuch> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6785cbb7125bf_20fa29418@dwillia2-xfh.jf.intel.com.notmuch> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4YCV3pwMphmphDgqkr4G3Qcva7SFPZMLle8EZkHo4-Y_1736873149 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 698154000D X-Stat-Signature: qn55xd3mp4mytyzq553o9pczibrfgwzo X-Rspam-User: X-HE-Tag: 1736873152-586058 X-HE-Meta: U2FsdGVkX1+iyYn0CWd0rRe+W2CPEzIBZQtI7s5RRLch8BgqAYKZY+Drf/W1Lxe7RQooH/eYx0yS8CjJhXI7SiXejtjJaEQ94aT7cW46TIgK9ctnHTr00Z7CV5UnuHDdxMogSxzIL3aqLRq1RV8Y9FA6HWLK8rYlyua9Oj3SjsOVKup9U+64ataDGPTYXooXVynhqzbfPwLuAgpdwcVulArWxzSFbaYv2USOV3ONJ/16nVhSw7E21IXvMsdIficD8ApLdtHjl5BBEpJPZVSuYgYoTZradqT/DT+lDIKxTeZ8fakHDhGbkqjhU0xSzg81fhP2+jB8+OuswYawjrEdkoHjeEUJqXg3nJy3ybrd9nL05rBOBXBgbj9fO7hyuBDk7MAPbHi/Rfjr4I2NeVI3lrHa135FPEY/WI4rf4IaFFgoPvGB/JR6/4nn2OiPEpLHHkRqrX/U/Eq+WTPjY3ICGzZldsa2OndGSuWoiNkU5+OVkF+TP4H7BCM5PJhnyUtjUpFJS9aR/dV9JzkN02vNCSYxLRhIZT/26rf7vCDiqYzvbcXI4aY/P9mzQ3f9NXjuP/kHvBQlS2VafqfuVGakPJDPudE4LBnv/s5iZLZH/44Q40EZY3zSWP4e8Vzbx+woVdSNG7OJCrgoZ3xv/ofYmktMrT0nAu4lHNV5dGH+qwxACW+edGH/N/rVCRhE4EFrftScXfDp2BU7rTHLKpMdtvYFdtqke4y86MOlmD3ND9q4tb/geysIuWWNc8DpYExGjO46L5MBtk9JIIm12NVcCvY01XNPDqXqiEMGMuprlA0/468DS1H6YBdpF6x/NWKVGovxJYZ6V/tQuWw7cjhyKD1hpz45VyKMqcGKJzR2qZuQpppcwb2DrplkSUhRJ3HKIqVzpjo6hqnLJLHwyq4mNxKDT5Yt8343lEhDo7R0cKh0WsIAr4KZsIf6pebl5EXM/FtAxn/8PntHitxmfGr jxA195qK hGJwLfTJ+M+U64glsB+m2iFhaTAtKeAo0GFKpTByTkNqcPBl32xbwT5xXPxkylKtBf5DSBpMqxpX55JlsAvUxWPmESS4xkZfBnGuvnAVxw8UbvPBMR/4/UE2bV/BuJGQT5pIkOJUKfmJs403OyIfSjATh1iUuGeMxgx7k946iLOEI1n75Q8yclJETvug0lYLsC4ULsqVOuPB5a2f7LIFMA4yNTffhXYQflU0lI9sK0D3hf8rrZS/8olghyKtWthjvt5jlJtfM8Ca3s5vyGxdwgaMinI0d8B1zwZwlrC6ec0rD5DYCeOpxzFeJfcaYimTkxmmXCcNQFjpZXhFUxGwsuzVlYPiSM/7j4oPHGx03PiWJoOLfFG3IScCcmJxujMZYb1Ho8WAgksPuDRFcnQW0EBF7uzTk59PlZ24LLqynnzr7TE8MqN2Egp2kX0pH0xaEaNqxdODDrk4Hj2SXkdzwbHwKAUeJYhyi/it+rgS1jYeKAcyP0YrKSKOSTUM/CI0ZNdYLWDxYArrmRK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.01.25 03:28, Dan Williams wrote: > Alistair Popple wrote: >> The procfs mmu files such as smaps and pagemap currently ignore devdax and >> fsdax pages because these pages are considered special. A future change >> will start treating these as normal pages, meaning they can be exposed via >> smaps and pagemap. >> >> The only difference is that devdax and fsdax pages can never be pinned for >> DMA via FOLL_LONGTERM, so add an explicit check in pte_is_pinned() to >> reflect that. > > I don't understand this patch. This whole pte_is_pinned() should likely be ripped out (and I have a patch here to do that for a long time). But that's a different discussion. > > pin_user_pages() is also used for Direct-I/O page pinning, so the > comment about FOLL_LONGTERM is wrong, and I otherwise do not understand > what goes wrong if the only pte_is_pinned() user correctly detects the > pin state? Yes, this patch should likely just be dropped. Even if folio_maybe_dma_pinned() == true because of "false positives", it will behave just like other order-0 pages with false positives, and only affect soft-dirty tracking ... which nobody should be caring about here at all. We would always detect the PTE as soft-dirty because we we never pte_wrprotect(old_pte) Yes, nobody should care. -- Cheers, David / dhildenb