From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3759CC433FE for ; Wed, 1 Dec 2021 19:38:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 615506B0072; Wed, 1 Dec 2021 14:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C3B06B0074; Wed, 1 Dec 2021 14:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48B486B007B; Wed, 1 Dec 2021 14:38:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 3AE186B0072 for ; Wed, 1 Dec 2021 14:38:00 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0751E8994A for ; Wed, 1 Dec 2021 19:37:50 +0000 (UTC) X-FDA: 78870235500.13.463B424 Received: from sipsolutions.net (s3.sipsolutions.net [144.76.43.62]) by imf26.hostedemail.com (Postfix) with ESMTP id D50D920019C4 for ; Wed, 1 Dec 2021 19:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=IcOhZQ70CoYW6JIlj+gzuBZuD6zEZA8xPOcenJenpxw=; t=1638387469; x=1639597069; b=JQA15W16/mAXYEngX5HXLCCmDHQUvws3iQmHnfEXGxDNA2L hoSc4TTgIwWiNHYhjECWsYBVCf6q8tLQSab0pfqExo/XjQW7NoZw10Y9z4d4pB2ynVhy3gRE7oiv9 73/Bx+jFP5dN2xQ4ki+IipAcKzWRHFlQzWbfMJeUUe6G0R0gRQtOuIrwkHEYDhk+/C5mNtepJsHcG fUq0s9loxs300sPvryJJ56Q+JpkinRgs05GvMnuq6VlIVA68iDG5nDsnnWy0ETOKKcJ9dt9FhvRd/ 17ZwpeTJ/UmTZlQbgA5xojOLNWiQiAp5FIloukdhTm94dt7FkgmFrwg37U9Z+5xw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1msVQD-005Yhj-5V; Wed, 01 Dec 2021 20:37:41 +0100 Message-ID: <86e341519e1e7424a1f46fef23ec88a4d48f87c9.camel@sipsolutions.net> Subject: Re: [linux-next:master 3615/4301] include/linux/compiler_types.h:335:45: error: call to '__compiletime_assert_314' declared with attribute error: BUILD_BUG_ON failed: sizeof(txpd->tx_dest_addr) != ETH_ALEN From: Johannes Berg To: Kees Cook Cc: Kalle Valo , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , linux-wireless@vger.kernel.org Date: Wed, 01 Dec 2021 20:37:40 +0100 In-Reply-To: <202112011059.1F60C79D@keescook> References: <202111302102.apaePz2J-lkp@intel.com> <87pmqgsrcq.fsf@codeaurora.org> <202112010840.0AD4D41162@keescook> <17ccfc4f9f9e74e1d6b48366a87cbcf887521dab.camel@sipsolutions.net> <202112011059.1F60C79D@keescook> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 (3.42.1-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D50D920019C4 X-Stat-Signature: epyjccitxn1mgcjoxwjzwfjrt3kpru8c Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=JQA15W16; spf=pass (imf26.hostedemail.com: domain of johannes@sipsolutions.net designates 144.76.43.62 as permitted sender) smtp.mailfrom=johannes@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net X-HE-Tag: 1638387467-185236 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2021-12-01 at 11:04 -0800, Kees Cook wrote: > On Wed, Dec 01, 2021 at 06:29:49PM +0100, Johannes Berg wrote: > > On Wed, 2021-12-01 at 08:41 -0800, Kees Cook wrote: > > > > > > > > drivers/net/wireless/marvell/libertas/tx.c:116:9: note: in expansion of macro 'BUILD_BUG_ON' > > > > > 116 | BUILD_BUG_ON(sizeof(txpd->tx_dest_addr) != ETH_ALEN); > > > > > | ^~~~~~~~~~~~ > > > > > > > > Kees, can you take a look at this build error? You added the > > > > BUILD_BUG_ON(), right? > > > > > > I will investigate! Given this doesn't happen on allmodconfig but > > > a randconfig trips it, this might be finding a legit issue, but I'll > > > report back more details. > > > > > > > It's probably some alignment thing - note it happened on a specific ARM > > with a specific compiler? > > Yup, that was it. It's an interesting bit of "accidentally correct" > problems that I think I've now fixed with this series: > https://lore.kernel.org/all/20211201173234.578124-1-keescook@chromium.org/ Yeah, I saw that like the minute after I sent this response :) > > But there's not really a good reason to even have the struct_group here, > > we only use it as if it was > > > > u8 tx_dest_addr[ETH_ALEN]; > > > > anyway? > > Ah yeah, nothing uses tx_dest_addr_high nor tx_dest_addr_low. Should I > send another patch to just rip out the struct_group entirely? I have no strong feelings either way, it's a pretty old driver by now, likely nobody will touch it :) johannes