From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A74C4332F for ; Mon, 17 Oct 2022 13:31:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCB9B6B0074; Mon, 17 Oct 2022 09:31:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7B316B0075; Mon, 17 Oct 2022 09:31:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B69DB6B0078; Mon, 17 Oct 2022 09:31:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A8D7F6B0074 for ; Mon, 17 Oct 2022 09:31:40 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EEC9280382 for ; Mon, 17 Oct 2022 13:31:39 +0000 (UTC) X-FDA: 80030528718.29.7D6AA20 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf10.hostedemail.com (Postfix) with ESMTP id C0238C0030 for ; Mon, 17 Oct 2022 13:31:38 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Mrd9F1t32zpVtf; Mon, 17 Oct 2022 21:28:17 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 21:31:33 +0800 Subject: Re: [PATCH v6 4/4] mm/hwpoison: introduce per-memory_block hwpoison counter To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Naoya Horiguchi , "linux-mm@kvack.org" , Andrew Morton , David Hildenbrand , Mike Kravetz , Yang Shi , Oscar Salvador , Muchun Song , Jane Chu , "linux-kernel@vger.kernel.org" References: <20221007010706.2916472-1-naoya.horiguchi@linux.dev> <20221007010706.2916472-5-naoya.horiguchi@linux.dev> <3a6e403d-15d1-f419-698a-b1c825f59472@huawei.com> <20221017114311.GA3679212@hori.linux.bs1.fc.nec.co.jp> From: Miaohe Lin Message-ID: <86df156c-2f87-2653-c1b9-495d724d2113@huawei.com> Date: Mon, 17 Oct 2022 21:31:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20221017114311.GA3679212@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666013499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4qFf01EUU1UoNAVme5O6Jn5O1X+uFgR3fuO1qv1zfGM=; b=ueylLZzIJEOL9l6HL5JgbLkPYfPP9Z4dEZN0uaZp/GnKy7LKeH8+3MgOcdBsQV4n0V6slp tbB1ZrlHoDboeLEY6NY6vyx9NW387LYxnFa4jHIIZ7meHmTrmcWqaLhDoGNnHye9DdQL9u SBzqd6Uq3eeWBU7Hv0zVUuXsgViEQMg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666013499; a=rsa-sha256; cv=none; b=Sj3EfARXN5sFQmZoMBNpIAnHFngNZJqgtJ2/iEId+8bJiUOjqSIteW29rTG5p1LefslMmG VO8J6trtzpXr8UDBQbcD4t7rBqGcq0M4GVk0+fRb8lwNVnsEnQAWCh1RB3jgzstFuAm2y2 gy9Do6M2VcziGx3VwCDz7pUGLlK4+1M= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C0238C0030 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: h6tuzqxau9ujrccxafstmbaibanmjqn4 X-HE-Tag: 1666013498-410161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/10/17 19:43, HORIGUCHI NAOYA(堀口 直也) wrote: > On Sat, Oct 15, 2022 at 10:28:00AM +0800, Miaohe Lin wrote: >> On 2022/10/7 9:07, Naoya Horiguchi wrote: > ... >>> diff --git a/include/linux/memory.h b/include/linux/memory.h >>> index aa619464a1df..ad8cd9bb3239 100644 >>> --- a/include/linux/memory.h >>> +++ b/include/linux/memory.h >>> @@ -85,6 +85,9 @@ struct memory_block { >>> unsigned long nr_vmemmap_pages; >>> struct memory_group *group; /* group (if any) for this block */ >>> struct list_head group_next; /* next block inside memory group */ >>> +#if defined(CONFIG_MEMORY_FAILURE) && defined(CONFIG_MEMORY_HOTPLUG) >>> + atomic_long_t nr_hwpoison; >>> +#endif >>> }; >>> >>> int arch_get_memory_phys_device(unsigned long start_pfn); >>> diff --git a/include/linux/mm.h b/include/linux/mm.h >>> index 17119dbf8fad..f80269e90772 100644 >>> --- a/include/linux/mm.h >>> +++ b/include/linux/mm.h >>> @@ -3280,6 +3280,7 @@ extern int soft_offline_page(unsigned long pfn, int flags); >>> extern int __get_huge_page_for_hwpoison(unsigned long pfn, int flags, >>> bool *migratable_cleared); >>> extern void num_poisoned_pages_inc(unsigned long pfn); >>> +extern void num_poisoned_pages_sub(unsigned long pfn, long i); >> >> The prototype of this function is: *inline* void num_poisoned_pages_sub(unsigned long pfn, long i). >> The combination of inline and extern looks weird to me. Is this a common use case? > > No, it seems not. I can find a few place of such a comination like task_curr() > and raise_softirq_irqoff(), but as long as I understand, there's little meaning > (showing explicitly but redundant) to add extern keyword to functions in shared > header files. So I think of dropping the extern keyword. That looks fine to me. My Reviewed-by tag still applies. Thanks Naoya. Thanks, Miaohe Lin > >> >> Anyway, this patch looks good to me. Thanks. >> Reviewed-by: Miaohe Lin > > Thank you. > > - Naoya Horiguchi >