From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CF5C3065C for ; Thu, 4 Jul 2024 09:05:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6486B00B1; Thu, 4 Jul 2024 05:05:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 355EC6B00B3; Thu, 4 Jul 2024 05:05:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DB16B00B4; Thu, 4 Jul 2024 05:05:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 063E66B00B1 for ; Thu, 4 Jul 2024 05:05:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A3929A1141 for ; Thu, 4 Jul 2024 09:05:16 +0000 (UTC) X-FDA: 82301486232.11.D6E23EC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 8B682A0002 for ; Thu, 4 Jul 2024 09:05:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jgwrfsEa; spf=pass (imf25.hostedemail.com: domain of maz@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720083888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=65DqMH+it5Ge7mOX4X+2VLr/O1N9c7ScEW2YlpZjygA=; b=asSGd8DYhLSHW8YUsSoqnCbEGo1XuaDGHE7rZ+KpZLUh7xt5J/44Z2yQ5VDOAG2n/OPFRQ f3cQT5NEOKkTKFob0kgpOBo5nOzRAM5igEp2uXyVY8aw5A1sXab7qCU24P1jGROnrhVsPM 8ZDujm6R7MAPd6XRfsKFm2DJYcrMydw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720083888; a=rsa-sha256; cv=none; b=dPX2SbT01ZwZXbFWm4A1h4eJ6AwipAXuqKUzHW+H9ugUHJjmfAZ2IoL9brS0n+Iy5Yv50w zDyFFTbmQk6xLa/6r9UivJDNoAPBMvp6a/IUGPqrY+wkiA98rmlU0G+m6TQtbT2YfjNfCT GbhQwoADdE7+AoHR5NR3o9EhA1IgkSU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jgwrfsEa; spf=pass (imf25.hostedemail.com: domain of maz@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 21DD8CE2B0E; Thu, 4 Jul 2024 09:05:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AB0BC3277B; Thu, 4 Jul 2024 09:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720083908; bh=HT+Pmh784cgIWcaD93R7htk85VVOdEkMHUzpjkiJ1oo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jgwrfsEahTVjC2Skl930DegpKd272w9RmBBkmh/YIgNoKhKKvhZ0wRuox0Wd/2ZQc rJ4zk5/VUrpcsmWQ2sjCnKirsUh9hr6N0uaLhORsYUYmbDtZHKO0euX5wm4uFQ/aNH FfkrSggWEFvzYM3/+brrT3HeiLiX2tvUVUCR4NDIybDPcEeFwdfUX/VSISoti6UpYr U/IsFmURH8LUcFqD5GtJYO4BQ/Z0ZugRL0rzlSWQSp/SCSktmdQVT0uAcjzc6n/xvh UZcUJUPVgiVOfzeA3BZZqLPnAfGT6D0PqfQEHaNvnFW6NwaESWPPU2LGGStwejam/B lBAF2VRO6m5VA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sPIOn-009hbf-Uk; Thu, 04 Jul 2024 10:05:06 +0100 Date: Thu, 04 Jul 2024 10:05:05 +0100 Message-ID: <86cynt4jem.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: kernel test robot , James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used In-Reply-To: References: <202407021807.cBuWVBVa-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, lkp@intel.com, james.morse@arm.com, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, rmk+kernel@armlinux.org.uk, Jonathan.Cameron@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Stat-Signature: b4d7jtcpdfp79w16o7joi17i7s3znpsy X-Rspamd-Queue-Id: 8B682A0002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720083912-996364 X-HE-Meta: U2FsdGVkX1/a3od38X9pebczLfaSR6e8bijds7dLeqpY3yQMiSJWdFq+gCxxuqGn6JAgKDFSWSciab3Ndfnsus+LdwnLdJh6HQHTG3QrndvFC6q7vg/0IVXApk6sqa9bB20O8Ynhiydtc5NYU2jgAKjBj71kzeHfZYFKxwppEyEcvXRdrmKTmofXvJfPRsm7T83IK8PwjxaVEdxSa61ymiSzZab6dR1AmuIhbzx1m8rJbH9CgM1MiZTqijalxAVTkTFlQEwzW5pMUPwOOEk0YKp2BSl6NV0YreIHZwp6zXe1W8qldUAnWiWVjSsyegHwgjjCt6Su4xh35F/hragMLNKIfc6Y9sue49w3QkVqeU32tUgctdSM73RJOu+wbBPjEpJ2kPGefMCiOwbVa8XnwE5tseCGINgw+mWH8FkzNshcU33i439SZyECwi9tKTLoMRj1312gt3xp737Dx/dEtRtYn0Hn65cJ59bAeNL1YE8JK8IcWSR1GRtglDqsThOZ7E0WqD9CT4/kIY1whhemdM1VcZ3mn+XGeSDWREiptB+2+G4hfnlXD74YouN35/vAgVSDCoWzi6Sy+34AfLoJ8XixxEDNDkgzuezMfYF6NpVoqv1mvnpezj4xFtKQ/AoqEdDaZy9PyeJnYb19LjXDyIYvW+Z5p64C+cdv6hu2hdnDE8HFv4PDRAKT380XSP37ggDnqn+YNr2v3TTLvo0OfVebrCb0Q0TwoiJVRmY2PHNNq4bjaqNZH3l04bsxAWOvHOk1agArBZ5xJ8bmUWL4hnuNxOacZU+3c77cqKNi5FABPV/WHGFfdKotZA95qYGHXxEnBJX/oWaGhQn8M6JUZ1Lx90sjoeA7drAok7M2obSLxQuEFiypujpfru+cRHx6K0ez5izkjkD/GvpI/MfzV5grtJHuOpCpsdXA0Sshmz114nXxA8OPXi+WIXRDSqWEQQnkq05uo4LU3wqJxOA z6UHjIIw O8s63mB5EmbjCA8s1sXPUcozmy20xka39TLcDLFld2bqO1THC7EIMDgZOi2cO8lD0fuaWC2+/OnxXfItb5GtiiruTTrRiBh6Okon4ffPOtSL0Jjlii4yvKss9l11PSJ4ox8rGs+x42Ji371yCT8WGeIgB7DX/WJb7CTzHCovuixFJ+EVxVVKs6BTmawBwDmTkMiaJtLorMxPk8qj0pNiXOU7hVylhJ5OrFIT/RwG7aKh6Gr3NdW79MnjmRcwgDabjgS232Cyc9CkJYk7tSBe4BXhCfJD8PjiCFcHWxI76on65nXb2l/bO5iZpz96wksqVkvhxzsrWNJPGXsVmPmCodfVzTSJnsrIspppaHPMHP/BHAlW2qqRZ+5jMdEbm8UgwqbVUQtvyUa2Z4N03inNPdWva/OlCBjp9Rqgku1fQ15viP9KI6eg2bdOA8ypbgLsrGFZKQeqmtuH6is5ponVLUG7wPbniPJllB+5YRnWw4pc4SASAm+D7eW64z1Q78sPK0+ojoKNcAYzNcdY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 04 Jul 2024 09:52:16 +0100, Catalin Marinas wrote: > > On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > > 47 | static struct cpumask broken_rdists __read_mostly; > > | ^~~~~~~~~~~~~ > > > > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c > > This can happen when building on arm32 with SMP disabled. So we either > add a __maybe_unused annotation or we move the variable further down in > the CONFIG_SMP block. Marc, what's your preference? > > -----------8<---------------------- > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index c29b424d1d0c..6393f3d780e9 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > -static struct cpumask broken_rdists __read_mostly; > +static struct cpumask broken_rdists __read_mostly __maybe_unused; > > struct redist_region { > void __iomem *redist_base; > -----------8<---------------------- > > or, > > -----------8<---------------------- > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index c29b424d1d0c..187948f41bb3 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > -static struct cpumask broken_rdists __read_mostly; > - > struct redist_region { > void __iomem *redist_base; > phys_addr_t phys_base; > @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) > > #ifdef CONFIG_SMP > > +static struct cpumask broken_rdists __read_mostly; > + > #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) > #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) The second version seems to be the most logical one, since we already have this SMP-only block (note to self: constraint GICv3 support to SMP only at the earliest opportunity). Feel free to add my Acked-by: Marc Zyngier if you decide to push a fix on top of this branch. Thanks, M. -- Without deviation from the norm, progress is not possible.