From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157EAC7EE30 for ; Thu, 26 Jun 2025 21:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62F786B00B7; Thu, 26 Jun 2025 17:51:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 606B36B00B8; Thu, 26 Jun 2025 17:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51BA76B00B9; Thu, 26 Jun 2025 17:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4115F6B00B7 for ; Thu, 26 Jun 2025 17:51:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BB646B9573 for ; Thu, 26 Jun 2025 21:51:39 +0000 (UTC) X-FDA: 83598899118.05.4B21316 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 45D9620006 for ; Thu, 26 Jun 2025 21:51:37 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CIGT/HPv"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750974697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p70ORTbIO96gLr7OmgqzsoMMs3lt0rYniV0JvcEEfvc=; b=C8jywzI4XVAeCbjRrUkgCEUWuPl9PVawVii03bVGmBRj6g66LFwk+5FYp8bngpxqrYYS4I jIdDxy1LH/A63m4EAXW6490sCE+IOK0vddxY/8wEvstlhROVizvA2CLicR0o5qnD+/aF8I hbSnIREaxGRZrNG01FS6QDtN+npvYTg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750974697; a=rsa-sha256; cv=none; b=uXZN/pkyA6VVTkSnFzgZgqR/0gtWSV3dlZd2V0IUo+7VJGK8dirNgc+tZSHmoEdzmfRWiu O5fToWxjEg8S5TWg1vvdlBXiL/n7alnfYJIu2sMilP0Kmce1JlJkyZseE+baXxiJ4DFh+Y XT3oA38DoBVSWYZUH4EWhUdENxV/xVM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CIGT/HPv"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750974696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=p70ORTbIO96gLr7OmgqzsoMMs3lt0rYniV0JvcEEfvc=; b=CIGT/HPv/lT06sNcP2Yjvpg6mN34uCrcLE/SZMQivNgkPQVYM/y5Ig+/cuvRP6L+rz+DR/ VLIaJTV996vJC/cTxv5v4A/lnEGkwSDLMKEYhmURJN3h+zbG9TzZGvLbZTgDKMuQslaEL7 IrJPsy8Zj/Jd5cFhFQTxyPajqc5hO7o= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-Bt142kg_NpevHpVHma32PA-1; Thu, 26 Jun 2025 17:51:35 -0400 X-MC-Unique: Bt142kg_NpevHpVHma32PA-1 X-Mimecast-MFC-AGG-ID: Bt142kg_NpevHpVHma32PA_1750974694 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4538f375e86so1080065e9.3 for ; Thu, 26 Jun 2025 14:51:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974694; x=1751579494; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=p70ORTbIO96gLr7OmgqzsoMMs3lt0rYniV0JvcEEfvc=; b=X3V7xIC/Xf8F6cAbGnEBvRyzpEU7whHNey5xqxJRSBZu5EvxUPzdu5lYbnb8kfPBpA XlMcxlLUhCcuzK87dQNJ7RCm1sbNRy0Y43Fd9U9liIYa4MFcJRssPweJ6QGru/09FGvK Oa7Qiv2trzHdi+Qcr2yytOOEQ60GpgxD7WqpHeitwtd0cKn27DsBMFzOEgzLAn3nPfHN DwwglzV1DGOElcqEV4+mM3VDHQzYsLTmTR4IsU+Vp4v1vOhRWGFhJppr8ERI8q/XRAY1 X376S+pfjy09pxWtzKCcIuOJDwicEGUqq/ss5wawHj2xYXUfSJptX1iO6WaxmvuhEjGk k4xw== X-Forwarded-Encrypted: i=1; AJvYcCWqoXwmNBAsPAxHeHFtsCez8PJMMBFCmfD0fN4dVSQwONAKcVgVI0tqPPgdTI4cC2mMr1qE3XKoHg==@kvack.org X-Gm-Message-State: AOJu0YwwR4X45jfMYRhqd+UXFzBCnlJSgx8xNYwYjT6RVgLsY5K2wgsE 0+2SBTiertaB/O9nap7TIXChRqcTCVcARt79kCC5L1pngBeeZo+C0nOScjbyFSTNvej/Yjhzf/G 3QOt9Y7gA4tuf+HwDBILQS6J/k8pfyETYrzA1ZUJyusz77Otj3Gsz X-Gm-Gg: ASbGncv/FeT+3oOdfd9HaLZMN7hQhI7GMwtPvKVZK6/QMXe7T8G9UqzPIVqLxEVQawz kx+fwwjRb2w97Q1PcPolyibncB+vPGGHB1k7V6DDjrL9aPZouU76KN9NfdmNFS8KZtwqrT4yjSi nEPfK1FEWpxt5GEshFYy/+z7bazJW7G1vZWmtO8Wt7Azwop7TWC09DYCg82dAmCjZg2tvJPYFaC 7yMlKRxyO52AV0zSRLODjnbUSLhi2+V+7zK/nOKppcaOMJmhm8EXxo9P1eoEwmKVyuJnjg9FFAF YMuU+a0YyAMlcMop/2BNSnkj3szxEkOxsx1yu4u9r/Y1nosGjPO94OritWfeEK6C/+qadXs75aH g3esA0t/hExAfUE/Q80mGMQx9dwXx59NUxuqYLC4ZBMJXpP9u+w== X-Received: by 2002:a05:600c:c11b:b0:450:cfa7:5ea1 with SMTP id 5b1f17b1804b1-4538ee55a30mr8073155e9.16.1750974694031; Thu, 26 Jun 2025 14:51:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGThS/hKhvVwJ1z8eBZFnCLtGBjla1a26fmp6IijmJ6I8BcuS05x9CB1U22lzA0DGl/D7jYw== X-Received: by 2002:a05:600c:c11b:b0:450:cfa7:5ea1 with SMTP id 5b1f17b1804b1-4538ee55a30mr8072985e9.16.1750974693610; Thu, 26 Jun 2025 14:51:33 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:2f00:8afc:23fe:3813:776c? (p200300d82f3c2f008afc23fe3813776c.dip0.t-ipconnect.de. [2003:d8:2f3c:2f00:8afc:23fe:3813:776c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e5f92esm928649f8f.90.2025.06.26.14.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 14:51:33 -0700 (PDT) Message-ID: <86cd01ca-2be8-4e20-83fb-1f9321da6349@redhat.com> Date: Thu, 26 Jun 2025 23:51:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/mempolicy: Simplify weighted interleave bulk alloc calculations To: Joshua Hahn , Gregory Price Cc: Andrew Morton , Alistair Popple , Byungchul Park , Matthew Brost , Rakie Kim , Ying Huang , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com References: <20250626200936.3974420-1-joshua.hahnjy@gmail.com> <20250626200936.3974420-2-joshua.hahnjy@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250626200936.3974420-2-joshua.hahnjy@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: miAsupzsdU6Y4qiam3x-lO1KAwa8AgFoO-X6g-_Eduo_1750974694 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 45D9620006 X-Stat-Signature: oxxukgxe3dwpx5sr8n19p1fgfgoz5y1k X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750974697-316271 X-HE-Meta: U2FsdGVkX19UHz34qUIjdnA63izokPvf2RoF0lucJDE4MkEVChH2s/jU8qAUykcGdchL87sk/J/pFi+Kn0U8lyHaLl9Ei+cXC5Vx+R2qqjasfrS83sqVmGdIlijoyK5nTIci1QlqW3gH3u5Ek4T1ZczzJcGAlQ9LQYNSiY+kKAwZj4AAeHiGIeuW0Qu3nUo2W1y1VzgjbgqKOaBpi8Mbjc4jiUN68dYzouVyk3XjCUHg6NUZvyZvaM05PcnQOEEALZM5eMMZHPh/lBT8fFXJq2zDtWyrnxcBiVOCazF7FiXTxqZBXVfZp5Iqx9NDYwsLyCZqa6LKpX/11rywZZue7eu5AEBE+F8EqgtHZiE2dMjVNR3SFVGQfkySSDUHon+J3JMD9V2eee/2Veui9f8FNRiZnnJCZAltG8Be6BILCQIcSpCuvNHzQWyKIGaC68qr3szbD20cgS/uxedy4Xgfu5TGps0J35Hr7ZUp0LDWvSYpBV5zP+xPZzn3TgRACRk0DshJHgmib7swhOJW3YWIvdGRZVLML0XyfSm5e7Q1Tlzy67gwrghRAYHB81hVJeYCSkIex+PgCIJtpEl7iSNAuPwMMXLO0YJWvcJ0WkJ/zj5LDaGCY9473fBjEK4LJP/Ld6iVujViglX2BLLpN873hYvPwR9wwQOlL4ZmpAX/8Co2xzhwKiZXnfaSLrPt6vDuNE71S3eYTejfkdc8ZM+wkrqy/0wKmabSg6jui0N04jA8Fjy8a68b9pkWWjJWQkeKYbOX1MDJMn990ANjwuh2mU/lGbZC83oK98eBiVW5Opz3NYpYnWJ/EI+ux5whC1XgfE4+FO4n54VE4AZGPphOlugOFFPyOn5umR90TqdgGvJELVkqs1ysyUEt85HXcWpG+NbC6EDMIUbo+r47pWcEbMXskUFBWaAZojlElUOfKZfNRG18rpRcrRlvtBzEeNshqKQ91VpHKJ0JIg9XKVU dlEIOE9A Oiz7OABiOTYNhvpiuDQFCZOjXTFWyagHn88oBZEQvnK95j9T/gzLtWVoo5lfE77uSxLKOsMCWQN01BRag06SP7q3nC8yYjKXnrSkUhwI4G+SJHRZciYIJLILofMCVecy5j2Va7t29xobmy0XXYrYMA7Po6NKK8o1R2eKgpXLsLSeP7d/38wD2CjGSUMyNLOJ3RkootBlHwqlY2kCDa+r4a8guR+FtRrVqebImM8ARKwDX7hcEpeVCOCdvfmGljk4EyRW63JEOFtjR2Obi7cxGihyW4w3d1aoYLZowD0TS5Xdv8NoDxGy4XRUbnABj3mrvd5A+Bd7R2QO1w68trXTsd/QvktZtslTPot3AUnV7L6btHAFDJbed7hpiFrR0q2KEfJkBr/t0QEILs0bStRtBbd7mSpFY1Z1NamWlXkioxhY30ST60VuMVqbjyGC37w8GCaSXriiZmyINKuSe+1KPAz1LdlJqGt9kXXi8wfIwuD6EowTno0dG4k1i1CbkupErgIEXoDsoA5ca3/Refy+3bMMXA2SqKuoNbQhkPKVlUQK8Pao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.06.25 22:09, Joshua Hahn wrote: > Simplify the math used to figure out how many pages should be allocated > per node. Instead of making conditional additions and deletions, we can just > make them unconditional by using min(). No functional changes intended. > > Signed-off-by: Joshua Hahn > > --- > mm/mempolicy.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3b1dfd08338b..78ad74a0e249 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2645,18 +2645,15 @@ static unsigned long alloc_pages_bulk_weighted_interleave(gfp_t gfp, > for (i = 0; i < nnodes; i++) { > node = next_node_in(prev_node, nodes); > weight = weights[node]; > - node_pages = weight * rounds; > - /* If a delta exists, add this node's portion of the delta */ > - if (delta > weight) { > - node_pages += weight; > - delta -= weight; > - } else if (delta) { > - /* when delta is depleted, resume from that node */ > - node_pages += delta; > + /* when delta is depleted, resume from that node */ > + if (delta && delta < weight) { > resume_node = node; > resume_weight = weight - delta; > - delta = 0; > } > + /* Add the node's portion of the delta, if there is one */ > + node_pages = weight * rounds + min(delta, weight); > + delta -= min(delta, weight); > + LGTM, but took me a second (and it's a bit late ...) Acked-by: David Hildenbrand -- Cheers, David / dhildenb