From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8580CD1280 for ; Tue, 26 Mar 2024 22:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C8816B0092; Tue, 26 Mar 2024 18:24:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 478BD6B0093; Tue, 26 Mar 2024 18:24:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3195B6B0095; Tue, 26 Mar 2024 18:24:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1DE226B0092 for ; Tue, 26 Mar 2024 18:24:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E15CE1A05B5 for ; Tue, 26 Mar 2024 22:24:06 +0000 (UTC) X-FDA: 81940619292.05.35768ED Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf29.hostedemail.com (Postfix) with ESMTP id DBACA12000B for ; Tue, 26 Mar 2024 22:24:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Bk92Rggx; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711491845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NP2rNSB0HYVpq9Q15n24WlX0/Qq6oO/M7oiEH1ZPce0=; b=Ey/Y/vcMlsaY7N7ox2EF+V07bsVunBGZz59j8dgbDvn8GZ/sxofKZbcgF0EIwchMdJ2wAA hEHAW5VO/4XaAj2BOT+fEZWJCeSHP19AedVczXzwjwIFJ2+Knb9RE2M62buN0J1zsESTj9 9kutp/cL9ZV28hRtbV+F+C+C1stmzmk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Bk92Rggx; spf=pass (imf29.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711491845; a=rsa-sha256; cv=none; b=GOYsxcF38Z/hrf4+AMYpOwUpOoeoB+2tCbOTX46SvhK66VmoA1aRUU3HTVaWbRbQgszIdS 3Saf1ZwVe2Jnxm9cZRHxp65AFnz5kzebG8bU066+83jVfTdLJzhAXbFBRL4dPHsEeG3NHh SBFihYjXBL7rJ/DWV8uN++JZMZi5nxo= Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-58962bf3f89so1220156a12.0 for ; Tue, 26 Mar 2024 15:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1711491843; x=1712096643; darn=kvack.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NP2rNSB0HYVpq9Q15n24WlX0/Qq6oO/M7oiEH1ZPce0=; b=Bk92RggxCQy0jMF7yq6HkeWPV9S7+wqdKY7ba+7DbYIMwTk9rlKZ3mR2iYGQkkPg2X 2pIBz8OKxg32hcXds6QrBHP/wA30x11Nrg5Omc3J2zDF1nxKPwIedcyHf3QBr2AExZhf iHXjvfjvMyPaI05TKLZKJtRan6XL6ePeaD98rXzev7ydFt8zQVJ3eE7SKkKbW+pm/Bvj +VAwshaAAuNXZwB0cU4FghQnau9gVTTSxDoNV+iXL+om1++XOkw6byKqsmSXXuab4MKQ 3QgmgTNbYu0fHCWC2z4YOD1ArAaIBhGdhq/jW28KhMx3LBcvbUbRFQw5hWg8X9zPDDvn +6VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711491843; x=1712096643; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NP2rNSB0HYVpq9Q15n24WlX0/Qq6oO/M7oiEH1ZPce0=; b=bA8H66zVDE6trNmQY1TRqD1xJm6Slq0ZoJx6L+pi4zanOokynulsR8mlC/gYZgynlh NmInrNN8S9xXshgAP9uKfAQmRqXdgHxu9MLkJMi7hDkHXcr/Xo2X2NK27NKNkeQii2FC 8cBr2a2dCeXbbGQMJ9r7J7GHxiai3AIqElR8u6HItzWP2V3p0XWjnHlapPHPE6NX8M1X UdiW5MnYbmPlq8liqr/EWhOJnV713mwke6cy9zb71MiVfhbLWAD72HQIpHlx8IjL8+AT zVIDPg0Zsjz5+73O9qg2J70GI76Xdxwh52P2UIXaq63zdHjQzi97avshBmR6xV1Uoofr GLcQ== X-Gm-Message-State: AOJu0YylKcnN3agK9jmfnhls5s6oWmXf6voyGDmlmsRQe29eMQ5Ru0xx iine+XKH8ezdbWQKlnzAjZzQtdBouLGRwXw8nijk1jmi1IM5RP/7PoiGjIDMEEtw/Ozoj9zSH7W P X-Google-Smtp-Source: AGHT+IHciHW85N+I1Gq4m1nAu6jA6dHTGxAoHgzmMhlUasbG7ZJumwoEsrGB2aJ2phA1R6hPHZdlJA== X-Received: by 2002:a05:6a21:3396:b0:1a3:c607:1dc6 with SMTP id yy22-20020a056a21339600b001a3c6071dc6mr9639864pzb.6.1711491842859; Tue, 26 Mar 2024 15:24:02 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:122::1:2343? ([2620:10d:c090:600::1:b4b4]) by smtp.gmail.com with ESMTPSA id h8-20020aa79f48000000b006e6c04efd9dsm6460637pfr.206.2024.03.26.15.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 15:24:02 -0700 (PDT) Message-ID: <86cb4eaa-2ef3-47e6-87f8-96b15895a7ce@kernel.dk> Date: Tue, 26 Mar 2024 16:24:01 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: vmalloc: annotate find_vmap_area_exceed_addr_lock() for lockdep Content-Language: en-US From: Jens Axboe To: Linux-MM , Andrew Morton Cc: "Uladzislau Rezki (Sony)" , Omar Sandoval References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DBACA12000B X-Rspam-User: X-Stat-Signature: eqhoz5ytfq1mnr1zz3oq8jsorsa7cgyu X-Rspamd-Server: rspam01 X-HE-Tag: 1711491844-498694 X-HE-Meta: U2FsdGVkX1/+5GQM/XV8nkyaq4XnPyPa4BnmIBYZd3GrXm458YXvmYOceAaaH0EuxFYQzrM7T9wlR+vmGYBQR+VowofFS7LqKtezKftdoMqQrhWhvVL6kCNCKoZzFSyweK/tMwOkD6QlylmUlSKrzAEUji7t1G1aEMOzA2L0g3jaBXLVUjO2R/l22kqBOMXwL1Ro9g7zsjtdRXY2tYRbu+tWy1SNmGmzGFWncvL6wIi6cd6ds0GsmASyjgsKvcTxXc9GStpe1BRRtYzYSoAT+L7JQY+Rzk8MinAduJsSA1vjU3IowFhXBqfPu8U2uIPxqX3Wj2ipE4qHCHxllXOrWX4JdkQdfpScN0WsYkeIGS/S0X6Ip14gj7OsIaHYQkzDRXfz5OUwsm+7tNBDPCnSSHzf++GkLkXJ8/MlMkYab6GSf7JWnFRm7XhkndjBjtvghDu9T0CgfZwH3XD2imfgo7JSafycFlXuzVa47oBWGaCiGYtJjwbDhz3evmkDbN3BhyNBxgf3KMAX+5Uwge8n2JTM5aW08ADZdri5ePGjSUn4kD9aq1mo3GbIrIXzxNsSe5+ci8H2JsMbbuoEgJY8epVwxy9umyvLZreGZOVgRIE0EiRhcmuHRvwgC490Xu4gcaQGtcP2YXSOjO3EiesI8yTqK0fcbIC83Ip6xV2+c6NANrcHXxGCwAd1qjrzGarK9PAxAKak3eAMp4K1hAm3mAQWfpQXUI+zSUo6qRbd5wpEA/3PHCkk80XeBykACBprOHJ6R7HvFmNDhD5gwcN1L1o31va13BwFP+exlh7QBaZmifyewyIShTKcpnWqd0WLStGuMqfeHiY7aqdtAc0yBReRGLXl0Hc8S/eeWTIEeSfh3lHoR38kVCk5rbB0WfDDnpo4GIMHSlPJcVsmzgM0N1BvJe1MujYgnwbe5UedxrepaU1pz4SCCQE4y70RUbBSAKuNNpAKk7emlKlHWhy mTHtOJPL XxSB3m1Pv2Bzeurasw4RLfxakkDHMbYxKXu9whOt+W3YDFPxvMV5MeLfjmQ/GHUYhBWB3QlPVYuTddml72qrDdn8VfCEPtRP4GDunmQkNOmUdQJoG3DTIeYl4W656pk6p40hJqjJiu5MhFa1AnYxFEgZQw595rFtz6wOCkB96FEWLUIwr9vL8TZ5tIS98pmIk2HoE01ws4n1a/V/4bZjt06mxYEjEl9JXhQn9zVmAeTQlm/e9bMGn+kWJMyAJpTjbnnFhKpIS0o/EV4Av/XZREYdeIPDaB4lDcFdIlv8jSXPHduO7Gj2wUa9/goy/1EysjmRVB3bTQQ+dkswK+qVs2nxsX4rhtem4Zy/CZoaCCCUJLztbXSkb2EcnoGjEqvvb3SxWjy2shhqSliTfLj5roWEXKJCXI7ktSu4DE6mX158cJSXu3XNi27IQ5zOQXpTExxbAhSiXulqtTOPt0jOXJDCD5075ma80ldZPX9gh+00pBgEZpAPJs2NIq1LHN9nNkHOSRrOI1GJWTo7ZmcQL6epe6X/LgKWuICpq7plyaNOgZp8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/26/24 3:25 PM, Jens Axboe wrote: > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 22aa63f4ef63..26a69fa6809c 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1032,7 +1032,7 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) > for (i = 0; i < nr_vmap_nodes; i++) { > vn = &vmap_nodes[i]; > > - spin_lock(&vn->busy.lock); > + spin_lock_nested(&vn->busy.lock, i); > va_lowest = __find_vmap_area_exceed_addr(addr, &vn->busy.root); > if (va_lowest) { > if (!va_node || va_lowest->va_start < (*va)->va_start) { Omar said he tested this and ran into lockdep complaining as it only supports 8 subclasses. So this patch can't work, but that still leaves the current kernel code buggy... -- Jens Axboe