From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 000BCCF318A for ; Wed, 2 Oct 2024 00:24:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 318346B0163; Tue, 1 Oct 2024 20:24:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C7546B0167; Tue, 1 Oct 2024 20:24:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 167156B016D; Tue, 1 Oct 2024 20:24:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED98F6B0163 for ; Tue, 1 Oct 2024 20:24:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A77871206FA for ; Wed, 2 Oct 2024 00:24:31 +0000 (UTC) X-FDA: 82626765942.20.A29BF08 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id C7815A0002 for ; Wed, 2 Oct 2024 00:24:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dYX4ObVK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727828575; a=rsa-sha256; cv=none; b=cpyOQhKtZTf4AylSzcXgYue+gIeekdIYE6v72Xpp8EXctcqzwSltMCNKnv4I+0Jt/PBGHf LN0rDy6982FtQ2FeJRJYACMXrVnTnaci0mWZe3MegwxK9rWZC3PAnPIwtqd/R0wljolFfV Z4+AjPHiYPrmLqwTZNU6Fp61Zhgs150= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dYX4ObVK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of maz@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=maz@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727828575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vKZVD2tWswocM6IvnbckT7KYU0Bjx7mLLy/3Fzn69rU=; b=FPRFcZRhjzUmrU5DacXu4JBHRqv1tzAh724dxmJRgBDXv6JGDXOOsyD6a3GVuC2esRCP4P /X+Q5mbY/fnqm55SKFtzVl6Mcz+vjhqsJF7JZVSmPX2Nx9RiPcPMM09iTNY1Ra119GH+rS YemULp6qvfZsaIlZDNE07ELlxOB5Gow= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7544C5C0068; Wed, 2 Oct 2024 00:24:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BCC6C4CEC6; Wed, 2 Oct 2024 00:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727828668; bh=yV2B67r5ybVBizoo7LUv4X1d+GkzcMv6679G3VZtq1s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dYX4ObVKwKoWBdjh48SRSy1HnvnMkmEfMGXnuhaYmXJEVrXOcFND47+IIpayIx6AG 8sJwjCeaYEMfy5rI/+UjDdztZnthevTuWa8syEBmVQvaHan9KVAQ7xF4KsWL8UVy3S f7TUJwmwj/rs5UDj+DyC5FGZ9ndq6tqKenKd0NdZ/6uYbyN3dEhTgW5P52WDxrFNQk sUKjEM6YxZqyv/GMXl0obPbj2Fq9UTYIflqhu1WoDRhJ+p2exeP7svHcnvGYFQSdA2 iBKnDzURTchvhl7Ad+WO+z9tdnw3VMd9rk5YMKYPAimIlmyLbb8OA/SY5GBClemozy qBF01izH6DbfQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1svnAH-00Guuf-MG; Wed, 02 Oct 2024 01:24:25 +0100 Date: Wed, 02 Oct 2024 01:24:25 +0100 Message-ID: <86bk0373nq.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , David Spickett , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v13 16/40] KVM: arm64: Manage GCS access and registers for guests In-Reply-To: <20241001-arm64-gcs-v13-16-222b78d87eee@kernel.org> References: <20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org> <20241001-arm64-gcs-v13-16-222b78d87eee@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net, akpm@linux-foundation.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, arnd@arndb.de, oleg@redhat.com, ebiederm@xmission.com, shuah@kernel.org, rick.p.edgecombe@intel.com, debug@rivosinc.com, ardb@kernel.org, Szabolcs.Nagy@arm.com, kees@kernel.org, hjl.tools@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, fweimer@redhat.com, brauner@kernel.org, thiago.bauermann@linaro.org, ross.burton@arm.com, david.spickett@arm.com, yury.khrustalev@arm.com, wilco.dijkstra@arm.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspamd-Queue-Id: C7815A0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ebzd1wdqs9wbexhbfnaqfk8eckqfdnfs X-HE-Tag: 1727828669-484429 X-HE-Meta: U2FsdGVkX19rW/FLUY66ikuZKgReQpR9v/cSOhpqd7bKiy1NugYfTgsG/F6IL/RbzXrEVUXjCaI8rzgmmQ7y6i5RqWL6CHarFThLLH7HlM/xzAToohvqLxGesmmif20SSI9Z6XJHcQckMSeOJ9NYaZqlxoPlOWoPiZxSYV63qsrNFwPpeuV8vNReFzQdAt8R7OZbrVk51siUanUv2+0zCRkespUetJUW4/o8kIQ30aLdJvANHvsCbKI4CWEiWplPzi9MkwoyIHe7p4Dfo07d8J8R6i1yAvSaMcwBocfoNMTNxALh3QF4QAw/TE8B5jtSpiaun/nXTmxXfsvvQd036OjyhkzoVWPYSh6sbB9cTLG1333fIdZfiGkgcN7lNz3w0M+EXaZtmhrZyNiqIPYXgBJxEqQ4eERAq1AXhrh+r8PHi2/U08PIxFyXXOp8Omzpgmm9c2oCBJMp2wxIXcvGQ4o5CciI9gBh5EG+1Gr+Vv9Es3GhYDKC+mYHhEMK9DmQFeLWKYY3n+PbZNbEs9/2ltPcZ9EOu4tqIxtd6DWdxHYKDMrLq1XrE5TSf0NAuTSNlAdgGZJcVXFhZ4UbDxMh3oVE+YfJhlZpPaZ3sUL1nUiM2CcZgO6kTpSsumhpABCfIa6CCCNct0xjJXMQbEw2BKTJfaWZ/4TBJOZY/jQXmUcmmzRnO499KVeWcWdPVK2mZUujI6p7TPTttlWlyW4LdQstpqO06r/VEXJZ7k3HbldXEWeyFRxs50LYO3hx6cmVTWhJjItGMfL3Bt/n1UgXlrnfLhQZ+YQ8Ty+0ISTfWuAFsc6ujAlgvTOnSm51vaUVogT5N0fWsJDloyZU5sTcQ1SGOTjPJaSHR5jZhA6/BOZI5+12RIc3GS+04ogW0pZDt1xcwROJIAw2Ynmu4ynbfh2jc/Qwe7iVdrvLzIKzivPRj4y4ZT/d0cJxaey5/wbuKIOiyoFUuRS5z4vEHmK 8S25h4Ga ArSPpeAt9IHvClM6NecLDenJP7u6VVdgsJli8f9Yv4NqA+GgU0g817SZEpBvTy0xSaGf9uA7BCz8p6hQaeMA6To5P2OxusHlMdhFlMCLIwP70S17cYT5xPHc0rmUbzZRoBat9Cl3XRyMVChOkFhZnzpmG/I6DvtoS5JSH5CJNpiO2uAeTIjBjruKPTB88oB+Cew+TBRckqHsu3h5DEtG+UhVD+GU7M4/Aft+A/quJJBYl5EYrrcheb3p6IgW8J/M60bQYRbkdva6fA5Fuxa9NSmnOSp/JUQRv+34+t0MP10J6VZoKJk7Mhc5I5W8VoVG42sBd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 01 Oct 2024 23:58:55 +0100, Mark Brown wrote: > @@ -4714,6 +4735,10 @@ void kvm_calculate_traps(struct kvm_vcpu *vcpu) > kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nPOR_EL1 | > HFGxTR_EL2_nPOR_EL0); > > + if (!kvm_has_gcs(kvm)) > + kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nGCS_EL0 | > + HFGxTR_EL2_nGCS_EL1); > + Why are you still allowing the GCS instructions when GCS isn't enabled? M. -- Without deviation from the norm, progress is not possible.