From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D11FD58D50 for ; Mon, 25 Nov 2024 14:36:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8C1A6B0083; Mon, 25 Nov 2024 09:36:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3C226B0088; Mon, 25 Nov 2024 09:36:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5396B0089; Mon, 25 Nov 2024 09:36:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E5156B0083 for ; Mon, 25 Nov 2024 09:36:19 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CFDF8C09C9 for ; Mon, 25 Nov 2024 14:36:18 +0000 (UTC) X-FDA: 82824867426.27.F1EE70E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id E0A7F2000C for ; Mon, 25 Nov 2024 14:36:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Oj96gdQc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KJEOAk54; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zaWIBWpT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EeY7XCXO; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732545373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4rX/atjbTAdi+cXVd9hXBgI2PKFmjTNixezlzIFGYPU=; b=M8EV6agGugWXgz/8YlKq9quYxQLFb7m+7W6Kah5vuD83SpjqTbtacW2n3lDp9MQ3TUo1fr Pju+Js5IIbYxbdOn4hiXSHEWGkQQ6eZgflg5ZOzksHrg4mOgkLRikguuKduuYkNCZOL64x ZNyUCSoGlBzkO9CeUjFnm0Ty5qxuvFw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Oj96gdQc; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=KJEOAk54; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zaWIBWpT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EeY7XCXO; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732545373; a=rsa-sha256; cv=none; b=KkSCxlMjl+918Rrma0ZoE+WlAOTFBGtwCMHBTuOWedMHGG3x+ChY0vjIj8eg2NuRrewO3M teTaSFUYjpA5DmFj4zqY47ckaazu4vfPY0JuHiVaeZ0FOPWijNAXCpvf6w+uXt87J5spLh C+kYJUMs91PhPZBBY9jeCvVSyLhQKgk= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D7A251F396; Mon, 25 Nov 2024 14:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732545375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4rX/atjbTAdi+cXVd9hXBgI2PKFmjTNixezlzIFGYPU=; b=Oj96gdQcJBIsZM1R+l0x6rsZfZW2eaYVHiqpqJhCb81I+eDYUx/uLeFN6TEGFABrqx3bpZ QqQ7qqmzCWTV/0RfqAPR/wKaiDRQ61No3czGsXzi9ykoN4H/IiXWX0qqXsOGONkQ2H+sQ4 QXN7Nt3EpL/YnwHfih4ZkTB4sQlN6nM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732545375; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4rX/atjbTAdi+cXVd9hXBgI2PKFmjTNixezlzIFGYPU=; b=KJEOAk54kvzyIw9T1p3dzYhPuVss0rYdgMLdsezsbbiGRWfmpqrR3JYld42bIKCEQa1YJz 2qQ4R13ZSYzvwADg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732545374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4rX/atjbTAdi+cXVd9hXBgI2PKFmjTNixezlzIFGYPU=; b=zaWIBWpTSgogTCxtaDVS+TSeZcac3PH4qUEwabkzoGMieN9gb8+TYd7F5HzuiSQejuukHy FNDqCgexTUHrfIIBwY+mmHTx1+3ePcceBCFffxr9CSPDdYn5EILH56dUkLrQExKGjSUSRV KNFwXjJslZ0RzWetTIluuoP3QgNOQVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732545374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4rX/atjbTAdi+cXVd9hXBgI2PKFmjTNixezlzIFGYPU=; b=EeY7XCXOQF479j/V5JT5WYcHBm07ChAvAYaqwJ9lredcTjro8QJai0BEhLNLH5GJHE2d+X wLn1G/i54kKxaOBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B3D91137D4; Mon, 25 Nov 2024 14:36:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VNSNK16LRGf4SgAAD6G6ig (envelope-from ); Mon, 25 Nov 2024 14:36:14 +0000 Message-ID: <86b93a99-e759-45b8-b73e-1b4e3e8bd2b9@suse.cz> Date: Mon, 25 Nov 2024 15:36:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5.15.y 0/4] fix error handling in mmap_region() and refactor (hotfixes) Content-Language: en-US To: Lorenzo Stoakes , stable@vger.kernel.org Cc: Andrew Morton , "Liam R . Howlett" , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu , Catalin Marinas , Will Deacon , Mark Brown , "David S . Miller" , Andreas Larsson , "James E . J . Bottomley" , Helge Deller References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E0A7F2000C X-Stat-Signature: f817g8t74yf5pcxqurdx4e1dz7zasfa3 X-Rspam-User: X-HE-Tag: 1732545370-832543 X-HE-Meta: U2FsdGVkX1/HYm/DwcozWPTcWgT3AWbY7joRKVP0Doqts3IoOWAmgslpyZFXcae/RIgdm50v3Adv8fUf1jSe/h+QMOAujV32lwhrKjVdwJXiPF3IRT0kyAtaO+7aD0/uhTAwCWKSMsfGpke29QzTuElGc26xye+Wiswjr18VNfti8kIDxFyB1BhyP8vdj8/hjvo+hOTacoUBWWXSmDWJpV3/vzmJOIv0OK1e2gLeY1jAPf4cTpQLBKMd7DAM3PjiRVMS0rEg4zKDZFwaaquwxxJ3sl1lwa27mswxlqTu2qZm82qaqCM+coc2LF1opUm3IvZp1I1cNy1V2tPCIHYzDEDKMq26e/AgX4dhhRyFN63Nh9AknrfndsIuN7/O2BSYNxgD8zdfiUYALD1cvLNo2FvL3vS9hUzHjFsOeQ5qdlyQFyErgKZ9m3vBCBH0m/r23Bd7b2bK1cxdJzbWObC2pRb7gaajFPFjWUl/9MtJtu7BSO+SvRKABDreH+4TgMMWPc5JSt35jMEg9DZR1BrztPz1xSlXCyKVSEpZ5rl6O3b80ZiXtro37pbLs7lPgE1yApA6G0EPedAIjrD8NS2Ll+ONVar6+V+vJ8BxTMBm2UIFKp5ev156gCw1coIfgcy5XwafIq6sDMkMPoQtuXQ9uLwssfviYiTQ5IuiBcgE5at5+H1N+U6XNzMGLCj9VgC4lUcnHyFYpvfCFVK9hkzxc0hvY7W8SEr1p9m8ifmUDMO3wmh5SkVcdrBOhoin7tjYkRW7V3XJriFKbkgMH4uMCxIuaQgl7zEusGGa+XBy+SUtPKeed8t7eIUr03DxLTzZ/U/VfBC3i1qgtodWbAJafNerxQ9Ik22eSdnagaQ8XTtkFTiKOFlrNjCkdl9n6vAXCgVfm5pqI/a7N6luB2lyzUOvj2qVcL88DqIqRcediVZjqQ3BMxjHMwg2g65WtdWx5R8/Vk8idkFQZQ2ySlW IqZPFjzl VdmDnljHEiwsR0LQG/l288tj+JfSehiWZnJ6nb6GDtpc5Up9rLfgbRrmSPFY3flB3g7Iqu/YRkw7vhoxoEZCDbcL0d5hASkyxzgrreZDTVFyYAojE/TNmumH0JkREs+dq+oiCGjddnyvZrXA8cQGIQ+be3dMY+4dLqa/mhbLkAFmCbXhdc5fc3RWCeZBuyQXCRWlaVnNlPgqAS5zKer8a2q2oIHoQci4lEXcLEGKUKZXtrmgptF+HbLV+Vz8NuztHx0pYHhacvNmJArFE2IRAonNjyQ0ArjYiYZGNteNUJD8YmrGe35wXP/2Ztn1eEWDAQmGWgpxaR5PuApWqGWas7SjYyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/24 13:38, Lorenzo Stoakes wrote: > Critical fixes for mmap_region(), backported to 5.15.y. > > Some notes on differences from upstream: > > * We do NOT take commit 0fb4a7ad270b ("mm: refactor > map_deny_write_exec()"), as this refactors code only introduced in 6.2. > > * We make reference in "mm: refactor arch_calc_vm_flag_bits() and arm64 MTE > handling" to parisc, but the referenced functionality does not exist in > this kernel. > > * In this kernel is_shared_maywrite() does not exist and the code uses > VM_SHARED to determine whether mapping_map_writable() / > mapping_unmap_writable() should be invoked. This backport therefore > follows suit. > > * The vma_dummy_vm_ops static global doesn't exist in this kernel, so we > use a local static variable in mmap_file() and vma_close(). > > * Each version of these series is confronted by a slightly different > mmap_region(), so we must adapt the change for each stable version. The > approach remains the same throughout, however, and we correctly avoid > closing the VMA part way through any __mmap_region() operation. > > Lorenzo Stoakes (4): > mm: avoid unsafe VMA hook invocation when error arises on mmap hook > mm: unconditionally close VMAs on error > mm: refactor arch_calc_vm_flag_bits() and arm64 MTE handling > mm: resolve faulty mmap_region() error path behaviour FWIW, looks good to me. Reviewed-by: Vlastimil Babka > arch/arm64/include/asm/mman.h | 10 ++-- > include/linux/mman.h | 7 +-- > mm/internal.h | 19 ++++++++ > mm/mmap.c | 86 +++++++++++++++++++++-------------- > mm/nommu.c | 9 ++-- > mm/shmem.c | 3 -- > mm/util.c | 33 ++++++++++++++ > 7 files changed, 119 insertions(+), 48 deletions(-) > > -- > 2.47.0