From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CE6CC433DF for ; Wed, 13 May 2020 19:08:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BB10A205ED for ; Wed, 13 May 2020 19:08:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="b5Et0h+N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB10A205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46E3D8002C; Wed, 13 May 2020 15:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F8E38000B; Wed, 13 May 2020 15:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6478002C; Wed, 13 May 2020 15:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id 1860C8000B for ; Wed, 13 May 2020 15:08:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CCB27180AD811 for ; Wed, 13 May 2020 19:08:38 +0000 (UTC) X-FDA: 76812632316.04.basin03_85a3cf7ca5049 X-HE-Tag: basin03_85a3cf7ca5049 X-Filterd-Recvd-Size: 3541 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 May 2020 19:08:38 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 13 May 2020 12:07:22 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 13 May 2020 12:08:36 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 13 May 2020 12:08:36 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 13 May 2020 19:08:36 +0000 Subject: Re: [PATCH] mm/hmm/test: fix an error code in hmm_dmirror_init() To: Dan Carpenter , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= CC: , References: <20200513094225.GE347693@mwanda> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <86b773ef-bc31-7d1c-f271-583c1f0a420a@nvidia.com> Date: Wed, 13 May 2020 12:08:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200513094225.GE347693@mwanda> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1589396842; bh=mINCvI4gI2qbbvGcwy+fHHBtl4Zj+bEhAa8NpAUA6aE=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=b5Et0h+N1drl4gzSU1TbCxwevl3nCnM+akbvWqzLpuhPrlXfaWsSHF1eJLq6pHcEp bEU54aPiolAQ5OpVdm0SrBYJQAT/WlMz3gjG85JEnxUNqIa+3lRb4Zcv8gs0aPE0xT djGg/aHPSyvmLWaI59mKB/eLZ4e5GlryCjB/o1unV/WIYOzSvz3i84unuUdV14EY9E OswKxrD0zhGq/o1Q8kQPa8E3cOCucKB+hLF+wh5B+KYA1uJC3Jh89ajOd/qPkwtJsb A4srYh5HIbx1NTZeGO9aZh/YWza/k87/RehE3O/1HCn56a/lCFu/vkv3hFNMmlC7Go jiqePHTWR6+ZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/13/20 2:42 AM, Dan Carpenter wrote: > If the allocation fails, then this should return -ENOMEM instead of > success. > > Fixes: a149d2eb654b ("mm/hmm/test: add selftest driver for HMM") > Signed-off-by: Dan Carpenter > --- > lib/test_hmm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 00bca6116f930..b4d9434e49e72 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -1119,8 +1119,10 @@ static int __init hmm_dmirror_init(void) > * make the code here simpler (i.e., we need a struct page for it). > */ > dmirror_zero_page = alloc_page(GFP_HIGHUSER | __GFP_ZERO); > - if (!dmirror_zero_page) > + if (!dmirror_zero_page) { > + ret = -ENOMEM; > goto err_chrdev; > + } > > pr_info("HMM test module loaded. This is only for testing HMM.\n"); > return 0; > Thanks for fixing this. It looks like Wei Yongjun beat you to it and Jason Gunthorpe has applied it to the hmm tree. https://lore.kernel.org/linux-mm/20200512195932.GB9154@ziepe.ca/