From: David Hildenbrand <david@redhat.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: hughd@google.com, willy@infradead.org, mgorman@suse.de,
muchun.song@linux.dev, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] asynchronously scan and free empty user PTE pages
Date: Mon, 17 Jun 2024 19:49:32 +0200 [thread overview]
Message-ID: <86b29391-ad2a-4c4b-b9a8-974d1876632c@redhat.com> (raw)
In-Reply-To: <f2fbf466-f722-4fd3-9883-189145e599f4@bytedance.com>
>>
>> No strong opinion, something synchronous sounds to me like the
>> low-hanging fruit, that could add the infrastructure to be used by
>> something more advanced/synchronously :)
>
> Got it, I will try to do the following in the next version.
>
> a. for MADV_DONTNEED case, try synchronous reclaim as you said
>
I think that really is the low hanging fruit that would cover quite some
cases already: (1) reclaim when MADV_DONTNEED spans the complete page table.
Then, there is (2) reclaim when MADV_DONTNEED spans only part of the
page table (e.g., single PTE), but my best guess is that it's better to
scan for that asynchronously than making possibly each MADV_DONTNEED
sycall invocation slower.
(1) would already help a lot and showcase how the locking/machinery
would work.
> b. for MADV_FREE case:
>
> - add a madvise option for synchronous reclaim
>
> - add another madvise option to mark the vma, then add its
> corresponding mm to a global list, and then traverse
> the list and reclaim it when the memory is tight and
> enters the system reclaim path.
> (maybe there is an option to unmark)
>
> c. for s390 case you mentioned, create a CONFIG_FREE_PT first, and
> then s390 will not select this config until the problem is solved.
>
> d. for lockless scan, try using disabling IRQ or (mmap read lock +
> pte_offset_map_nolock).
Although d) really only is desired when scanning asynchronously I think.
During (1) above, we know that the table will be very likely empty
(unless weird race).
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-17 17:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 8:38 Qi Zheng
2024-06-13 8:38 ` [RFC PATCH 1/3] mm: pgtable: move pte_free_defer() out of CONFIG_TRANSPARENT_HUGEPAGE Qi Zheng
2024-06-13 8:38 ` [RFC PATCH 2/3] mm: pgtable: make pte_offset_map_nolock() return pmdval Qi Zheng
2024-06-13 8:38 ` [RFC PATCH 3/3] mm: free empty user PTE pages Qi Zheng
2024-06-13 9:04 ` [RFC PATCH 0/3] asynchronously scan and " David Hildenbrand
2024-06-13 9:32 ` Qi Zheng
2024-06-13 10:25 ` David Hildenbrand
2024-06-13 11:59 ` Qi Zheng
2024-06-14 3:32 ` Qi Zheng
2024-06-17 17:51 ` David Hildenbrand
2024-06-18 7:52 ` Qi Zheng
2024-06-14 7:53 ` David Hildenbrand
2024-06-14 10:49 ` Qi Zheng
2024-06-17 17:49 ` David Hildenbrand [this message]
2024-06-18 7:51 ` Qi Zheng
2024-06-18 9:40 ` David Hildenbrand
2024-06-18 9:55 ` Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b29391-ad2a-4c4b-b9a8-974d1876632c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=muchun.song@linux.dev \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox