From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7783FC00140 for ; Wed, 24 Aug 2022 08:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11C466B0072; Wed, 24 Aug 2022 04:22:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A4E66B0073; Wed, 24 Aug 2022 04:22:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E60C6940007; Wed, 24 Aug 2022 04:21:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D137E6B0072 for ; Wed, 24 Aug 2022 04:21:59 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B995A0A9A for ; Wed, 24 Aug 2022 08:21:59 +0000 (UTC) X-FDA: 79833793158.25.2714D69 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 323EF20049 for ; Wed, 24 Aug 2022 08:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661329318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kaKoJSFhkLs3j9BMMpW4Sul91GROScQNC38GatdEuPY=; b=ftOp+I0P4rEOIt2ICz80cqZsX8j9OFF0uiUtQQFsEZ5AG7dAI/bJZWI156rvxdyq/mgGkV sPuvLq2en/7teneaD7ZL2/fESrKvnj+IgIwT8fBS4M7lmGkAUxU657II6bTFZG2FAaqM78 wn1hp2vTav0wWNfVnQPQSQtKsJmtSKA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-efpy7UZoN8y1recPHGD3xQ-1; Wed, 24 Aug 2022 04:21:57 -0400 X-MC-Unique: efpy7UZoN8y1recPHGD3xQ-1 Received: by mail-wr1-f72.google.com with SMTP id w2-20020adfbac2000000b00225688186e5so673874wrg.8 for ; Wed, 24 Aug 2022 01:21:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=kaKoJSFhkLs3j9BMMpW4Sul91GROScQNC38GatdEuPY=; b=0cI4tYyiBgrfFt6vC64TsjtArYETWgtZNdfHpZSGwt56mxyOfjc6cwzuvKebVnzudk /1y7p2gOEwh+wtn57/dziOKUF0xZ89/Jim8De1WO7uVx5XvBREmyXAOSQnkHcCwUV1Xt BFhnbq3doDUNEGQZc4pfb2R5TOSiFRixd2yu3CuuDfRsZ3RU9hdDMkHO+EgWoZkbeHjH Jq3ZHVZMx6paNcZfcr7xGSgcswxNl7fBaT5LcCi8B1WWGWr+1Ht/w39eSU/+ZFIvmMgB SUaAz4EQKCMFXxcrrGOU4sXKhejP1L/iIU2U7h7cEjj+vj+sha3cqK2i92Mg0u4IVj5n hneQ== X-Gm-Message-State: ACgBeo0glBFSna4asz+ANircyLH1H7JwQJxdQX3bral7nroNmZiQSWFl 5Thx4m+Fj1ErLUOUCWiIitRMgIY/UnvHK8Naw3TFIzELFviKG5lBGuKZGn6K5neGpt0nd4jkbC6 4q5jPyOm1bUo= X-Received: by 2002:adf:f644:0:b0:225:4cb4:c2f6 with SMTP id x4-20020adff644000000b002254cb4c2f6mr9491246wrp.552.1661329316185; Wed, 24 Aug 2022 01:21:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR4X7X3tYyJSmiUUp6I0Ru0wIROQJojmCwOUf92jP2yjlZsNTJSwC4WCw77h1/+kLqgmchleqA== X-Received: by 2002:adf:f644:0:b0:225:4cb4:c2f6 with SMTP id x4-20020adff644000000b002254cb4c2f6mr9491224wrp.552.1661329315912; Wed, 24 Aug 2022 01:21:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:c500:5445:cf40:2e32:6e73? (p200300cbc707c5005445cf402e326e73.dip0.t-ipconnect.de. [2003:cb:c707:c500:5445:cf40:2e32:6e73]) by smtp.gmail.com with ESMTPSA id v5-20020a1cac05000000b003a626055569sm1122379wme.16.2022.08.24.01.21.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 01:21:55 -0700 (PDT) Message-ID: <86b0622d-06eb-cfab-2ff1-8a0eaf823f8a@redhat.com> Date: Wed, 24 Aug 2022 10:21:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL To: Alistair Popple , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Peter Xu , Nadav Amit , huang ying , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org References: <3b01af093515ce2960ac39bb16ff77473150d179.1661309831.git-series.apopple@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3b01af093515ce2960ac39bb16ff77473150d179.1661309831.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ftOp+I0P; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661329319; a=rsa-sha256; cv=none; b=OCaXUITxv54TYfigej1Us5Fd/goCZ2l39NsieRzCb1GylVgCwCjzA/t3F2+yh0XX+4QEZx iw9WKigwTFJ3cZjEYz3ZwLlNyBek+mtGl6qVTNZNnazIgclAg3cVIIseMYyrBLKj19nwUW JKCB3AMiT7q6HtJURgPv5CCVSeq+2c4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661329319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kaKoJSFhkLs3j9BMMpW4Sul91GROScQNC38GatdEuPY=; b=0euM3+eOnm0uh4Ax42C/mBm+8F1Wx8seds+Rmx+fY/zo24b0ymXBzddngFlVv2lhsxLQfl RKl0wGgjUAGpS+ddGtcJDRmhqwtXpAx5il8xr2/AcjPUp1fWhpuFJcdSoaSe0t+I8a+war sTq+JxnOtXjHv38Iv/rm1q7ZLpLUVbQ= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ftOp+I0P; spf=pass (imf31.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Queue-Id: 323EF20049 X-Rspamd-Server: rspam05 X-Stat-Signature: 1o1jksy65hzoforzgqx8imsz6pseqtjy X-HE-Tag: 1661329319-511795 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.22 05:03, Alistair Popple wrote: > When clearing a PTE the TLB should be flushed whilst still holding the > PTL to avoid a potential race with madvise/munmap/etc. For example > consider the following sequence: > > CPU0 CPU1 > ---- ---- > > migrate_vma_collect_pmd() > pte_unmap_unlock() > madvise(MADV_DONTNEED) > -> zap_pte_range() > pte_offset_map_lock() > [ PTE not present, TLB not flushed ] > pte_unmap_unlock() > [ page is still accessible via stale TLB ] > flush_tlb_range() > > In this case the page may still be accessed via the stale TLB entry > after madvise returns. Fix this by flushing the TLB while holding the > PTL. > > Signed-off-by: Alistair Popple > Reported-by: Nadav Amit > Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") > Cc: stable@vger.kernel.org > > --- > > Changes for v3: > > - New for v3 > --- > mm/migrate_device.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index 27fb37d..6a5ef9f 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -254,13 +254,14 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > migrate->dst[migrate->npages] = 0; > migrate->src[migrate->npages++] = mpfn; > } > - arch_leave_lazy_mmu_mode(); > - pte_unmap_unlock(ptep - 1, ptl); > > /* Only flush the TLB if we actually modified any entries */ > if (unmapped) > flush_tlb_range(walk->vma, start, end); > > + arch_leave_lazy_mmu_mode(); > + pte_unmap_unlock(ptep - 1, ptl); > + > return 0; > } > > > base-commit: ffcf9c5700e49c0aee42dcba9a12ba21338e8136 I'm not a TLB-flushing expert, but this matches my understanding (and a TLB flushing Linux documentation I stumbled over some while ago but cannot quickly find). In the ordinary try_to_migrate_one() path, flushing would happen via ptep_clear_flush() (just like we do for the anon_exclusive case here as well), correct? -- Thanks, David / dhildenb