From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4386BD69103 for ; Thu, 28 Nov 2024 12:11:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9CD56B0083; Thu, 28 Nov 2024 07:11:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4CAC6B0085; Thu, 28 Nov 2024 07:11:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5F96B0088; Thu, 28 Nov 2024 07:11:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 89A026B0083 for ; Thu, 28 Nov 2024 07:11:14 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 34B94C1069 for ; Thu, 28 Nov 2024 12:11:14 +0000 (UTC) X-FDA: 82835388132.07.0DAB074 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id CD677180017 for ; Thu, 28 Nov 2024 12:11:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UkVMc3+q; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732795864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cdclCeziyhF3t1EMP1xj9jKJCRxwO1h/HitnW2pwBbY=; b=6l5N3CX39sQ7IwS0MUYdFFCXAYzCzccBafnPVXu+e04hMILUHmzH6GgLqIywPAgFzXer3J G+DR2Mgtmk/MEVAVvGsV1LL2Y+qjNxjO86+nGJ/aA3BxhRNFsPE4rMsNmCE34isoGNQ5uu Bgt7JVJ4KWpt8nZEZBgm4Y7fcTptu/U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732795864; a=rsa-sha256; cv=none; b=iJgqVMW29KqcybwK821Df0d2EmAzsjjOzRfKOQ4NmiaMWK9NA3YuByEHUYNqrjdU7rpv0N /l4vwpKq6eANfQJub7Ff+dx8Q0ku6hQsakSGX0eoKKWCqYgLPZqz6lu4vHlWHDgfP+9bcY pcSzQutWzyKr7uvW7XqQe8ymWICAvdc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UkVMc3+q; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732795871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cdclCeziyhF3t1EMP1xj9jKJCRxwO1h/HitnW2pwBbY=; b=UkVMc3+qOLicSa9inJuhxBZxsii3h5FoZ1l7Q7BYtFUahd5wVxmRqc4ix5J7q4ddYU0mIH bBtZQo2o3bWlQ2nP8L52P9fo1gLbMFM2XrL+PqWts+lCJNh4TSG+eIiqPeoxlfIsVMUw6o eKRTHdY3lnjTLHt0va1ej4wPm9SGEk4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-U6VRunXTMEyUrPEUeEj8-g-1; Thu, 28 Nov 2024 07:11:07 -0500 X-MC-Unique: U6VRunXTMEyUrPEUeEj8-g-1 X-Mimecast-MFC-AGG-ID: U6VRunXTMEyUrPEUeEj8-g Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-434a0d30c06so9735775e9.1 for ; Thu, 28 Nov 2024 04:11:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732795866; x=1733400666; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cdclCeziyhF3t1EMP1xj9jKJCRxwO1h/HitnW2pwBbY=; b=n+sTMqn53R5j8mcFR9mMjh3EzVrwThaJG3bhG34rD9sgjpnIl5hyCNJ16lqqNGCrXn Udcmy9amXkPaReLTTFCqyVwyVdoyRam0FAOU3ANsQoJNVx8nfdkuaTFKcBBwriC2rnUW FBXOwAhp+EbrHDuQCE0ns0Wk2UdGIY9pnc8iOlst+EjHK4MZDEN1btZXdmF80wVAUGeN +g8/zfL1LRlQ4gjpbkSiAYCeaiBUHN3VmariYg7pXKff+ggngwlXIzFC/pZ4RK2YcgTb jvAftVLYg6kVOjcYyTTxClFD2eUyDOYS/7tssFfwtq7tlOn0GLDfSacYzmlFgJ7LZ+6+ ZBbg== X-Forwarded-Encrypted: i=1; AJvYcCWgHj2KTd0WVFhdwVcuKTcMiyd616Il0+p8zwKafGAlgoxvu7OL6z2kCf6weYFXe+RZBVNe+2AdtA==@kvack.org X-Gm-Message-State: AOJu0Yy7wA1NMMACaW+m1FP1ObYv8+hO/EOzcIuwu1BLhDovTQRMKD5d w4l8veCSPV8Iliqf2JsotbHdejwtqZ1JDe0yUarJb4An7odp6mcDQvTY62krZyLOVCMhCXjGxTh +nB3LsuMV9YXJUIu7ySSXQr9BQ8qME5AIZM3pW24SDlvFb/xJ X-Gm-Gg: ASbGncuXCVlc1B1JU/AO8JQQAflRW2WC7HB/RmZQc1vPi2aU9FKOd3M4jKlrXCQuUsw CU2Mkslqw1Wm/Cp8akk3PR2Vl2Gs7FJ3BZN6pap+1tUNV9lYOfrZqFTuMobXZphds10m1nfE59Y If3DEJvgLGAtW+gZU84gdZ4wJbdF0Bj1t3Z1hU7+AlZTcVCDWaRLcBh3d/TlntE1XjJpyVWtA90 jhY6d//BeNNISsvCqcPOAxjNxac59gdyA/kfJUkuCCZMyTqGJ5pY5Ls9Ss7FaQn/CrlAix8AfJW kX891i1w4uhYOPcrg/mFs6xlvuaWhVKG4cNE7z03J3n4q9IN4ZhS/zquRLBS2rIA4ce0aUviumE = X-Received: by 2002:a05:600c:63c5:b0:434:9d3c:31ec with SMTP id 5b1f17b1804b1-434afc1d3f8mr25041535e9.10.1732795866606; Thu, 28 Nov 2024 04:11:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyXt9hljscSkPwsXGuKmVh0n7P6VgShBwAl49rkLvCMhh9odc+371Cg2jnWtIr4THHAsVJkg== X-Received: by 2002:a05:600c:63c5:b0:434:9d3c:31ec with SMTP id 5b1f17b1804b1-434afc1d3f8mr25041175e9.10.1732795866233; Thu, 28 Nov 2024 04:11:06 -0800 (PST) Received: from ?IPV6:2003:cb:c714:1600:f3b:67cc:3b88:620e? (p200300cbc71416000f3b67cc3b88620e.dip0.t-ipconnect.de. [2003:cb:c714:1600:f3b:67cc:3b88:620e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0dbe4e6sm20159125e9.14.2024.11.28.04.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Nov 2024 04:11:05 -0800 (PST) Message-ID: <86aef751-c2f8-4b9d-b7fc-ad9059c82858@redhat.com> Date: Thu, 28 Nov 2024 13:11:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/4] KVM: ioctl for populating guest_memfd To: kalyazin@amazon.com, pbonzini@redhat.com, corbet@lwn.net, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jthoughton@google.com, brijesh.singh@amd.com, michael.roth@amd.com, graf@amazon.de, jgowans@amazon.com, roypat@amazon.co.uk, derekmn@amazon.com, nsaenz@amazon.es, xmarcalx@amazon.com, Sean Christopherson , linux-mm@kvack.org References: <20241024095429.54052-1-kalyazin@amazon.com> <08aeaf6e-dc89-413a-86a6-b9772c9b2faf@amazon.com> <01b0a528-bec0-41d7-80f6-8afe213bd56b@redhat.com> <55b6b3ec-eaa8-494b-9bc7-741fe0c3bc63@amazon.com> <9286da7a-9923-4a3b-a769-590e8824fa10@redhat.com> <03a12598-74aa-4202-a79a-668b45dbcc47@amazon.com> <74cbda4a-7820-45a9-a1b2-139da9dae593@redhat.com> <8ac0e3e6-5af3-4841-b3ba-ab0458ab355b@amazon.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TbQ_EK8i9JcG8-GkZG08l278zPctNF1bFaXSwNcv_-Y_1732795866 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CD677180017 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ku11z4xqz9sqxm55ifseje96o36w9yep X-HE-Tag: 1732795866-322797 X-HE-Meta: U2FsdGVkX1+H8UD20RYfn3mZ4T7+0R0C+tZKertjKl5n9f1C+O2KYAQeT7gyYqK7Q+DwPhOGBojU0nEmDZx4zx1rQovvkNqpAdOGEzJXyX8yld3cRxuhctccbjymbJwojAfQOuD7skGzQdp9Mda3hXXQTCb9MyKT8O2qyBReFuK+gTSxZXU0Te4TtLDpgE6R5U3cNAQxWLRw6FtjT2xrZxpa3iPob9gvPFrGBwIy+3dSfHjBNm63LjZ+4QwGZXUITrGjysDMr0fAFETYlTehPWPTO3fPsrvW9rZQL+/c7ybpTUElYi+Ot71pBciTrwU/WHg1SXM++1wznu8kOJCldROiG5/ZDvrJGfZIKDyaYgK/8iIA91rdcTlwZtpUp5F3T6sbJaVUFrhznuGDNUcMUlWKS+O8N3yS3I0oEA7HN5JM7a93Bg4U5ezPEB1iSeSzN7d1i6WiIlvN1jG9XrFeD7F2Z+YGgoeA+YNOQEwEVd7h6NlMsVBBmU7ZrtKAYeomEwzMx0CiAz2xrC4JA47tAltERtBw7qZEyXulCvs4WWHopR4n6wWqlT6hz7aRKu9jx499dY4ctV051bGUcJqu/8xYTphwv9+Q9slOvk3XvQJM0HL+yM4up7ebU+eTwpXxWHR0k0+adg25cQpPkwXBbioyH24aqTPCmVwZtET6H3KoAei3blD6Yej2g08py2Ag5AkmidW+zwzXOsSqrEojwxS84DWgen/oIzdZkZwBtqbgbBiaJN8Tx+i0jiCZphFaj7uG3kPKHr8LgaOzuN6QiK6vv8qK3ncC7M/ibc3kLnmGuv7j4ALonF2MDxOIYkUmtT076vypM3iuEBFqhjc27VbX/NZFi8GRJJuKrnzyLzDFi4KkBWaac2VWnecUKrsCo1OOH8I53kUbtw3se1/edlzqvl0Y0bhZMIBH0OujVW8eeivu2zuZubm68ueXHDDJpaIBPgxkOFrd1WGZi2l gYJF1TYH TxLeYOPw0YocZqbWf7gg1oJsO+KtqkcT0oX5NHManpi457uKH+wmm8b3PDQ7f9tLMNnxB+R2saEjB0PEDhpIN7wWI6D7G8b56rb7fZ+Th2vCBOBX4pXvtzMEhX32XaECMMOcTE/IazSOMeAZZfBep2yCEIHVoOzdbBkHJbnmLbn2/p+okH99rx9m/bk8B1qTGomJz0+QNuupigw5mL0Qck9eUM9H9WW2iRBE4UIu4/0eiQ1FrU0FLUBb57zoRCYlMx/KD0aDdaBD57GRoA9srgY7e3gsXPhTGuM29GYGodWHrWdKlXjgPAKxsO+hYKAjyd3gY1CweLZmOKguobOs+QM9SyZgeVcFAB00PXgLXpk/jR3ozJgL/lutqqT9A2XMI7YCLNEfAyhF3/m1Yjl296yWWHAtnO8UErfLGOphq+i9zb3+S5Z0xjXOghw98oQ9Ej5KUPUKLymW+AXi5jHrTdCSP2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.11.24 17:04, Nikita Kalyazin wrote: > > > On 21/11/2024 16:46, Nikita Kalyazin wrote: >> >> >> On 20/11/2024 18:29, David Hildenbrand wrote: >> > Any clue how your new ioctl will interact with the WIP to have shared >> > memory as part of guest_memfd? For example, could it be reasonable to >> > "populate" the shared memory first (via VMA) and then convert that >> > "allocated+filled" memory to private? >> >> Patrick and I synced internally on this.  What may actually work for >> guest_memfd population is the following. >> >> Non-CoCo use case: >>  - fallocate syscall to fill the page cache, no page content >> initialisation (like it is now) >>  - pwrite syscall to initialise the content + mark up-to-date (mark >> prepared), no specific preparation logic is required >> >> The pwrite will have "once" semantics until a subsequent >> fallocate(FALLOC_FL_PUNCH_HOLE), ie the next pwrite call will "see" the >> page is already prepared and return EIO/ENOSPC or something. > > I prototyped that to see if it was possible (and it was). Actually the > write syscall can also do the allocation part, so no prior fallocate > would be required. Right > The only thing is there is a cap on how much IO can > be done in a single call (MAX_RW_COUNT) [1], but it doesn't look like a > significant problem. Does it sound like an acceptable solution? Does sound quite clean to me. Of course, one thing to figure out is how to enable this only for that special type of VM type, but that should be possible to be resolved. -- Cheers, David / dhildenb