From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9229AC36010 for ; Tue, 1 Apr 2025 02:51:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85439280002; Mon, 31 Mar 2025 22:51:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DB67280001; Mon, 31 Mar 2025 22:51:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A3DE280002; Mon, 31 Mar 2025 22:51:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4879A280001 for ; Mon, 31 Mar 2025 22:51:49 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E4E11409EB for ; Tue, 1 Apr 2025 02:51:49 +0000 (UTC) X-FDA: 83283949938.15.E2B43D0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id 266B2180007 for ; Tue, 1 Apr 2025 02:51:46 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743475907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GqouJgKo210/9lrjN1oAiWU6v4/ZZ2aGyt53puDEx8s=; b=L5VWtgeMO27RI+sJno6eHVwpkhOfj9b+/0AmoNgZmyixAFkc8JKSahmHn7lz+HdRjc9KgQ qw+SipjtdXrF5ZJ53VCgZmxCiJkE5sOywDGt9S51ArCjFknV0NiaxAlX0YtBaV0Hxb66wh ObRYa1rik8wysh2R481cN6otwREZFAk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743475907; a=rsa-sha256; cv=none; b=i+OGGfBTjswaaFQoTy7IO4lPn2Z95jW0DLKW5jBrViaWUnfoPxIzQfVgJiGsfGbBv1tulo 96xNvg8og+sE2nHC93MY2+1NDgzLhA/6bXFfc0D8JnumexcQxlxUehu9LedEyKtTboEd6I fooGdCDrX/vUbTM9dDg7z6Hp6A9qdOU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9F36714BF; Mon, 31 Mar 2025 19:51:49 -0700 (PDT) Received: from [10.162.16.153] (unknown [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 018F23F59E; Mon, 31 Mar 2025 19:51:39 -0700 (PDT) Message-ID: <86a276d6-afe3-4c70-aa85-7cafe33b8e5c@arm.com> Date: Tue, 1 Apr 2025 08:21:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/ptdump: Split note_page() into level specific callbacks To: Alexander Gordeev Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Steven Price , Ryan Roberts , Madhavan Srinivasan , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Gerald Schaefer , Heiko Carstens , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250317061818.16244-1-anshuman.khandual@arm.com> <20250317061818.16244-2-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 266B2180007 X-Stat-Signature: rba39n8egbz9ucgmpkrnixebqx1mnhi9 X-HE-Tag: 1743475906-596752 X-HE-Meta: U2FsdGVkX1/tY8/baqNyY4ds5JoFkwwzQa9plelq/OP/qrQGFu41fJlU+Z1kPWZeEJ6UjEy2T/n/+3cy9spC3Gadk/ljVgYQKBc4uSmtBuDD1pwxuHdGDEmPsBof/8g45L3ceK4n0kJ8jirC4YAUMswt8Dl6jqK9hCjkOQvgREJfXLbtvXDriUTaFZcjD8xlmx9Lzhn6oStiRa90YNvKiG22bbinKT+6rXG7T4h9RuGV0YEgiEBxDILEtljSGRt1mSCY8NePnfJj3K8IpwjY5mFb75cbRa6pPNRJ/Zc442Gc/2h2UPie2duJ3DxEMpJ641Y4ih65jXo7tBadaRYIOUPILWqvzDqJC5A9oWWhDVua6hjLr3vWw3h9hRrzlUdxKhbgglAiPLkMf9W1D5mzBzt7AmXaHpU/IZzmgmlVbj577IllSm9dB3fEeuM3HDQl3KQMB9/MRva3Lq4eqZ/hnp+Q227ApTjwQTqTdOlcrC0p5ZnlSAOTZXJe89tLv/+ubBj6oCo5y0aUxXnyMHQtsf8DYEa5+IeSo5Pl90Pq/vtpPe3JWI1oR/IJJLWIv9K+JraNrmHmG2cbUgqA+alN27Plqd9xftOOEDkJakVAMS+Ri85skwqHk0LdvG4wO5Inz4N1iPg0dXd4Luvbwef+wdlT9HsVdyYMXJ0dV8lUq157adYXC+ZVj4hL3HGcqqPraIqm0hYF7N2V3D7NNnrBCKOEap5Rb5lXoJAxVs9cFuTlw6fu/LPCR8CGYqNRq62AgyZmnz4OKuH5ksCY3G9yuzyrixjvzbd4BT9vYWbSfH5ZWljwL0z4ebpEW5S1K35EL9Uhan9sEUUDF6zpHAzU/D9qynfFVgP9fLtICFS6dW5Hvwbtg/cQUdAFhjOzrYk9u4LWx8vHlb/Yye2JVAeeweAIs+ByeHQdl6ojJEb/JxaMWGYtQlvDGXBXB1pbgU/FiObjotukAYohgnQh6Z/ eOiBEs8T nd/SJSnRDYFpqTuyglc+qObnmyJDcVv//GCIaxJ9OS71juYrhfaEgmJJ+X73dZ7JT1mDx4bgjixuLAC5pJpHDtGzXRsmtJrlWtv+0hI43z2qVhv5mMzBpUP8XKNWp7UPbY683cJu7a8TRyCLmE33ygsoKXHQfYNKWqJvcFAP0XuR+vPuXSJhgjNUFjmBhRGYESXp4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/31/25 14:29, Alexander Gordeev wrote: > On Mon, Mar 17, 2025 at 11:48:17AM +0530, Anshuman Khandual wrote: > > Hi Anshuman, > > ... >> --- a/include/linux/ptdump.h >> +++ b/include/linux/ptdump.h >> @@ -11,9 +11,12 @@ struct ptdump_range { >> }; >> >> struct ptdump_state { >> - /* level is 0:PGD to 4:PTE, or -1 if unknown */ >> - void (*note_page)(struct ptdump_state *st, unsigned long addr, >> - int level, u64 val); >> + void (*note_page_pte)(struct ptdump_state *st, unsigned long addr, pte_t pte); >> + void (*note_page_pmd)(struct ptdump_state *st, unsigned long addr, pmd_t pmd); >> + void (*note_page_pud)(struct ptdump_state *st, unsigned long addr, pud_t pud); >> + void (*note_page_p4d)(struct ptdump_state *st, unsigned long addr, p4d_t p4d); >> + void (*note_page_pgd)(struct ptdump_state *st, unsigned long addr, pgd_t pgd); >> + void (*note_page_flush)(struct ptdump_state *st); >> void (*effective_prot)(struct ptdump_state *st, int level, u64 val); > > Should you treat effective_prot() similarly? Agreed. effective_prot() also uses pxd_val() derived data type in generic MM and might cause the same problem later going ahead. Will split the helper into level specific callbacks as well. > >> const struct ptdump_range *range; >> };