From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB205C3DA6F for ; Thu, 24 Aug 2023 02:39:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCB98900016; Wed, 23 Aug 2023 22:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7BE38E0011; Wed, 23 Aug 2023 22:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6A95900016; Wed, 23 Aug 2023 22:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A9A1E8E0011 for ; Wed, 23 Aug 2023 22:39:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 72229C0183 for ; Thu, 24 Aug 2023 02:39:11 +0000 (UTC) X-FDA: 81157441302.05.753E386 Received: from out-22.mta0.migadu.com (out-22.mta0.migadu.com [91.218.175.22]) by imf08.hostedemail.com (Postfix) with ESMTP id 93E44160006 for ; Thu, 24 Aug 2023 02:39:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RjFYVgql; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.22 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692844748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vX+u7a0Gqj9nMclOVat5FHekgUmAUzik1MW7XrOxFX0=; b=JFu3Dadbj8DVCrsyrC6bhx0iwAP8B5HnJHLegbEthtZ7ov132CYogJcmNOB1wmV4BEnh36 m1Rt31Fp5tj8qN/XXyhVbCEEWhmjbAnVI5PwwOpxM8gTC6ORETLGV4PEn8kuqZ6s0rEOPR QgdjMiNVjrDwiIn/BeyVKGek/BXhsJg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=RjFYVgql; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.22 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692844748; a=rsa-sha256; cv=none; b=3F5lAj5YT4/9Ljthjt8JLk8HFrrQ5276mGNDCYLtBKq6StUcRKY/zsSGK49urIP6N7uAOY QCOkuB5miEXLOmNKJsqI1rn0UKkMx5ZIHfK5aOZDAClrAV8Xp0/VykriAudbln7VTg8axF q8iMT6iXxAs/JqQi7CUUVmJ5W6HkOK8= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1692844746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vX+u7a0Gqj9nMclOVat5FHekgUmAUzik1MW7XrOxFX0=; b=RjFYVgqla8YWQlPpmFD1pQaEDQbftd1jFKMJbr9Q3ulvPopVjCisycD8yI+nGCHADSMWrm G6QxkWIsGjeNpPKsVC28v3ChSgo6JSBfWNCTPN1vaAd9m5AFFE3pQDBVxBwjq9zdGvUTll xddrkTde+p5bY0ehFWUpcmai0KRWbr0= Mime-Version: 1.0 Subject: Re: [PATCH 3/3] hugetlb: Convert remove_pool_huge_page() to return a folio X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 24 Aug 2023 10:38:24 +0800 Cc: Mike Kravetz , Linux-MM , Sidhartha Kumar Content-Transfer-Encoding: quoted-printable Message-Id: <86EBBF89-AAF3-490D-88C9-F181F14D97B5@linux.dev> References: <20230822162808.4131399-1-willy@infradead.org> <20230822162808.4131399-3-willy@infradead.org> <20230823224813.GH50463@monkey> To: Matthew Wilcox X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 93E44160006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: o5msbckbagb4qipb5ddpewk7pk4azzi6 X-HE-Tag: 1692844748-349914 X-HE-Meta: U2FsdGVkX19IbhxjY6Uu8I7R8N4FfanfTxZ3HnkLi5uikbyXHtYZctNBkK5We4yxgTcW/NeRpP6GWxvgsvtO2E6U2RlghKnLNGEgIc5PzF715MKK0hNYK+iTd9M3V6YYe2rSGHO/O73Ey3Yf3YHr1YO4YnHCHtsMnBcm8gzNL78tGNTLb162KlZZ7HmNnDj6inNBqpRflArerPWW9Y7brLgLt13U/OJoHcOyi8EL4zSRwM1yhMMpM+Ij88iDLEKQjDt0sqY6Kozp0/qKHDT/q/yYLKuYrKl9zdIfk3J/eJeOBG2MgC1j0DeoL1qtl3Ayq4kfKXnMYHNAzMZCcyif/pjleiZYfBcGms/tGrcAvIfUqxgF9dX2KoH1VV96owEcTP7wM1VHrLe3x7DDNG5KUlrgD/94urHnldiNMJhMa/JdS5hD7vS4JJt3U2nFS33jQKbMT0aZG+jFKnBz36lfC4yBJ5HyQ6Cq74bfHKmhmPHuEN2hu9eUsCG9IfQ5O1rnNjy6mcFGXd7VjMp4jb+G0Q1Kx3crFOcDng+AmjsHFUVPtOFalddAkt7hbqrQ/xVWI8cU45+QX82Kpkoqv4CtLH3ra1g3WIa9FoopWSb/DyqcjVQBd9sgkFzc7U85OeyOr0wchwFsCAVSgMwdVK+IjeyhjbkIXLWiYFg11oYwkfw10sY15QK4EPPD+ehSQrHllN2kLVCJs6RSIGgW2OCtdYkl7sGoWybueednajSoluHTLxfUGZ1Po3kkupww4T0tlYH4k1oKpW+P4XZ1tjAJn0QwYPZOCTPEZzLsMWyQnfvtcmgtrrlXcBXDg5Zy5Em82vM+xfhOVgKlBuwI66+uL16qeSOyz5sGoWf8eEaByMAy/YNC9JOr9W4wtthp3RWTN/MNVHIfxvpi1kmzTOFhgbuHAlK5ZZIzpPnWGLF6emtR9MXOJMp9hXA6AKD5zOvM3XckAbWuNrFcj+9h0qU wzrqmn+v 28RD6ZzzZ7f3+7mvQGAtfEfdnqqjseb98kABdaEBZSqc3Q+ExkFJ67roMZuY0EBu0EHL0yACO6eljyw0eqa7F5YfZtu3+1VxUCONbsm0fPeYekbc/j2wxmjaew8HX5lm4YvjMOfkMqBstXmnHVwC8odaPDMQBVpQqA5lcO1kD1QUAlOHa8XZ2BvUPoQl1aQdx+1EQw4xoVHS3wLhixeCP8+siJd2Vcom1CLjv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 24, 2023, at 09:10, Matthew Wilcox wrote: >=20 > On Wed, Aug 23, 2023 at 03:48:13PM -0700, Mike Kravetz wrote: >>> -static struct page *remove_pool_huge_page(struct hstate *h, >>> - nodemask_t *nodes_allowed, >>> - bool acct_surplus) >>> +static struct folio *remove_pool_huge_page(struct hstate *h, >>> + nodemask_t *nodes_allowed, bool acct_surplus) >>=20 >> might have been good to make a simple name change to = remove_pool_huge_folio, >> but not insisting. >=20 > I wasn't sure what we were calling it now. I can go for huge_folio. >=20 However, there are so many places where it is hugetlb_folio, so I'd = suggest hugetlb_folio. Thanks.