* [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs()
@ 2018-06-20 11:09 Dan Carpenter
2018-06-20 15:25 ` Mike Kravetz
2018-06-22 11:15 ` David Howells
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-06-20 11:09 UTC (permalink / raw)
To: Mike Kravetz, David Howells; +Cc: linux-mm, kernel-janitors
We accidentally deleted the error code assignment.
Fixes: 9b82d88c136c ("hugetlbfs: Convert to fs_context")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 9a5c9fcf54f5..91fadca3c8e6 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -1482,8 +1482,10 @@ static int __init init_hugetlbfs_fs(void)
i = 0;
for_each_hstate(h) {
mnt = mount_one_hugetlbfs(h);
- if (IS_ERR(mnt) && i == 0)
+ if (IS_ERR(mnt) && i == 0) {
+ error = PTR_ERR(mnt);
goto out;
+ }
hugetlbfs_vfsmount[i] = mnt;
i++;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs()
2018-06-20 11:09 [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs() Dan Carpenter
@ 2018-06-20 15:25 ` Mike Kravetz
2018-06-22 11:15 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: Mike Kravetz @ 2018-06-20 15:25 UTC (permalink / raw)
To: Dan Carpenter, David Howells; +Cc: linux-mm, kernel-janitors
On 06/20/2018 04:09 AM, Dan Carpenter wrote:
> We accidentally deleted the error code assignment.
>
> Fixes: 9b82d88c136c ("hugetlbfs: Convert to fs_context")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for catching this,
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index 9a5c9fcf54f5..91fadca3c8e6 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -1482,8 +1482,10 @@ static int __init init_hugetlbfs_fs(void)
> i = 0;
> for_each_hstate(h) {
> mnt = mount_one_hugetlbfs(h);
> - if (IS_ERR(mnt) && i == 0)
> + if (IS_ERR(mnt) && i == 0) {
> + error = PTR_ERR(mnt);
> goto out;
> + }
> hugetlbfs_vfsmount[i] = mnt;
> i++;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs()
2018-06-20 11:09 [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs() Dan Carpenter
2018-06-20 15:25 ` Mike Kravetz
@ 2018-06-22 11:15 ` David Howells
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2018-06-22 11:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: dhowells, Mike Kravetz, linux-mm, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We accidentally deleted the error code assignment.
Thanks. I'll fold it into the original patch.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-22 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-20 11:09 [PATCH] hugetlbfs: Fix an error code in init_hugetlbfs_fs() Dan Carpenter
2018-06-20 15:25 ` Mike Kravetz
2018-06-22 11:15 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox